我正在编写需要读取二进制文件的 ac 程序,将其放入结构数组中,然后对该数组进行排序。结构:
#define NCHAR 64
typedef
struct data_
{
char country[NCHAR];
long int population;
float world_share;
}
data;
所有这些都发生在一个单独的函数中,该函数用于freed()从文件中获取数组。而且这个功能并没有真正起作用。我期望看到的:
CountryA 100 10%
CountryB 200 20%
我实际上得到了什么:
0 0 0%
0 0 0%
你能看看我做错了什么吗?我已经尝试重写我的代码并且可以并搜索fread()函数的用途,但似乎我使用它是正确的。
void SortAndDisplayASC( void )//main
{
FILE * worldData;
worldData = fopen("world.dat", "rb");
if(worldData == NULL)
{
printf("NO FILE CAN BE ACSESSED\n");
exit(1);
}
long size = fsize(worldData);
int amount = size / sizeof(data);
data * countries;
countries = (data *) malloc(size);
fread(countries, sizeof(data), amount, worldData); //PROBLEM HERE!
sortByPopulation(countries, amount);
for(int i = 0; i < amount; i ++)
{
PrintData(countries[i]);
}
free(countries);
fclose(worldData);
}
如果你愿意帮助我,我会分享整个代码。
后文:
你好,所有碰巧遇到这个问题的人。在撰写本文时,这是我的 C 作业。我当时在我的代码中发现并修复了这个错误,然后忘记发布它。现在我需要发布一个新问题,这个问题引起了我的注意。这是这个问题的源代码。这个版本应该可以正常工作。
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#define NCHAR 64
#define WPOP 7800000000L
typedef
struct data_
{
char country[NCHAR];
long int population;
float world_share;
}
data;
void menu(int option);
//1st choise
void EnterAndWrite( void );
void ScanData(data * subject);
//2nd choise
void ReadTheCountry( void );
void PrintData(data subject);
//3rd choise
void SortAndDisplayASC( void );
long fsize(FILE * f);
void sortByPopulation(data *array, int n);
void dataArrayItemSwap(data *array, int a, int b);
//4th choise
void SortAndDisplayDSC( void );
void dataArrayFlip(data *array, int length);
//5th choise
void SearchForCountry( void );
void findByName(data * array, int n);
int myStrcmp(char * s1, char * s2);
//6th choise
void CompareDataWithWPOP();
int main(void)
{
int option;
do
{
printf( " (*) Here you will be able do persform several actions over the file world.dat\n\n"
" (*) Enter 1 to enter the data of new country that will be added to file.\n"
" (*) Enter 2 to enter the position of the country in the file that you want to see.\n"
" (*) Enter 3 to show the database sorted by population in asceding order.\n"
" (*) Enter 4 to show the database sorted by population in desceding order.\n"
" (*) Enter 5 to search file for a specific country by its name or it's first lettes.\n"
" (*) Enter 6 to see total population stored in DB and compare it with world population.\n"
" (*) Enter 0 to teminate.\n");
scanf("%d%*c", &option);
menu(option);
}while(option > 0);
return 0;
}
void menu(int option)
{
switch(option)
{
case 1:
{
EnterAndWrite();
break;
}
case 2:
{
ReadTheCountry();
break;
}
case 3:
{
SortAndDisplayASC();
break;
}
case 4:
{
SortAndDisplayDSC();
break;
}
case 5:
{
SearchForCountry();
break;
}
case 6:
{
CompareDataWithWPOP();
break;
}
}
}
//6th choise
void CompareDataWithWPOP()
{
FILE * worldData;
worldData = fopen("world.dat", "rb");
if(worldData == NULL)
{
printf("NO FILE CAN BE ACSESSED\n");
exit(1);
}
long size = fsize(worldData);
int amount = size / sizeof(data);
data * countries;
countries = (data *) malloc(size);
fread(countries, sizeof(data), amount, worldData);
long int sum = 0;
for(int i = 0; i < amount; i ++)
{
sum += countries[i].population;
}
float share = (float)sum / WPOP;
printf("%ld %.2f%%\n", sum, share*100);
free(countries);
fclose(worldData);
}
//5th choise
void SearchForCountry( void )
{
FILE * worldData;
worldData = fopen("world.dat", "rb");
if(worldData == NULL)
{
printf("NO FILE CAN BE ACSESSED\n");
exit(1);
}
long size = fsize(worldData);
int amount = size / sizeof(data);
data * countries;
countries = (data *) malloc(size);
fread(countries, sizeof(data), amount, worldData);
findByName(countries, amount);
free(countries);
fclose(worldData);
}
void findByName(data * array, int n)
{
char request[NCHAR];
fgets(request, NCHAR-1, stdin);
request[strlen(request)-1] = '\0';
for(int i = 0; i < n; i ++)
{
if(myStrcmp(request, array[i].country) == 0)
{
PrintData(array[i]);
}
}
}
int myStrcmp(char * s1, char * s2)
{
int n = (strlen(s1) < strlen(s2)) ? strlen(s1) : strlen(s2);
char *temp = (char *) calloc(n+1, 1);
for(int i = 0; i < n; i ++)
{
temp[i] = (strlen(s1) > strlen(s2)) ? s1[i] : s2[i];
}
return (strlen(s1) > strlen(s2)) ? strcmp(temp, s2) : strcmp(s1, temp);
}
//4th choise
void SortAndDisplayDSC( void )//main
{
FILE * worldData;
worldData = fopen("world.dat", "rb");
if(worldData == NULL)
{
printf("NO FILE CAN BE ACSESSED\n");
exit(1);
}
long size = fsize(worldData);
int amount = size / sizeof(data);
data * countries;
countries = (data *) malloc(size);
fread(countries, sizeof(data), amount, worldData); //PROBLEM HERE!
sortByPopulation(countries, amount);
dataArrayFlip(countries, amount);
for(int i = 0; i < amount; i ++)
{
PrintData(countries[i]);
}
free(countries);
fclose(worldData);
}
void dataArrayFlip(data *array, int length)
{
data * temp;
temp = (data *) calloc(length, sizeof(data));
for(int i = 0; i < length; i++) temp[i] = array[(length - i) - 1];
for(int i = 0; i < length; i++) array[i] = temp[i];
free(temp);
}
//3rd choise
void SortAndDisplayASC( void )//main
{
FILE * worldData;
worldData = fopen("world.dat", "rb");
if(worldData == NULL)
{
printf("NO FILE CAN BE ACSESSED\n");
exit(1);
}
long size = fsize(worldData);
int amount = size / sizeof(data);
data * countries;
countries = (data *) malloc(size);
fread(countries, sizeof(data), amount, worldData); //PROBLEM HERE!(no problem now)
sortByPopulation(countries, amount);
for(int i = 0; i < amount; i ++)
{
PrintData(countries[i]);
}
free(countries);
fclose(worldData);
}
long fsize(FILE * f)
{
long lenght;
fseek(f, 0, SEEK_END);
lenght = ftell(f);
fseek(f, 0, SEEK_SET);
return lenght;
}
void sortByPopulation(data *array, int n)
{
//sorts countries in asceding order by population
for(int i = 0; i < n-1; i ++)
{
for(int j = i+1; j < n; j ++)
{
if(array[i].population > array[j].population)
{
dataArrayItemSwap(array, i, j);
}
}
}
}
void dataArrayItemSwap(data *array, int a, int b)
{
//changes places of 2 items in an array
data temp = array[b];
array[b] = array[a];
array[a] = temp;
}
//2nd choise
void ReadTheCountry( void )//main
{
FILE * worldData;
worldData = fopen("world.dat", "rb");
//test if file is a true thing
if(worldData == NULL)
{
printf("NO FILE CAN BE ACSESSED\n");
exit(1);
}
int n;
//get the country number to read(start form 0)
scanf("%d%*c", &n);
//caculating the position
int offset = sizeof(data) * n;
//moving to that position
fseek(worldData, offset, SEEK_SET);
data Country;
//reading data form that position
fread(&Country, sizeof(data), 1, worldData);
PrintData(Country);
fclose(worldData);
}
void PrintData(data subject)
{
//prints name, population and world share and starts a new line
printf("%-16s\t%10ld\t\t%5.2f%%\n", subject.country, subject.population, subject.world_share * 100);
}
//1st choise
void EnterAndWrite( void )//main
{
FILE * worldData;
worldData = fopen("world.dat", "ab");
//test if file can be acsessed
if(worldData == NULL)
{
printf("NO FILE CAN BE ACSESSED\n");
exit(1);
}
//get data to append the file
data Country;
ScanData(&Country);
//go to the end of file
fseek(worldData, 0, SEEK_END);
fwrite(&Country, sizeof(data), 1, worldData);
fclose(worldData);
}
void ScanData(data * subject)
{
//get name
fgets(subject->country, NCHAR-1, stdin);
subject->country[strlen(subject->country)-1] = '\0';
//get population
scanf("%ld%*c", &subject->population);
//find world share
subject->world_share = (float)subject->population / WPOP;
//end of the function;
}
这段代码与 world.dat 文件一起使用,其中描述国家的结构以二进制形式保存。我已将其转换为 base64,您可以自由地重新构建它。
Q2hpbmEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/////AAAAAAAAAAAAAAAAqIJW3/5/AAAQ9+BhGX8AAIBWylUAAAAAF/U8PgAAAABJbmRpYQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP////8AAAAAAAAAAAAAAACoglbf/n8AABD34GEZfwAAITJBUgAAAAB4KzU+AAAAAFVuaXRlZCBTdGF0ZXMAAAAAAAAAAAAAAAAAAAAAAAAA/////wAAAAAAAAAAAAAAAKiCVt/+fwAAEPfgYRl/AAAbs7oTAAAAAJ/RLT0AAAAASW5kb25lc2lhAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/////AAAAAAAAAAAAAAAAqOKfpf9/AAAQd1Kbw38AAJ+jTRAAAAAAjaIPPQAAAABQYWtpc3RhbgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP////8AAAAAAAAAAAAAAACo4p+l/38AABB3UpvDfwAAtIwqDQAAAABc/uc8AAAAAEJyYXppbAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/////wAAAAAAAAAAAAAAAKjin6X/fwAAEHdSm8N/AAA5ZqsMAAAAAO093zwAAAAATmlnZXJpYQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/////AAAAAAAAAAAAAAAAqOKfpf9/AAAQd1Kbw38AAMVwSQwAAAAA2n/YPAAAAABCYW5nbGFkZXNoAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP////8AAAAAAAAAAAAAAACo4p+l/38AABB3UpvDfwAA5/XQCQAAAABR96w8AAAAAFJ1c3NpYQAAc2gAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/////wAAAAAAAAAAAAAAAKjin6X/fwAAEHdSm8N/AAB+yLIIAAAAAMNEmTwAAAAATWV4aWNvAABzaAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/////AAAAAAAAAAAAAAAAqOKfpf9/AAAQd1Kbw38AAJFbrwcAAAAAlmmHPAAAAABKYXBhbgAAAHNoAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP////8AAAAAAAAAAAAAAACo4p+l/38AABB3UpvDfwAAreCJBwAAAAAt1YQ8AAAAAEV0aGlvcGlhAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/////wAAAAAAAAAAAAAAAKjin6X/fwAAEHdSm8N/AACENNoGAAAAAIR7cTwAAAAAUGhpbGlwcGluZXMAAAAAAAAAAAAAAAAAAAAAAAAAAAD/////AAAAAAAAAAAAAAAAqOKfpf9/AAAQd1Kbw38AABYTiAYAAAAALS1mPAAAAABFZ3lwdAAAaW5lcwAAAAAAAAAAAAAAAAAAAAAAAAAAAP////8AAAAAAAAAAAAAAACo4p+l/38AABB3UpvDfwAAxH8ZBgAAAABo9FY8AAAAAFZpZXRuYW0AAGVzAAAAAAAAAAAAAAAAAAAAAAAAAAAA/////wAAAAAAAAAAAAAAAKjin6X/fwAAEHdSm8N/AADTRM0FAAAAAP91TDwAAAAAQ29uZ28AAAAAZXMAAAAAAAAAAAAAAAAAAAAAAAAAAAD/////AAAAAAAAAAAAAAAAqOKfpf9/AAAQd1Kbw38AADuZVgUAAAAA9x88PAAAAABUdXJrZXkAAABlcwAAAAAAAAAAAAAAAAAAAAAAAAAAAP////8AAAAAAAAAAAAAAACo4p+l/38AABB3UpvDfwAAe+kGBQAAAADBJzE8AAAAAElyYW4AAAAAAGVzAAAAAAAAAAAAAAAAAAAAAAAAAAAA/////wAAAAAAAAAAAAAAAKjin6X/fwAAEHdSm8N/AAB1oQEFAAAAAKNtMDwAAAAAR2VybWFueQAAZXMAAAAAAAAAAAAAAAAAAAAAAAAAAAD/////AAAAAAAAAAAAAAAAqOKfpf9/AAAQd1Kbw38AAAZx/gQAAAAAP/0vPAAAAABUaGFpbGFuZAAAcwAAAAAAAAAAAAAAAAAAAAAAAAAAAP////8AAAAAAAAAAAAAAACo4p+l/38AABB3UpvDfwAAKhApBAAAAAChnRI8AAAAAA==
原始文件的MD5:
c2c0571518b47973f719f5dba96621dc
原始文件的 SHA256:
10ba4a9bc275b2c12f1b1f52fefc124d83df4485fe24c40ffcf5ca97830f1721
所以,据我记得,fsize 函数中有一个错误,它在一个奇怪的情况下返回了错误的文件大小。这个版本应该没有bug。
感谢所有试图帮助我的人!