7

我正在监督一个技术营,其中一名营员为基于文本的视频游戏创建了一些代码,但他无法显示结果。虽然程序编译并正确运行,但选择“治愈”时,它不会增加玩家的健康,当用户选择“攻击”时,我们也将获得零。我在编程方面的知识有限,并且正在尽我所能帮助他,以便他在这里的经历将是愉快和充实的。如果您能提供任何帮助或建议,我们将不胜感激。这是代码:

// Test for hard stuff.cpp : Defines the entry point for the console application.
//
// Bigger proj
// Constructors will make characters with rolling statistics

#include "stdafx.h"
#include <iostream>
#include <string> 
#include <stdio.h>
#include <stdlib.h>
#include <time.h>

using namespace std;
// declaring function for hit power
//int power( int str, int def);

    int command;


class character
{
public:
    character();
    //~character();
    string name;
    float str;
    float def;
    float health;   // hit points
    float regen;    // health regen amount
    float roll;     // for random value
    float ouch;     // amount of attack damage
    float getAttack(void);
    float getHeal(void);
    void setRegen(float reg);
    //void setHeal(float healAmt);

private:


};

character::character()
{
    srand(time_t(NULL));
    str = rand() % 30 + 5;
    def = rand() % 30 + 5;
    health = 100;
    //Output to check the constructor is running properly
    cout<< "Character has been created.\n";
}

void character::setRegen( float reg )
{
    regen = reg;
}


float character::getAttack()
{
//defines the magnitude/power of attack
    //function shows how much damage is inflicted


    // ouch is how much damage is done
    roll = rand() % 20 + 1; // range between 1 &20

    if (roll <= 11)
    {
        ouch = str - (def /2);
    }

    else if ((roll <= 17) && (roll >= 12))
    {
        ouch = (str * 2) - (def / 2);
    }

    else if ((roll <= 20) && (roll >= 18))
    {
        ouch = (str * 3) - (def / 2);
        //cout << "CRITICAL HIT!!";
    }

    return ouch;

}

float character::getHeal()
{
    //this is what happens when you chose to heal
    regen = rand() % 20 + 3;
    cout << "regen value= " << regen<< ".\n";
    return regen;
}

/*character::~character()
{
    str = 0;
    def = 0;
    health = 0;
    // Output to check the destructor is running properly
    cout << "Character has been destroyed\n";
} */


int _tmain(int argc, _TCHAR* argv[])
{
    //Class objects
    character user, computer;
    //Hard code in a name for the computer's player
    computer.name = "ZOID\n";

    float attackDamage;
    float healthAdded;

    user.setRegen(void);

    //Recieve data for the user's player
    cout<< "Please enter a name for your character:\n";
    cin>> user.name;

    //Output name and stats to the user 
    cout<< "\nYour name is: " << user.name << endl;
    cout << "here are your statistics: \n"
        << "strength:   " << user.str << endl
        << "Defense:    " << user.def << endl
        << "Health:     " << user.health << endl;

    cout<< "oh no an oppenent appeared!!!\n";
        cout<< "you will have to fight him!" << endl<< endl;

    cout << "opponent's health: 100"  << endl

        << "what would you like to do: heal (1), attack(2), or run(3).\n";
    cin>> command;




        switch(command)
        {
        case 1 :

            healthAdded = user.getHeal();

            cout<< ""<<user.name <<" has regenerated " << healthAdded << " health.\n";

            break;

        case 2 :

            attackDamage = user.getAttack();

            cout << "" <<user.name <<" did " << attackDamage << " damage to the opponent!\n";

            break;

        case 3:

            cout<< ""<<user.name<<" got away!\n";

            break;

        default:
            cout<< "Please enter a valid choice!";

        } //end switch

    return 0;

}
4

2 回答 2

6

我会尽力帮助一次。我的行号可能与您的略有不同,所以请随意环顾四周。

在:

 115     user.setRegen(void);

setRegen被宣布采取float

 20 class character
 21 {
 22 public:
 .
 .
 .
 34     void setRegen(float reg);

所以你不能通过void。顺便说一句,在 C++ 中,通常在调用不带参数的函数时不传递任何内容,而不是传递显式的void. 但是,显式void是可以的。

getHeal()函数计算一个随机数量来治愈角色,但它实际上并没有增加health成员变量。你可以用这种方式实现愈合,见第 92 行:

 87 float character::getHeal()
 88 {   
 89     //this is what happens when you chose to heal
 90     regen = rand() % 20 + 3;
 91     cout << "regen value= " << regen<< ".\n";
 92     health += regen;
 93     return regen;
 94 }   Z

当你攻击时,你也不会降低对手的生命值。您可能会这样做的一种方法是将对对手的引用传递给getAttack()并在那里修改它:

 58 float character::getAttack(character& opponent)
 59 {
 60 //defines the magnitude/power of attack
 61     //function shows how much damage is inflicted
 62 
 63 
 64     // ouch is how much damage is done
 65     roll = rand() % 20 + 1; // range between 1 &20
 66 
 67     if (roll <= 11)
 68     {
 69         ouch = str - (def /2);
 70     }
 71 
 72     else if ((roll <= 17) && (roll >= 12))
 73     {
 74         ouch = (str * 2) - (def / 2);
 75     }
 76 
 77     else if ((roll <= 20) && (roll >= 18))
 78     {
 79         ouch = (str * 3) - (def / 2);
 80         //cout << "CRITICAL HIT!!";
 81     }
 82 
 83     opponent.health -= ouch;
 84 
 85     return ouch;
 86 
 87 }

您还需要更改以下声明(原型)getAttack()

 20 class character
 21 {
 22 public:
 .
 .
 .
 32     float getAttack(character& opponent);

...以及它是如何被调用的main()

152         case 2 :    
153     
154             attackDamage = user.getAttack(computer);
155     
156             cout << "" <<user.name <<" did " << attackDamage << " damage to the opponent!\n";
157 
158             break;

我还注意到程序根本没有循环。它只接受一个动作,执行它,然后终止。如果游戏循环直到其中一名玩家死亡,游戏可能会更有趣。

最后一件事,当使用随机数时,您srand通常在程序运行开始时调用恰好一个。每次character创建 a 时都会调用它。

是我之前关于使用的答案之一的无耻插件rand

我为你做了一些修改。这是ideone 的链接,代码如下:

// Test for hard stuff.cpp : Defines the entry point for the console application.
//
// Bigger proj
// Constructors will make characters with rolling statistics

//#include "stdafx.h"
#include <iostream>
#include <string> 
#include <stdio.h>
#include <stdlib.h>
#include <time.h>

using namespace std;
// declaring function for hit power
//int power( int str, int def);

    int command;


class character
{
public:
    character();
    //~character();
    string name;
    float str;
    float def;
    float health;   // hit points
    float regen;    // health regen amount
    float roll;     // for random value
    float ouch;     // amount of attack damage
    float getAttack(character& opponent);
    float getHeal(void);
    void setRegen(float reg);
    bool IsAlive() const;
    //void setHeal(float healAmt);

private:


};

character::character()
{
    str = rand() % 30 + 5;
    def = rand() % 30 + 5;
    health = 100;
    //Output to check the constructor is running properly
    cout<< "Character has been created.\n";
}

bool character::IsAlive() const
{
    return health > 0.0f;
}

void character::setRegen( float reg )
{
    regen = reg;
}


float character::getAttack(character& opponent)
{
//defines the magnitude/power of attack
    //function shows how much damage is inflicted


    // ouch is how much damage is done
    roll = rand() % 20 + 1; // range between 1 &20

    if (roll <= 11)
    {
        ouch = str - (def /2);
    }

    else if ((roll <= 17) && (roll >= 12))
    {
        ouch = (str * 2) - (def / 2);
    }

    else if ((roll <= 20) && (roll >= 18))
    {
        ouch = (str * 3) - (def / 2);
        //cout << "CRITICAL HIT!!";
    }

    opponent.health -= ouch;

    return ouch;

}

float character::getHeal()
{
    //this is what happens when you chose to heal
    regen = rand() % 20 + 3;
    cout << "regen value= " << regen<< ".\n";
    health += regen;    
    return regen;
}
/*character::~character()
{
    str = 0;
    def = 0;
    health = 0;
    // Output to check the destructor is running properly
    cout << "Character has been destroyed\n";
} */


int main()
{
    srand(time_t(NULL));
    //Class objects
    character user, computer;
    //Hard code in a name for the computer's player
    computer.name = "ZOID\n";

    float attackDamage;
    float healthAdded;

    user.setRegen(42.0);

    //Recieve data for the user's player
    cout<< "Please enter a name for your character:\n";
    cin>> user.name;

    //Output name and stats to the user 
    cout<< "\nYour name is: " << user.name << endl;
    cout << "here are your statistics: \n"
        << "strength:   " << user.str << endl
        << "Defense:    " << user.def << endl
        << "Health:     " << user.health << endl;

    cout<< "oh no an oppenent appeared!!!\n";
        cout<< "you will have to fight him!" << endl<< endl;

    cout << "opponent's health: 100"  << endl;


    while (user.IsAlive() && computer.IsAlive())
    {
        cout << "Str: " << user.str << "\t"
            << "Def: " << user.def << "\t"
            << "Health: " << user.health << "\t"
            << "\n";

        cout << "what would you like to do: heal (1), attack(2), or run(3).\n";
        cin>> command;

        switch(command)
        {
        case 1 :

            healthAdded = user.getHeal();

            cout<< ""<<user.name <<" has regenerated " << healthAdded << " health.\n";

            break;

        case 2 :

            attackDamage = user.getAttack(computer);

            cout << "" <<user.name <<" did " << attackDamage << " damage to the opponent!\n";

            break;

        case 3:

            cout<< ""<<user.name<<" got away!\n";

            break;

        default:
            cout<< "Please enter a valid choice!";

        } //end switch
    }
    return 0;

}
于 2013-07-10T19:32:23.807 回答
2

通常,解决此类问题的一种方法是逐行检查发生的情况并确定每行的作用。有时很长(很多时候,真的),但也能很好地确保你不会错过任何东西。在这种特殊情况下,让我们看看愈合问题。

当您输入 switch 语句并点击 case 1(修复)时,代码所做的第一件事就是将 user.getHeal() 的结果分配给 healthAdded。你从这里做的是“步入”getHeal(),看看它做了什么。getHeal() 获取一个再生编号,并将其分配给再生。然后它打印 regen,最后返回你存储在 regen 中的值。

现在我们知道 getHeal() 做了什么,我们可以跳回到我们的案例 1:并完整地说第一行做了什么。它采用 getHeal() 中内置的 regen 值并将其分配给 healthAdded。

案例 1:然后在中断前打印 healthAdded 中的值;陈述。休息; 完成案例1。

因此,您的代码以快速列表形式执行的是:

  • 产生治疗值
  • 打印两次

您要做的是根据 regen 值修改用户的健康状况,因此您缺少一个步骤:使用您在 getHeal() 中构建的 regen 数更改 user.health 值。

攻击伤害的问题是类似的,尝试将您希望代码以类似目标的方式执行的操作与您看到的代码实际执行的操作进行比较。

于 2013-07-10T19:17:33.640 回答