字符串连接与加法不同。你需要确保你处理的是数字,而不是字符串。
calculatechance
也就是说,您的函数还有许多其他潜在的陷阱。
您在需要时声明变量,然后在以后重新声明变量,所有这些都会因为变量提升而给您带来麻烦。
您正在使用“ Truthy and Falsy ”值,这本身并不一定是坏事,事实上(恕我直言,JavaScript 的美丽部分之一),但除非您了解它的工作原理,否则您可能会遇到麻烦。
您似乎正在使用匿名代码块:
{
if (decimator == 0) {
var decimatormult = 1;
};
if (!decimator == 0) for (var decimatormult = 1; decimator > 0; decimator--) {
decimatormult * 1.07
}
}
而且我不确定不同的浏览器会如何解释它。最好消除它们并使用注释来描述部分。
您正在覆盖totalattack
您可能不想要的值。
总而言之,您的函数可能更好地写为:
var calculatechance = function calculatechance() {
'use strict';
var bane = parseFloat(document.getElementById('bane').value, 10) || 0, // Convert to a number (float) and default to 0 if parsing fails.
cbane = parseFloat(document.getElementById('cbane').value, 10) || 0,
obane = parseFloat(document.getElementById('obane').value, 10) || 0,
hbane = parseFloat(document.getElementById('hbane').value, 10) || 0,
mbane = parseFloat(document.getElementById('mbane').value, 10) || 0,
exotic = parseFloat(document.getElementById('exotic').value, 10) || 0,
decimator = parseFloat(document.getElementById('decimator').value, 10) || 0,
mindcontrol = parseFloat(document.getElementById('mindcontrol').value, 10) || 0,
translator = parseFloat(document.getElementById('translator').value, 10) || 0,
anubix = parseFloat(document.getElementById('anubix').value, 10) || 0,
attack = parseFloat(document.getElementById('attack').value, 10) || 0,
// Calculate Invasion Attack
anubixattack = anubix === 100 ? 1 : 0, // Use of ternary operator
// Check Checkboxes
obelisk = document.getElementById("obelisk").checked ? 1 : 0, // Use of ternary operator with truthy/falsy as .checked equals "checked" (truthy) or "" (falsy)
foci = document.getElementById("foci").checked ? 1 : 0,
amp = document.getElementById("amp").checked ? 1 : 0,
overcharge = document.getElementById("overcharge").checked ? 1 : 0,
crux = document.getElementById("crux").checked ? 1 : 0,
mech = document.getElementById("mech").checked ? 1 : 0,
DSC = document.getElementById("DSC").checked ? 1 : 0,
kulgox = document.getElementById("kulgox").checked ? 1 : 0,
terror = document.getElementById("terror").checked ? 1 : 0,
psionic = document.getElementById("psionic").checked ? 1 : 0,
mutagen = document.getElementById("mutagen").checked ? 1 : 0,
stryll = document.getElementById("stryll").checked ? 1 : 0,
cartridge = document.getElementById("cartridge").checked ? 1 : 0,
// Other variables
exoticatt = 0,
decimatormult = 1,
totalattack = attack,
invasionattack = 0;
// Calculate Exotic Bio Disruptor Multiplier
// no logic currently here
// Calculate Exotic Bio Disruptor Static IAttack
switch (exotic) {
case 0:
exoticatt = 0;
break;
case 1:
exoticatt = 250;
break;
case 2:
exoticatt = 350;
break;
default:
exoticatt = (100 * exotic) + 150;
break;
}
//Calculate Atmospheric Decimator Multiplier
if (decimator !== 0) {
while (decimator > 0) {
decimatormult *= 1.07;
decimator -= 1;
}
}
//Calculate Attack
if (obelisk) {
totalattack += attack * 1.1;
}
if (foci) {
totalattack *= 1.05;
}
if (amp) {
totalattack *= 1.15;
}
if (crux) {
totalattack *= 1.1;
}
if (overcharge) {
totalattack *= 1.08;
}
if (anubixattack) {
totalattack += attack * 1.03;
}
//Calculate Invasion Attack
invasionattack = (
totalattack
+ (600 * DSC)
+ (60 * translator)
+ (35 * mindcontrol)
+ (30 * psionic)
+ (40 * mutagen)
+ (2500 * cartridge)
+ (300 * stryll)
+ (15 * mech)
+ (20 * bane)
+ (30 * cbane)
+ (60 * hbane)
+ (45 * obane)
+ (75 * mbane)
+ (decimator * 200)
+ exoticatt
);
alert('Invasion Attack From Modules: ' + invasionattack.toString());
invasionattack = invasionattack * decimatormult;
if (kulgox) {
invasionattack *= 1.1;
}
if (terror) {
invasionattack *= 1.08;
}
alert('Invasion Attack: ' + invasionattack);
};