1

我知道通过更改三角函数名称我摆脱了段错误。但是,我并不完全清楚为什么。我的猜测是我在我的实现中得到了递归调用。有人可以在这里给出严格的解释吗?

此外,我愿意保持这种方式,因此我想知道应该添加/修改什么以保持我的函数名称不变。

PS:我知道这是一个愚蠢的问题,只是从这里开始 c++,所以请多多包涵。:)

代码:

#include <iostream>
#include <string>
#include <cmath>

#define _USE_MATH_DEFINES

using namespace std;

/*
   Represents a calculator with various functions.
*/
class Calc {
public:
    //arithmetic functions
    static double sum(double a, double b){ return a+b; };
    static double subtract(double a, double b){ return a-b;};
    static double multiply(double a, double b){ return a*b; };
    static double divide(double a, double b){ if (b == 0) return b; return a/b; };
    static double avg(double a, double b){ return (a+b)/2; };

    //trigonometric funcitons
    static double sin(double x){ return sin(M_PI*x); };
    static double cos(double x){ return cos(M_PI*x); };
    static double tan(double x){ return tan(M_PI*x); };
};

void getValue(double *a){
    cout << "Please, enter a value: " << endl;
        cin >> (*a);
}

void getValues(double *a, double *b){
    cout << "Please, enter two values: " << endl;
        cin >> (*a) >> (*b);
}

bool getCommand(string *cmd){
    cout << "Please, enter a command (+,-,*,/,avg, sin, cos, tan, exit): ";
    cin >> (*cmd);
    if ( (*cmd) == "exit"){
        return false;
    } else {
        return true;
    }
}

int main (){
    string cmd;
    double a,b;

    while (getCommand(&cmd)){
        if (cmd == "sin" || cmd == "cos" || cmd == "tan"){
            getValue(&a);
            if (cmd == "sin"){
                cout << "Sine: " << Calc::sin(a) << endl;
            } else if (cmd == "cos"){
                cout << "Cosine: " << Calc::cos(a) << endl;
            } else if (cmd == "tan"){
                cout << "Tangent: " << Calc::tan(a) << endl;
            }
        } else {
            getValues(&a,&b);
            if (cmd == "+"){
                cout << "Summation: " << Calc::sum(a,b) << endl;
            } else if (cmd == "-"){
                cout << "Subtracttion: " << Calc::subtract(a,b) << endl;
            } else if (cmd == "*"){
                cout << "Multiplication: " << Calc::multiply(a,b) << endl;
            } else if (cmd == "/"){
                cout << "Division: " << Calc::divide(a,b) << endl;
            } else if (cmd == "avg"){
                cout << "Average: " << Calc::avg(a,b) << endl;
            }
        }
    }
    return 0;
}
4

2 回答 2

7

你明白了,递归调用。我想你想要

static double sin(double x){ return ::sin(M_PI*x); };

使用范围解析运算符::将使您的 sin 函数调用全局 sin 函数,而不是递归调用您的函数。

顺便说一句,如果您尝试将度数转换为弧度,那么您实际上需要

static double sin(double x){ return ::sin((M_PI/180.0)*x); };

于 2012-11-15T08:06:35.287 回答
1

1)你应该#define _USE_MATH_DEFINES 你之前#include <cmath>

2)您的Calc函数确实包含无限递归(它们正在调用自己)。您需要按如下方式更改它们:

static double sin(double x){ return std::sin(M_PI*x); }

也就是说,对调用进行限定以sin()明确您要调用全局调用。

于 2012-11-15T08:07:20.873 回答