-1

我很陌生C#,我正在尝试将一个通用串行端口用于 3 种不同的形式:Form2, Form3, Form4

Form1.cs不需要这个,因为它只需要启动其他形式的程序。基本上,所有 3 种形式都必须同时从同一个串口接收数据。我面临的问题是只有一种形式可以从串口接收数据,而其他两种形式不能。

我发现了一个类似的问题:

在两种不同的形式上使用相同的串口数据接收事件

这个问题和我的一样吗?如果是,我可以知道我应该将示例代码放在代码中上述链接的什么位置吗?

有人可以帮忙吗?提前致谢!

表格1:

public partial class Form1 : Form
{
    public Form1()
    {
        InitializeComponent();
    }

    private void button1_Click(object sender, EventArgs e)
    {
        Form2 f2 = new Form2();
        f2.Show();
        Form3 f3 = new Form3();
        f3.Show();
        Form4 f4 = new Form4();
        f4.Show();
    }

    private void button2_Click(object sender, EventArgs e)
    {
        this.Close();
    }
}

表格2:

public partial class Form2 : Form
{
    GMapControl MainMap = new GMapControl();
    //Initialise data type for latituide and longitude
    double lat, lng;
    //Initialise customise marker (plane maker). Declared as m.
    GMapMarkerImage m = new GMapMarkerImage(new PointLatLng());
    GMapOverlay overlayOne;

    public Form2()
    {
        InitializeComponent();

        SuspendLayout();

        overlayOne = new GMapOverlay(MainMap, "OverlayOne");
        MainMap.MapProvider = GMapProviders.YahooMap;

        MainMap.SetCurrentPositionByKeywords("Singapore");
        MainMap.MinZoom = 1;
        MainMap.MaxZoom = 24;
        MainMap.Zoom = 13;
        MainMap.CanDragMap = true;
        MainMap.DragButton = MouseButtons.Left;
        MainMap.Dock = DockStyle.Fill;
        MainMap.Manager.Mode = AccessMode.ServerAndCache;

        Controls.Add(MainMap);
        ResumeLayout(true);


    }

    public void button1_Click(object sender, EventArgs e)
    {
        if (!serialPort1.IsOpen)    //if serial port is not open
            try
            {
                serialPort1.Open(); //Open Serial Port
                if (lat != 0 && lng != 0)  //Display marker only when GPS has receive data
                {
                    overlayOne.Markers.Add(m);          //Add marker on the position given to the overlayOne layer
                    MainMap.Overlays.Add(overlayOne);   //Add overlayOne layer to the MainMap layer
                }
            }
            catch
            {
                //A message box will display this message, informing user either a wrong port has been chosen, or have not been plugged in.
                MessageBox.Show("There was an error. Please make sure that the correct port was selected, and the device, plugged in.");
            }

    }

    public void button2_Click(object sender, EventArgs e)
    {
        if (serialPort1.IsOpen)                // if Serial Port is open
        {
            serialPort1.Close();               //Close Serial
            overlayOne.Markers.Remove(m);
        }
    }

    //When microsoft visual studio receive data
    public void serialPort1_DataReceived(object sender, System.IO.Ports.SerialDataReceivedEventArgs e)
    {
        this.Invoke(new EventHandler(DoUpdate));    //for function DoUpdate

        //Pause Microsoft Visual Studio for 100 milliseconds from receiving data, 
        //to ensure serialPort can be close successfully
        Thread.Sleep(100);
    }

    //Function for updating data. Declared as DoUpdate.
    public void DoUpdate(object sender, EventArgs e)
    {
        string[] c = serialPort1.ReadLine().Split(',');  //Stored data seperately by using array & using the Split() function

        lat = Convert.ToDouble(c[9]);               //Convert Latitude string data to double data
        lng = Convert.ToDouble(c[10]);              //Convert Longitude string data to double data

        //Input lat and lng data in m.
        //Updating the position of the marker
        m.Position = new PointLatLng(lat, lng);

    }
}

表格3:

    public partial class Form3 : Form
    {
        public Form3()
        {
            InitializeComponent();

        }

        private void pictureBox1_Click(object sender, EventArgs e)
        {
            if (!serialPort1.IsOpen)    //if serial port is not open
                try
                {
                    serialPort1.Open(); //Open Serial Port

                    //Enable blocks to have colour
                    // ...
                }
                catch
                {
                    //A message box will display this message, informing user either a wrong port has been chosen, or have not been plugged in.
                    MessageBox.Show("There was an error. Please make sure that the correct port was selected, and the device, plugged in.");
                }

        }

        private void button2_Click(object sender, EventArgs e)
        {
            if (serialPort1.IsOpen)                // if serial port is open
            {
                serialPort1.Close();                   // Close serial Port 

                //Clear data in textboxes
                FrontSonar.Text = "    ";
                LeftSonar.Text = "   ";
                RightSonar.Text = "    ";

                //Clear colours in the boxes
                // ...
            }
        }

        private void serialPort1_DataReceived(object sender, System.IO.Ports.SerialDataReceivedEventArgs e) //When microsoft visual studio receive data
        {
            this.Invoke(new EventHandler(DoUpdate1)); //To update and ensure sonar data infront of UAV can be displayed without error
            this.Invoke(new EventHandler(DoUpdate2)); //To update and ensure sonar data left side of UAV can be displayed without error
            this.Invoke(new EventHandler(DoUpdate3)); //To update and ensure sonar data on the right side of UAV can be displayed without error

            Thread.Sleep(100);
        }

        private void DoUpdate1(object s, EventArgs e) //Display for Sonar infront of UAV
        {
            string[] c = serialPort1.ReadLine().Split(',');  //Stored data seperately by using array & using the Split() function
            FrontSonar.Text = c[1] + "\n";
            double d = Convert.ToDouble(c[1]);

            if (d > 500)
            {
                //Fill blocks with green
                this.rectangleShape1.FillColor = System.Drawing.Color.Green;
                this.rectangleShape2.FillColor = System.Drawing.Color.Green;
                this.rectangleShape3.FillColor = System.Drawing.Color.Green;
            }
            else
                if (d > 400 && d <= 500)
                {
                    //Fill block with Orange colour
                    this.rectangleShape1.FillColor = System.Drawing.Color.Orange;
                    this.rectangleShape2.FillColor = System.Drawing.Color.Orange;

                    //Fill block with Lavender colour
                    this.rectangleShape3.FillColor = System.Drawing.Color.Lavender;
                }
                else
                    if (d <= 400)
                    {
                        //Fill block with red colour
                        this.rectangleShape1.FillColor = System.Drawing.Color.Red;

                        //Fill block with Lavender colour
                        this.rectangleShape2.FillColor = System.Drawing.Color.Lavender;
                        this.rectangleShape3.FillColor = System.Drawing.Color.Lavender;
                    }

        }


        private void DoUpdate2(object s, EventArgs e) //Display for Sonar on the left side of UAV
        {
            string[] c = serialPort1.ReadLine().Split(',');  //Stored data seperately by using array & using the Split() function
            // ....

        }

        private void DoUpdate3(object s, EventArgs e) //Display for Sonar on the right side of UAV
        {
            string[] c = serialPort1.ReadLine().Split(',');  //Stored data seperately by using array & using the Split() function
            // ...
        }    
    }

Form4:(仍在进行中)

public partial class Form4 : Form
{
    public Form4()
    {
        InitializeComponent();
    }
}
4

1 回答 1

1

是的你可以。以下是实现这一目标的关键点:

  1. 打开串口一次,您的方法if (!port.IsOpened) { port.Open(); }是正确的,将其提取为静态方法并以每种形式(f2,f3,f4)调用以避免复制/粘贴此代码段。

  2. serialPort变量应该在所有三种表单中共享,因此所有表单都可以访问相同的打开和初始化端口实例。考虑到您提供的代码,创建和初始化,在Form1类中打开端口,然后通过构造函数注入将 serialPort 的初始化实例传递给其他表单类,基本上SerialPort port为类添加构造函数参数Form2,3,4,然后:

    // renamed button1_Click
    private void OnSetup(object sender, EventArgs e)
    {
        this.port = new SerialPort(...);
        // TODO: initialize port
    
        Form2 f2 = new Form2(this.port);
        f2.Show();
        Form3 f3 = new Form3(this.port);
        f3.Show();
        Form4 f4 = new Form4(this.port);
        f4.Show();
    }
    
  3. 然后在每个表单构造函数中只订阅serialPort.DataReceived事件就可以了。

    public Form2(SerialPort port)
    {
         port.DataReceived += ...
    }
    

一些建议,

  • 为变量和方法提供更具描述性的名称,而不是form1, form2, c, d,button2_Click
  • 避免使用幻数,提取变量中的常量并给出描述性名称,例如400,500幻数多次出现,不清楚它们是什么。
  • 在对您说的代码的注释中Pause Microsoft Visual Studio...microsoft visual studio receives data...这是不正确的,您的应用程序(但不是 Visual Studio)的执行将暂停,而Thread.Sleep()您的应用程序将接收传入的串行端口数据,Visual Studio 只是一个开发环境,在这种情况下不直接参与端口通信。
于 2012-09-27T08:37:32.873 回答