18

我正在寻找一种确定数字是否在指定范围内的流畅方法。我当前的代码如下所示:

int x = 500; // Could be any number

if ( ( x > 4199 && x < 6800 ) ||
     ( x > 6999 && x < 8200 ) ||
     ( x > 9999 && x < 10100 ) ||
     ( x > 10999 && x < 11100 ) ||
     ( x > 11999 && x < 12100 ) )
{
    // More awesome code
}

有没有更好的方法来做到这一点?

4

7 回答 7

36

扩展方法?

bool Between(this int value, int left, int right)
{ 
   return value > left && value < right; 
}

if(x.Between(4199, 6800) || x.Between(6999, 8200) || ...)

你也可以做这个可怕的黑客:

bool Between(this int value, params int[] values)
{
    // Should be even number of items
    Debug.Assert(values.Length % 2 == 0); 

    for(int i = 0; i < values.Length; i += 2)
        if(!value.Between(values[i], values[i + 1])
            return false;

    return true;
}

if(x.Between(4199, 6800, 6999, 8200, ...)

可怕的黑客,改进:

class Range
{
    int Left { get; set; }
    int Right { get; set; }

    // Constructors, etc.
}

Range R(int left, int right)
{
    return new Range(left, right)
}

bool Between(this int value, params Range[] ranges)
{
    for(int i = 0; i < ranges.Length; ++i)
        if(value > ranges[i].Left && value < ranges[i].Right)
            return true;

    return false;
}

if(x.Between(R(4199, 6800), R(6999, 8200), ...))

或者,更好的是(这不允许重复的下限):

bool Between(this int value, Dictionary<int, int> ranges)
{
    // Basically iterate over Key-Value pairs and check if value falls within that range
}

if(x.Between({ { 4199, 6800 }, { 6999, 8200 }, ... }
于 2009-07-16T13:21:15.917 回答
14

定义 Range 类型,然后创建一组范围和扩展方法以查看值是否位于任何范围内。然后,您可以创建一个范围集合,也许还有一些单独的范围,而不是硬编码这些值,给它们提供有用的名称来解释对它们感兴趣的原因:

static readonly Range InvalidUser = new Range(100, 200);
static readonly Range MilkTooHot = new Range (300, 400);

static readonly IEnumerable<Range> Errors =
    new List<Range> { InvalidUser, MilkTooHot };

...

// Normal LINQ (where Range defines a Contains method)
if (Errors.Any(range => range.Contains(statusCode))
// or (extension method on int)
if (statusCode.InAny(Errors))
// or (extension methods on IEnumerable<Range>)
if (Errors.Any(statusCode))

您可能对作为MiscUtilRange一部分的泛型类型感兴趣。它还允许以简单的方式进行迭代:

foreach (DateTime date in 19.June(1976).To(25.December(2005)).Step(1.Days()))
{
    // etc
}

(显然这也使用了一些与 DateTime/TimeSpan 相关的扩展方法,但你明白了。)

于 2009-07-16T13:21:36.900 回答
8

我个人更喜欢@Anton 建议的扩展方法 - 但如果你不能这样做,并且要坚持使用你当前的代码,我认为你可以通过反转每行的第一组条件来使其更具可读性,如下所示...

int x = 500; // Could be any number
if ( ( 4199 < x && x < 6800 ) ||
     ( 6999 < x && x < 8200 ) ||
     ( 9999 < x && x < 10100 ) ||
     ( 10999 < x && x < 11100 ) ||
     ( 11999 < x && x < 12100 ) )
{
    // More awesome code
}
于 2009-07-16T13:28:52.337 回答
3

LINQ 方法:

添加参考:

using System.Linq;

        /// <summary>
        /// Test to see if value is in specified range.
        /// </summary>
        /// <param name="aStart">int</param>
        /// <param name="aEnd">int</param>
        /// <param name="aValueToTest">int</param>
        /// <returns>bool</returns>
        public static bool CheckValueInRange(int aStart, int aEnd, int aValueToTest)
        {
            // check value in range...
            bool ValueInRange = Enumerable.Range(aStart, aEnd).Contains(aValueToTest);
            // return value...
            return ValueInRange;
        }
于 2009-07-16T14:23:55.457 回答
1
class Range { 

    public Range(int x, int y) {
        X = x;
        Y = y;
    }

    public int X { get; set; }
    public int Y { get; set; }
}

var ranges = new List<Range>();
ranges.Add(new Range(4199,6800));
ranges.Add(new Range(6999,8200));
ranges.Add(new Range(9999,10100));
ranges.Add(new Range(10999,11100));
ranges.Add(new Range(11999,12100));

bool inRange = ranges.Count(r => x >= r.X && x <= r.Y) > 0;
//or -- Based on Jons recommendation
bool inRange = ranges.Any(r => x >= r.X && x <= r.Y);
于 2009-07-16T13:27:09.217 回答
0

如果您需要在某个时候迭代值对,我建议您在变量中捕获最大下限值和最小上限值,然后执行以下操作:

if ( x>max_lower && x <min_upper)
{
    // More awesome code

}
于 2009-07-16T13:23:09.317 回答
0

尝试类似:

struct Range
{
   public readonly int LowerBound;
   public readonly int UpperBound; 

   public Range( int lower, int upper )
   { LowerBound = lower; UpperBound = upper; }

   public bool IsBetween( int value )
   { return value >= LowerBound && value <= UpperBound; }
}

public void YourMethod( int someValue )
{
   List<Range> ranges = {new Range(4199,6800),new Range(6999,8200),
                         new Range(9999,10100),new Range(10999,11100),
                         new Range(11999,12100)};

   if( ranges.Any( x => x.IsBetween( someValue ) )
   {
      // your awesome code...
   }
}
于 2009-07-16T13:25:09.297 回答