2

我有一个sideH运行风险的函数Prelude.head []。因此，我使用 Maybe 编写了它，以避免这种情况：

sideH :: Residue -> Maybe (Atom, Atom)
sideH res
    -- Make sure the elements exist
    | nits /= [] && cars /= [] && oxys /= [] = Just (newH1, newH2)
    | otherwise = Nothing where
    ...

以上工作完全符合预期，没有错误。现在，在调用的函数sideH（不是 do 构造）中，我必须处理sideH返回的情况Nothing：

callerFunc :: [Residue] -> Aromatic -> [(Double, Double)]
callerFunc [] _ = []
callerFunc (r:rs) aro
    -- Evaluate only if there is something to evaluate
    | newHs /= Nothing = (newH1Pos, newH2Pos)
    | otherwise = callerFunc rs aro where
    newHs = sideH r
    newH1Pos = atomPos $ fst $ fromJust newHs
    newH2Pos = atomPos $ snd $ fromJust newHs

如果我尝试评估newH1Posor newH2Poswhen newH = Nothing，它将失败，因为fromJust Nothing是一个错误。但是，我希望这永远不会发生。我希望callerFunc评估newHs，要么是Just something要么Nothing。如果是Nothing，那么callerFunc将进入下一步，而无需评估newH1Posor newH2Pos。情况似乎并非如此。*** Exception: Maybe.fromJust: Nothing我在我期望newHs返回的地方得到一个错误Nothing。

我被要求提供更多代码。我试图提出一个重现错误的最小情况，但与此同时，这里是完整的有问题的callerFunc代码。 

-- Given a list of residues and an aromatic, find instances where there
--  is a Hydrogen bond between the aromatic and the Hydrogens on Gln or Asn
callerFunc :: [Residue] -> Aromatic -> [(Double, Double)]
callerFunc [] _ = []
callerFunc (r:rs) aro
    -- GLN or ASN case
    | fst delR <= 7.0 && (resName r == gln || resName r == asn) &&
        newHs /= Nothing && snd delR <= 6.0 = 
        [(snd delR, fst delR)] ++ hBondSFinder rs aro
    | otherwise = hBondSFinder rs aro where
    -- Sidechain identifying strings
    gln = B.pack [71, 76, 78]
    asn = B.pack [65, 83, 78]
    -- Get the location of the Hydrogens on the residue's sidechain
    newHs = sideH r
    newH1Pos = atomPos $ fst $ fromJust newHs
    newH2Pos = atomPos $ snd $ fromJust newHs
    -- Get the location of the Nitrogen on the mainchain of the Residue
    ats = resAtoms r
    backboneNPos = atomPos $ head $ getAtomName ats "N"
    hNVect1 = Line2P {lp1 = newH1Pos, lp2 = backboneNPos}
    hNVect2 = Line2P {lp1 = newH2Pos, lp2 = backboneNPos}
    interPoint1 = linePlaneInter (aroPlane aro) hNVect1
    interPoint2 = linePlaneInter (aroPlane aro) hNVect2
    delR = minimum [(interPoint1 `dist` newH1Pos, delr1), 
        (interPoint2 `dist` newH2Pos, delr2)]
    delr1 = interPoint1 `dist` (aroCenter aro)
    delr2 = interPoint2 `dist` (aroCenter aro)

我知道这是一个痛苦的代码转储。我正在尝试减少它。

4

1 回答 1

3

这个问题的答案（在评论中询问）不适合评论：“我不确定我将如何在这里使用模式匹配来删除这些 if 语句。”。

例如，像这样，尽管仍然存在一些代码异味，可以通过一些额外的重构来改善：

sideH :: Residue -> Maybe (Atom, Atom)
sideH res = case (nits, cars, oxys) of
    (_:_, _:_, _:_) -> Just (newH1, newH2)
    _ -> Nothing
    where
    ...

如果你有灵活的道德，你可以尝试这样的事情：

sideH :: Residue -> Maybe (Atom, Atom)
sideH res = do
    _:_ <- return nits
    _:_ <- return cars
    _:_ <- return oxys
    return (newH1, newH2)
    where
    ...

同样，如果有更多的上下文和代码可用于提出建议，这两个代码示例都可能会改进十倍左右。

于 2012-02-24T05:26:39.063 回答