2

我创建了一个简短的函数来设置和检索对象的值(> 按名称获取点),但我不确定我的解决方案是否真的那么聪明。

您建议进行哪些修改来完善此查询?

var points = {}; //global var

function getPoints() {

    var args = arguments, name;

    // set points or return them!

    if (typeof args[0] == 'object') {

        name = args[0].name;
        points = { name: args[0].points };

    } else {

        name = args[0];
        return points.name;
    }
}

  //set:
  getPoints(name: "John", points: 0)    //set points (0)
  getPoints(name: "Pamela", points: 2 ) //set points (2)

  //return:
  getPoints("John")    //returns > (0)
  getPoints("Pamela")  //returns > (2)
4

3 回答 3

1

我会为 getter 和 setter 创建一个不同的函数。一个名为 getPoints 的函数也设置点没有任何意义,并且会混淆 ppl :)

于 2011-07-14T07:44:22.533 回答
1

[编辑]以前的答案是错误的:没有提到不可能getPoints("John")

据我所知,您正试图将 get 和 set 组合在一个函数中。

您可能想在Points constructor function这里使用 a ,例如:

var Points = function(name,points){
   this.name = name || '';
   this.points = points || 0;
   if (!Points.prototype.get){
      var proto = Points.prototype;
      proto.get = function(label) {
         return this[label] || label
      };
      proto.set = function(){
        if (arguments.length === 2){
           this[arguments[0]] = arguments[1];
        } else if (/obj/i.test(typeof arguments[0])){
           var obj = arguments[0];
           for (var l in obj){
              if (obj.hasOwnProperty(l)){
               this[l] = obj[l];
              }
           }
        }
        return this;
      };
   }
}

var john = new Points('John',0), mary = new Points('Mary',2), pete = new Points;
pete.set({name:'Pete',points:12});
john.set('points',15);
//two ways to get a 'points' property
alert(john.get('points')+', '+pete.points); //=> 15, 12
于 2011-07-14T07:46:47.820 回答
1

我看到的唯一问题是points每次调用getpointsie 的值都会被覆盖:

getPoints({name :"John", points: 0}); // points = {"John": 0}
getPoints({name:"Mein", points:1}); // points = {"Mein":1}

名字也很混乱。我的版本是:

var points = {};
function getOrSetPoints(){
    if(typeof arguments[0] === "object"){
        points[arguments[0].name] = arguments[0].points;
    }
    else
        return points[arguments[0]] || arguments[0] + ' not set'
}
于 2011-07-14T08:01:33.070 回答