1

我正在研究 Rails 教程第 10 章中的练习，但在练习中遇到了一个问题，该练习让我确保管理员用户不能删除自己。我最初的想法是简单地检查当前用户的 id 并将其与 params[:id] 进行比较，以确保它们不相等。我的用户控制器中的销毁操作如下所示：

def destroy
  if current_user.id == params[:id].to_i
    flash[:notice] = "You cannot delete yourself."
  else
    User.find(params[:id]).destroy
    flash[:success] = "User destroyed."
  end
  redirect_to users_path
end

当我在应用程序中手动测试它时，这非常有效，但我的 3 个 RSpec 测试失败并出现相同的“未定义方法 'to_i'”错误（如下所示）：

1) UsersController DELETE 'destroy' as an admin user should destory the user
   Failure/Error: delete :destroy, :id => @user
     NoMethodError:
       undefined method `to_i' for #<User:0x000001032de188>
   # ./app/controllers/users_controller.rb:48:in `destroy'
   # ./spec/controllers/users_controller_spec.rb:310:in `block (5 levels) in <top (required)>'
   # ./spec/controllers/users_controller_spec.rb:309:in `block (4 levels) in <top (required)>'

2) UsersController DELETE 'destroy' as an admin user should redirect to the users page
   Failure/Error: delete :destroy, :id => @user
     NoMethodError:
       undefined method `to_i' for #<User:0x000001032b5850>
   # ./app/controllers/users_controller.rb:48:in `destroy'
   # ./spec/controllers/users_controller_spec.rb:315:in `block (4 levels) in <top (required)>'

3) UsersController DELETE 'destroy' as an admin user should not allow you to destroy self
   Failure/Error: delete :destroy, :id => @admin
     NoMethodError:
       undefined method `to_i' for #<User:0x0000010327e350>
   # ./app/controllers/users_controller.rb:48:in `destroy'
   # ./spec/controllers/users_controller_spec.rb:321:in `block (5 levels) in <top (required)>'
   # ./spec/controllers/users_controller_spec.rb:320:in `block (4 levels) in <top (required)>'

如果我使用 params[:id] 来查找用户并将其与下面的 current_user 进行比较，那么它在应用程序和 RSpec 中都可以使用。

def destroy
  if current_user == User.find(params[:id])
    flash[:notice] = "You cannot delete yourself."
  else
    User.find(params[:id]).destroy
    flash[:success] = "User destroyed."
  end
  redirect_to users_path
end

为什么 RSpec 中的“to_i”方法会出现问题？如果有人想知道我倾向于这种方法，因为我认为最好将当前用户 id 与要删除的用户的 id 进行简单比较（通过 params[:id]），而不是点击 db 来“查找”用户。

作为参考，这是我的 RSpec 测试：

  describe "DELETE 'destroy'" do
    before(:each) do
        @user = Factory(:user)
    end 

    ...

    describe "as an admin user" do
      before(:each) do
        @admin = Factory(:user, :email => "admin@example.com", :admin => true)
        test_sign_in(@admin)
      end

      it "should destory the user" do
        lambda do
          delete :destroy, :id => @user
        end.should change(User, :count).by(-1)
      end

      it "should redirect to the users page" do
        delete :destroy, :id => @user
        response.should redirect_to(users_path)
      end

      it "should not allow you to destroy self" do
        lambda do
          delete :destroy, :id => @admin
        end.should change(User, :count).by(0)
        response.should redirect_to(users_path)
        flash[:notice].should =~ /cannot delete yourself/
      end
    end
  end

任何帮助，将不胜感激！

4

1 回答 1

1

在您的规范中，尝试在您的参数上使用@user.id而不是使用（我意识到教程说只使用，但在没有正确提取 id 的地方可能会发生一些事情）：@user:id@user

delete :destroy, :id => @user.id

但是你可以考虑重组为这样的东西：

@user = User.find(params[:id])
if current_user == @user
  flash[:notice] = "You cannot delete yourself."
else
  @user.destroy
  flash[:success] = "User destroyed."
end
于 2011-06-29T19:57:37.170 回答