0

我正在尝试使用以下代码将一些对话消息推送到数组：

myConversations: IConversation[] = [];
myConversationMessage: IConversationMessages = {
conversationId: 0,
messageId: 0,
messageText: ''
};
myConversationMessages: IConversationMessages[] = [];

this.conversationService.getConversations().subscribe(conversations => {
  this.myConversations = conversations;

  for (let i of this.myConversations) {
    this.myConversationMessage.conversationId = i.conversationId;       
    for (let j of i.messages) {
      this.myConversationMessage.messageId = j.messageId;
      this.myConversationMessage.messageText = j.messageText; 
      this.myConversationMessages.push(this.myConversationMessage);
    }
  }

  console.log(this.myConversationMessages);
});

我正在从 JSON 对象中检索对话和其中的消息。不是将每条消息推送到myConversationMessages数组，而是在控制台中输出以下内容：

0 
conversationId: 2
messageId:2
messageText: "testing"

1
conversationId: 2
messageId:2
messageText: "testing"

2
conversationId: 2
messageId:2
messageText: "testing"

3
conversationId: 2
messageId:2
messageText: "testing"

所以最终的“对话”对象是覆盖每个数组元素。

有人可以告诉我为什么我的代码会这样做吗？非常感谢提前

PS如果可以解决我的问题，我可以上传更多代码。

4

2 回答 2

0

发生这种情况是因为您将引用对象添加到数组。在您的示例中，您没有将 3 个对象添加到数组中，而是将一个对象的三个引用添加了 3 次。其中一个属性的变化会导致所有其他属性的变化。

它应该是有效的：

for (let i of this.myConversations) {
    this.myConversationMessage.conversationId = i.conversationId;       
    for (let j of i.messages) {
      let item = new IConversationMessages();
      item.messageId = j.messageId;
      item.messageText = j.messageText; 
      this.myConversationMessages.push(item);
    }
  }
于 2019-03-19T19:58:49.290 回答
0

这是因为 JavaScript 对象是通过引用传递的：

myConversationMessages: IConversationMessages[] = [];

this.conversationService.getConversations().subscribe(conversations => {
  this.myConversations = conversations;

  for (let i of this.myConversations) {
    this.myConversationMessage.conversationId = i.conversationId;       
    for (let j of i.messages) {
      this.myConversationMessage.messageId = j.messageId;
      this.myConversationMessage.messageText = j.messageText; 
      this.myConversationMessages.push(this.myConversationMessage); // <-= Here you are pushing a reference to the same object in every loop. In every loop you are updating the single object, and the reference in each array spot points to the same object
    }
  }

  console.log(this.myConversationMessages);
});

尝试这个：

  for (let i of this.myConversations) {
    for (let j of i.messages) {
      this.myConversationMessages.push({
          conversationId: i.conversationId,
          messageId: j.messageId,
          messageText: j.messageText
      });
    }
  }

这将为每次迭代创建一个新对象

于 2019-03-19T20:01:18.267 回答