7

我正在尝试使用SetFileInformationByHandle. Niall Douglas 在他的 CppCon2015 演讲“Racing The File System”中提出了这种技术，作为一种以原子方式移动/重命名文件的方法。但是，我正在努力提供正确的论点；它总是失败并GetLastError返回ERROR_INVALID_PARAMETER。

我已经尝试了以下设置，使用 Unicode 字符集：

  • VS2015U1，在Windows 10下运行exe
  • VS2015U2，在Windows Server 2012下运行exe
  • VS2013，在Windows 7下运行exe

但是行为是一样的。我确保可以访问测试文件夹和测试文件。

#include <sdkddkver.h>
#include <windows.h>

#include <cstring>
#include <iostream>
#include <memory>

int main()
{
    auto const& filepath = L"C:\\remove_tests\\file.txt";
    auto const& destpath = L"C:\\remove_tests\\other.txt";
    // unclear if that's the "root directory"
    auto const& rootdir = L"C:\\remove_tests";

    // handles will be leaked but that should be irrelevant here
    auto const f_handle = CreateFile(filepath,
        GENERIC_READ | GENERIC_WRITE | DELETE,
        0,
        NULL,
        CREATE_ALWAYS,
        FILE_ATTRIBUTE_NORMAL,
        NULL);

    if (f_handle == INVALID_HANDLE_VALUE)
    {
        auto const err = GetLastError();
        std::cerr << "failed to create test file: " << err;
        return err;
    }

    auto const parent_dir_handle = CreateFile(rootdir,
        GENERIC_READ | GENERIC_WRITE,
        FILE_SHARE_READ | FILE_SHARE_WRITE,
        NULL,
        OPEN_EXISTING,
        FILE_ATTRIBUTE_NORMAL | FILE_FLAG_BACKUP_SEMANTICS,
        NULL);

    if (parent_dir_handle == INVALID_HANDLE_VALUE)
    {
        auto const err = GetLastError();
        std::cerr << "failed to get handle to parent directory: " << err;
        return err;
    }

    auto const destpath_bytes_with_null = sizeof(destpath);
    // unclear if we need to subtract the one wchar_t of FileNameLength:
    auto const struct_size = sizeof(FILE_RENAME_INFO) + destpath_bytes_with_null;
    auto const buf = std::make_unique<char[]>(struct_size);

    auto const fri = reinterpret_cast<FILE_RENAME_INFO*>(buf.get());
    fri->ReplaceIfExists =  TRUE; // as described by Niall Douglas
    fri->RootDirectory = parent_dir_handle;
    // with or without null terminator?
    fri->FileNameLength = destpath_bytes_with_null;
    std::memcpy(fri->FileName, destpath, destpath_bytes_with_null);

    BOOL res = SetFileInformationByHandle(f_handle, FileRenameInfo,
                                          fri, struct_size);
    if (!res)
    {
        auto const err = GetLastError();
        std::cerr << "failed to rename file: " << err;
        return err;
    }
    else
        std::cout << "success";
}

特别是，我的问题是：

  • 什么是所需的“根目录” FILE_RENAME_INFO？
  • 句柄需要哪些权限？
  • 生产者的根本问题是ERROR_INVALID_PARAMETER什么SetFileInformationByHandle？
4

2 回答 2

5

SetFileInformationByHandlewithFileRenameInfo和的文档FILE_RENAME_INFO包含一些错误。 FILE_RENAME_INFO.FileNameLength必须设置为复制到FILE_RENAME_INFO.FileName不包括终止零的字符数，并且FILE_RENAME_INFO.RootDirectory必须为空，即使将文件从一个目录移动到另一个目录也是如此。

#include <sdkddkver.h>
#include <windows.h>

#include <cstring>
#include <iostream>
#include <memory>

int _tmain( int argc, _TCHAR* argv [] )
{
    wchar_t* filename = L"C:\\remove_tests\\file.txt";
    wchar_t* destFilename = L"C:\\remove_tests2\\other.txt";

    // handles will be leaked but that should be irrelevant here
    auto fileHandle = CreateFile( filename,
                                  GENERIC_READ | GENERIC_WRITE | DELETE,
                                FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE,
                                      NULL,
                                      OPEN_EXISTING,
                                      FILE_ATTRIBUTE_NORMAL,
                                      NULL );

    if ( fileHandle == INVALID_HANDLE_VALUE )
    {
        auto const err = GetLastError( );
        std::cerr << "failed to create test file: " << err;
        return err;
    }

    auto destFilenameLength = wcslen( destFilename );

    auto bufferSize = sizeof( FILE_RENAME_INFO ) + ( destFilenameLength*sizeof( wchar_t ));
    auto buffer = _alloca( bufferSize );
    memset( buffer, 0, bufferSize );

    auto const fri = reinterpret_cast<FILE_RENAME_INFO*>( buffer );
    fri->ReplaceIfExists = TRUE;

    fri->FileNameLength = destFilenameLength;
    wmemcpy( fri->FileName, destFilename, destFilenameLength );

    BOOL res = SetFileInformationByHandle( fileHandle, FileRenameInfo, fri, bufferSize );
    if ( !res )
    {
        auto const err = GetLastError( );
        std::cerr << "failed to rename file: " << err;
        return err;
    }
    else
        std::cout << "success";
}
于 2016-04-09T00:29:23.670 回答
4

我改变了几个想法：

1）我不使用根句柄（我将它设置为NULL）

2）我改变你的 FILE_RENAME_INFO 内存分配代码

注意：在 Windows 8 中检查，在同一卷（磁盘）中移动文件

auto const& filepath = L"C:\\remove_tests\\file.txt";
auto const& destpath = L"C:\\remove_tests\\other.txt";
// unclear if that's the "root directory"
auto const& rootdir = L"C:\\remove_tests";

// handles will be leaked but that should be irrelevant here
auto const f_handle = CreateFile(filepath,
    GENERIC_READ | GENERIC_WRITE | DELETE,
      0,
    NULL,
    CREATE_ALWAYS,
    FILE_ATTRIBUTE_NORMAL,
    NULL);

if (f_handle == INVALID_HANDLE_VALUE)
{
    auto const err = GetLastError();
    std::cerr << "failed to create test file: " << err;
    return err;
}

/*auto const parent_dir_handle = CreateFile(rootdir,
    GENERIC_READ | GENERIC_WRITE | DELETE,
      FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE,
    NULL,
    OPEN_EXISTING,
    FILE_ATTRIBUTE_NORMAL | FILE_FLAG_BACKUP_SEMANTICS,
    NULL);

if (parent_dir_handle == INVALID_HANDLE_VALUE)
{
    auto const err = GetLastError();
    std::cerr << "failed to get handle to parent directory: " << err;
    return err;
}*/

 auto const destpath_bytes_withOUT_null = _tcslen(destpath);
// unclear if we need to subtract the one wchar_t of FileNameLength:
auto const struct_size = sizeof(FILE_RENAME_INFO) + (destpath_bytes_withOUT_null + 1) * sizeof(WCHAR);
FILE_RENAME_INFO* fri = (FILE_RENAME_INFO*)new BYTE[struct_size];

fri->ReplaceIfExists =  TRUE; // as described by Niall Douglas
fri->RootDirectory = NULL;//parent_dir_handle;
// with or without null terminator?
fri->FileNameLength = destpath_bytes_withOUT_null;// No include null
 _tcscpy_s(fri->FileName, destpath_bytes_withOUT_null + 1, destpath);

BOOL res = SetFileInformationByHandle(f_handle, FileRenameInfo,
                                      fri, struct_size);

 delete fri;
if (!res)
{
    auto const err = GetLastError();
    std::cerr << "failed to rename file: " << err;
    return err;
}
else
    std::cout << "success";
于 2016-04-08T18:46:04.980 回答