1

对于这个程序,我有一个用户使用该private static void add()方法将元素输入到一个 5 空间数组中。添加这些元素后,用户可以使用该private static void delete()方法允许他们输入他们希望删除的数组中存在的数字。输入要删除的数字时,程序运行良好,除非我尝试删除currentSize数组的最后一个数字。例如,如果我有一个包含以下索引和值的数组:

0. = 1
1. = 2
2. = 3
3. = 4
4. = <empty>

数组的currentSize当前值为 4。如果我尝试删除索引 3 中的值 4,程序将不会删除值 4。如果我在尝试删除值 4 后尝试删除值 3、2 或 1,这些值将不会删除任何一个。另一方面,如果我想首先删除值 4 以下的任何值,即值 1、2 和 3,则程序可以正常工作,直到我尝试删除索引 0 中的值 4。如果我尝试删除值 4此时,没有任何内容被删除。如果我尝试添加一个值,比如 1,在尝试删除值 4 之后,值 4 将替换为值 1。如果我尝试在索引 0 处删除值 4 两次,然后尝试添加一个新值,我会得到一个IndexOutOfBoundsException: -1. 我相信这与currentSize--递减有关,因为它不应该出现在private static void delete()方法。如果有人对此有解决方案,将不胜感激,谢谢。该程序发布在下面。我已经评论了private static void delete()给我问题的方法部分。这是我得到的堆栈跟踪:

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: -1
    at ArrayManager.add(ArrayManager.java:35)
    at ArrayManager.main(ArrayManager.java:216)

/**
 * A class that contains methods to carry out the Add, Update, Delete, Drop, Resize, and End commands to alter the state of an array with 5 integers.
 */
public class ArrayManager
{
    // Array of 5 integers to be modified
    private static int [] values = new int [5];

    private static int currentSize = 0;
    private static int position = 0;
    //private static int index = 0;

    static Scanner in = new Scanner(System.in);

    /**
     * A method that inserts an entered value into the array as long as it is between 1 and 99. If the array is full, an error message will be printed explaining that the array is full.
     */
    private static void add()
    {
        System.out.println("Enter values between 1 and 99, inclusive that you would like to add to the array.");
        if(in.hasNextInt())
        {
            int n = in.nextInt();
            if(n >= 1 && n <= 99)
            {
                if(currentSize < values.length)
                {
                    values[currentSize] = n;
                    currentSize++;
                }
                else
                {
                    System.out.println("ERROR: The array is currently full.");
                }
            }
            else
            {
                System.out.println("ERROR: The number entered must be between 1 and 99, inclusive.");
            }
        }
        else
        {
            System.out.println("ERROR: String has been entered. Enter an Integer.");
        }
    }

/**
     * A method that asks the user to enter a value they wish to delete in the array. The following values are then shifted down in index in the array. If the value chosen does not exist in the array, an error message is displayed explaining that the value entered does not exist in the array.
     */
    private static void delete()
    {
        int n = 0;
        System.out.println("Please enter the value in the array that you wish to remove.");
        if(in.hasNextInt())
        {
            n = in.nextInt();
            for(position = 0; position < values.length; position++)
            {
                if(values[position] == n)
                {
                 // The stack trace points me back to this section of code which removes the specified value in the values array.
                    for(int i = position + 1; i < currentSize; i++)
                    {
                            values[i - 1] = values[i];
                            values[i] = 0;
                    }
                    currentSize--;
                    break;
                }
                else if(position == values.length - 1)
                {
                    System.out.println("ERROR: The value entered does not exist in the array.");
                }
            }
        }
        else
        {
            System.out.println("ERROR: String has been entered. Enter an Integer.");
        }
    }

/**
     * A method that prints out the modified array.
     */
    public static void printArray()
    {
        System.out.println("* Current Array Contents *");
        for(int i = 0; i < values.length; i++)
        {
            if(values[i] != 0)
            {
                System.out.println(i + ". = " + values[i]);
            }
            else if(values[i] == 0)
            {
                System.out.println(i + ". = <empty>");
            }
        }
    }
4

1 回答 1

1

位置是值数组的最后一个元素的索引的极端情况未正确处理。在这种情况下,代码开始从下一个索引迭代元素,以便将所有元素移动 1 个位置,并且 for 循环中的条件不满足条件。

for(int i = position + 1; i < currentSize; i++)

    for(int i = position + 1; i < currentSize; i++)
    {
        values[i - 1] = values[i];
        values[i] = 0;
    }

解决方案是检查该条件并明确处理它。

   if(values[position] == n ) {
       if( position != values.length - 1 ) {
           for(int i = position + 1; i < currentSize; i++)
           {
               values[i - 1] = values[i];
               values[i] = 0;
           }
       } else {
           values[i] = 0;
       }
       currentSize--;
       break;
   } 
于 2015-10-03T13:15:38.917 回答