0

I have a WPF application with two viewmodels(AViewModel,BViewModel). I think that main problem is that Singleton.Instance.Handle.Add("...",(m)=>{...}); cannot be removed from Model because it have High Coupling. And every time when i want to update collection i need to past Singleton.Instance.Handle.Add("...",(m)=>{...}); How to update collection without pasting every time Singleton.Instance.Handle.Add("...",(m)=>{...});

public class AViewModel
{
    AModel A = new AModel();
}

and BViewModel:

public class BViewModel
{
    BModel B = new BModel();
}

AModel:

public class AModel
{
    public ObservableCollection<DataType> AItems { get; set; }
    public AModel()
    {
        AItems = new ObservableCollection<DataType>();
        UpdateAModel();
    }
    public void UpdateAModel()
    {
        // Problem with High Coupling, can not remove into another class
        Singleton.Instance.Handle.Add("MessageB", (m) =>
        {
            Dictionary<string, DataType> d = m.Message.Json.GetFirstArgAs<Dictionary<string, DataType>>();
            foreach (KeyValuePair<string, DataType> item in d)
            {
                // Update AItems
            }
            // Many strings of code
            // Update AItems, problem with add or remove items in ObservableCollection because AItems on UI Thread
        });
    }
}

BModel:

public class BModel
{
    public ObservableCollection<DataType> BItems { get; set; }
    public BModel()
    {
        BItems = new ObservableCollection<DataType>();
        UpdateBModel();
    }
    public void UpdateBModel()
    {
        // Problem with High Coupling, can not remove into another class
        Singleton.Instance.Handle.Add("MessageA", (m) =>
        {
            Dictionary<string, DataType> d = m.Message.Json.GetFirstArgAs<Dictionary<string, DataType>>();
            foreach (KeyValuePair<string,DataType> item in d)
            {
                // Update BItems
            }
            // Many strings of code
            // Update BItems, problem with add or remove items in ObservableCollection because AItems on UI Thread
        });
    }
}

Both models contain ObservableList, which updates with data from web.

public class Singleton
{
    private static Singleton instance;

    public Dictionary<string, Action<MessageEventArgs>> Handle { get; set; }
    private Singleton() 
    {
        Handle = new Dictionary<string, Action<MessageEventArgs>>();
        socket = new Client(UrlSocketServer);
        socket.Message += Message;
    }

    public static Singleton Instance
    {
        get
        {
            if (instance == null)
            {
                instance = new Singleton();
            }
            return instance;
        }
    }
    private void Message(object sender, MessageEventArgs e)
    {
            if (Handle.ContainsKey(e.Message.Event))
            {
                Handle[e.Message.Event](e);
            }
    }
}
4

1 回答 1

0

如果您提供独立编译的代码，您将获得对此类问题的更好回答。

要回答您的问题，您可以通过添加一个函数来提高可读性：

public void Filter(string key, Action<MessageEventArgs> filter)
{
    Singleton.Instance.Handle.Add(key filter);
}

其次，您不必使用 lambda，您可以使用常规方法：

private void MessageB(MessageEventArgs m)
{
    Dictionary<string, DataType> d = m.Message.Json.GetFirstArgAs<Dictionary<string, DataType>>();
    foreach (KeyValuePair<string, DataType> item in d)
    {
        // Update AItems
    }
}

那么你需要做的就是：

Filter("MessageB", MessageB);
于 2015-08-31T22:41:15.980 回答