我创建了一个函数,它返回一个包含每个月的数组,从提供的碳日期开始,到当前日期结束。
尽管该功能正在做它应该做的事情,但它看起来很可怕。显然我的编程技能还没有达到应有的水平。当然必须有更好的方法来实现我想要的。
我的代码如下所示:
class DateUtilities {
protected $months = ['january', 'february', 'march', 'april', 'may', 'june', 'july', 'august', 'september', 'october', 'november', 'december'];
public function getMonthListFromDate(Carbon $date)
{
$monthArray = array();
$today = Carbon::today();
$currentYear = $today->copy()->format('Y');
$currentMonth = strtolower($today->copy()->format('F'));
$startYear = $date->copy()->format('Y');
$startMonth = strtolower($date->copy()->format('F'));
for($i = $startYear; $i <= $currentYear; $i ++) {
foreach($this->months as $monthIndex => $month) {
if (($monthIndex >= array_search($startMonth, $this->months) && $i == $startYear) ||
($monthIndex <= array_search($currentMonth, $this->months) && $i == $currentYear) ||
($i != $startYear && $i != $currentYear)) {
$formattedMonthIndex = ($monthIndex + 1);
if($formattedMonthIndex < 10) {
$monthArray['0' . $formattedMonthIndex . '-' . $i] = $month . ' ' . $i;
} else {
$monthArray[$formattedMonthIndex . '-' . $i] = $month . ' ' . $i;
}
}
}
}
return $monthArray;
}
}
结果是:
array:25 [▼
"03-2013" => "march 2013"
"04-2013" => "april 2013"
"05-2013" => "may 2013"
"06-2013" => "june 2013"
"07-2013" => "july 2013"
"08-2013" => "august 2013"
"09-2013" => "september 2013"
"10-2013" => "october 2013"
"11-2013" => "november 2013"
"12-2013" => "december 2013"
"01-2014" => "january 2014"
"02-2014" => "february 2014"
"03-2014" => "march 2014"
"04-2014" => "april 2014"
"05-2014" => "may 2014"
"06-2014" => "june 2014"
"07-2014" => "july 2014"
"08-2014" => "august 2014"
"09-2014" => "september 2014"
"10-2014" => "october 2014"
"11-2014" => "november 2014"
"12-2014" => "december 2014"
"01-2015" => "january 2015"
"02-2015" => "february 2015"
"03-2015" => "march 2015"
]
谁能帮我改进这段代码?
编辑:
在伟大的提示之后,我得到了以下结果:
class DateUtilities {
public function getMonthListFromDate(Carbon $start)
{
$start = $start->startOfMonth();
$end = Carbon::today()->startOfMonth();
do
{
$months[$start->format('m-Y')] = $start->format('F Y');
} while ($start->addMonth() <= $end);
return $months;
}
}
谢谢你们的帮助!!