0

我在这里有一个小 bash 脚本，我正在尝试修复，但我不断收到一个语法错误，指出“文件意外结束”。它询问我是否要阻止或取消阻止并询问哪种类型的端口，然后出错。

任何帮助将不胜感激。

#!/bin/bash

PTYPET="What kind of port? [udp] or [tcp] or [both] :"
PTEXTT="What port? [number] :"

echo "Would you like to block or unblock? [b] or [u] :"
read choice

if [ $(choice) == "u" ]; then
    echo $PTYPET
    read port-type
    echo $PTEXTT
    read port
    if [ $(ptype-text) == "both" ]; then
        /sbin/iptables -A INPUT -p $port-type -m tcp --dport $port -j ACCEPT
        /sbin/iptables -A INPUT -p $port-type -m udp --dport $port -j ACCEPT
    else
    /sbin/iptables -A INPUT -p $port-type -m $port-type --dport $port -j ACCEPT
fi

else 
    echo $PTYPET
    read port-type
    echo $PTEXTT
    read port
    if [ $(ptype-text) == "both" ]; then
        /sbin/iptables -A INPUT -p $port-type -m tcp --dport $port -j DROP
        /sbin/iptables -A INPUT -p $port-type -m udp --dport $port -j DROP
    else
    /sbin/iptables -A INPUT -p $port-type -m $port-type --dport $port -j DROP
fi
4

2 回答 2

1

以不同的方式去做。

#!/bin/bash

echo "Would you like to block or unblock? [ACCEPT] or [DROP] :"
    read choice
echo "What kind of port? [udp] or [tcp] or [both] :"
    read porttype
echo "What port? [number] :"
    read port

    if [[ $porttype == "both" ]]; then
        /sbin/iptables -A INPUT -p tcp -m tcp --dport $port -j $choice
        /sbin/iptables -A INPUT -p udp -m udp --dport $port -j $choice
    else
    /sbin/iptables -A INPUT -p $porttype -m $porttype --dport $port -j $choice
fi
于 2014-12-19T06:27:54.587 回答
1

如果您的缩进系统化，您会发现问题：

if [ $(choice) == "u" ]; then
    echo $PTYPET
    read port-type
    echo $PTEXTT
    read port
    if [ $(ptype-text) == "both" ]; then
        /sbin/iptables -A INPUT -p $port-type -m tcp --dport $port -j ACCEPT
        /sbin/iptables -A INPUT -p $port-type -m udp --dport $port -j ACCEPT
    else  # Indent next two lines
        /sbin/iptables -A INPUT -p $port-type -m $port-type --dport $port -j ACCEPT
    fi
else 
    echo $PTYPET
    read port-type
    echo $PTEXTT
    read port
    if [ $(ptype-text) == "both" ]; then
        /sbin/iptables -A INPUT -p $port-type -m tcp --dport $port -j DROP
        /sbin/iptables -A INPUT -p $port-type -m udp --dport $port -j DROP
    else  # Indent the next two lines
        /sbin/iptables -A INPUT -p $port-type -m $port-type --dport $port -j DROP
    fi
# And now it is clear that this fi was missing!
fi

经典地，port-type不是一个有效的变量名；下划线就可以了。using$(ptype-text)是运行命令ptype-text并捕获输出，这有点令人惊讶；与$(choice). 对于变量引用，您使用大括号：${choice}. 您在代码中有一些相当明显的重复。两对“echo/read”应该在if/else结构之外。

于 2014-12-19T08:12:34.163 回答