0

我目前正在制作一个程序，允许我在用户指定的目录中搜索文件。但是在浓缩我的try和except陈述时遇到了一些麻烦。我目前的代码如下：

if os.path.exists(file_path)!= True:
        print('\n******* Path does not exist. *******\n')       

    else:
        while True:
            aa = '''\nWhich search characteristics would you like to use? \n 1. Search by name: N \n 2. Search by extension: E \n 3. Search by size: S
                \n    Please enter your choice: '''

            answer = input(aa).strip()

            if answer not in 'NnEeSs' or answer=='':
                print('\n***** Invalid choice. *****')

            elif answer in 'Nn':
                while True:
                    try:
                        name = input ('\nEnter file name: ')
                        rr = search_by_name(name, file_path)
                        if not rr:
                            print('\n***** File not found *****\n')
                        else:
                            break

                    except WindowsError:
                        print('\n***** Oops! Access denied.*****\n')
                        continue


            elif answer in 'Ee':
                while True:
                    try:
                        ending = input ('\nEnter the file extension: ')
                        rr = search_by_extention(ending, file_path)
                        if not rr:
                            print('\n***** No File(s) found *****\n')
                        else:
                            break

                    except WindowsError:
                        print('\n***** Oops! Access denied. *****\n')
                        continue              

            elif answer in 'Ss':
                while True:
                    try:
                        size = int(input('\nPlease enter file size: '))
                        rr = search_by_size(size, file_path)
                        if not rr:
                            print('\n***** No file(s) found *****\n')
                        else:
                            break

                    except ValueError:
                        print('\n***** Enter an numeric value. *****\n')
                        continue

                    except WindowsError:
                        print('\n***** Oops! Access denied. *****\n')
                        continue

在每种情况下或总体上，是否有更好的简洁方式来编写上述代码？每个搜索函数都返回一个包含代码结果的列表。

4

1 回答 1

1

我有几个建议：

1. 改进缩进。

在文件的顶部，您有：

if os.path.exists(file_path)!= True:
    print('\n******* Path does not exist. *******\n')       

    else:

该else语句必须具有与原始 相同的缩进值if。

2.删除换行符

由于您担心占用空间，只需删除所有换行符。我不建议这样做，因为您的代码可能会让人难以阅读，但如果您对空间很执着，请继续。我可以数出 11个换行符，所以如果你删除这些，你已经删除了1 ⁄ 5的文件。

3. Pythonic

如果您关心您的代码占用的行数，请尝试对每一行尽可能地Pythonic，以供将来查看/编辑。而不是if x in 'Ss':检查是否x是sor S，只是做if x.lower() == 's':

4.格式try... except

您try... except的 's 包含您的大部分代码。尝试仅将它们限制在可能引发错误的行。这是一个例子：

try:
    var = int(raw_input())
    x = float(var)/100.0
    if x == 1:
        print 'YAY'
    else:
        print 'BOO!'
    for k in range(1, x):
        print 'this has looped %d times' %(k)
except ValueError:
    print 'Your input is not in a number format!'

在这段代码中，我们要确保输入是一个数字。但是，这只能通过第一行检查，其他一切都是垃圾。因此，只需围绕第一行，其余部分保持不变。

笔记：

不要从您try... except的 's 中删除必要的组件，否则可能会引发一些任意错误。

5.缩小你的while循环

而不是执行以下代码：

while True:
    try:
        size = int(input('\nPlease enter file size: '))
        rr = search_by_size(size, file_path)
        if not rr:
            print('\n***** No file(s) found *****\n')
        else:
            break

    except ValueError:
        print('\n***** Enter an numeric value. *****\n')
        continue

你可以做

size = input('\nPlease enter file size: ')
while size.isdigit() == False or not rr = search_by_size(size, file_path):
    size = input('\nPlease enter file size: ')

您编辑的代码：原始：59 行；编辑：33行：

if os.path.exists(file_path)!= True:
    print('\n******* Path does not exist. *******\n')
else:
    while True:
        aa = '''\nWhich search characteristics would you like to use? \n 1. Search by name: N \n 2. Search by extension: E \n 3. Search by size: S
            \n    Please enter your choice: '''
        answer = input(aa).strip()
        if answer not in 'NnEeSs' or answer=='':
            print('\n***** Invalid choice. *****')
        elif answer.lower() == 'n':
            name = input ('\nEnter file name: ')
            try:
                while not search_by_name(name, file_path):
                    name = input ('\nEnter file name: ')
            except WindowsError:
                print('\n***** Oops! Access denied.*****\n')
                continue
        elif answer .lower() == 'e':
            ending = input ('\nEnter the file extension: ')
            try:
                while not search_by_extention(ending, file_path):
                    ending = input ('\nEnter the file extension: ')
            except WindowsError:
                print('\n***** Oops! Access denied. *****\n')
                continue
        elif answer.lower() == 's':
            size = input('\nPlease enter file size: ')
            try:
                while size.isdigit() == False or not search_by_size(size, file_path):
                    size = input('\nPlease enter file size: ')
            except WindowsError:
                print('\n***** Oops! Access denied. *****\n')
                continue
于 2014-04-17T02:49:22.317 回答