0

我正在做一个涉及链接列表的家庭作业,但我在使用 Pop() 函数时遇到了问题。这是我的代码:

void CardStack::Pop( )
{
    if ( m_top->m_next == NULL )
    {
        delete m_top;
        m_top = NULL;
    }

    else
    {
        Node* ptrNode = m_top;

        // gets 2nd to last node
        while ( ptrNode->m_next != m_top )
        {
            ptrNode = ptrNode->m_next;
        }
        // delete last node, then set second to last to null
        delete m_top;
        m_top = NULL;

        ptrNode->m_next = NULL;
        m_top = ptrNode;
    }
    m_size--;
}

当我运行程序时,我不断收到这个运行时错误,在 if 语句处中断:

分配 7 中 0x008e2009 处的未处理异常 - CS201.exe:0xC0000005:访问冲突读取位置 0x00000004。

我的一个朋友建议m_top = NULL从程序中删除,这使得 if 语句起作用。我宁愿保持空值不变,但它让程序运行起来。无论如何,它会在 while 循环中中断并出现以下错误:

作业 7 中 0x00b91f4a 处的未处理异常 - CS201.exe:0xC0000005:访问冲突读取位置 0xfeeefeee。

我用 cout 语句对其进行了测试,错误来自 while 循环体;ptrNode = ptrNode->m_next. 我不确定如何解决这个问题。任何建议将不胜感激。

此外,如果有帮助,这是我的程序的大部分其余部分:

标题:

class Node
{
public:
    friend class CardStack;

private:
    Node* m_next;
    int m_data;
};

class CardStack
{
public:
    CardStack();
    ~CardStack();

    void Push( int value );
    void Pop();
    int Top();
    int GetSize();

private:
    int m_size;
    Node* m_top;
};

构造函数、析构函数、Push():

#include <iostream>
#include "CardStack.h"
using namespace std;

CardStack::CardStack( )
{
    m_top = NULL;
    m_size = 0;
}

CardStack::~CardStack( )
{
    while ( m_top != NULL )
    {
        Pop( );
    }
}

void CardStack::Push( int value )
{
    //creates new node
    Node* newNode = new Node;
    newNode->m_data = value;
    newNode->m_next = NULL;

    // tests if the list is empty
    if ( m_top == NULL )
    {
        m_top = newNode;
    }
    // if the list does contain data members and a last node exists
    else
    {
        m_top->m_next = newNode;
        m_top = newNode;
    }
    m_size++;
}

主要的:

#include <iostream>
#include <string>
#include <fstream>
#include "CardStack.h"
using namespace std;

void loadDeck ( ifstream&, CardStack& );
void playGame ( CardStack& );

void loadDeck ( ifstream& inFile, CardStack *card )
{
    int currentCard;

    while( !inFile.eof() )
    {
        inFile >> currentCard;
        card->Push( currentCard );
    }
}

void playGame( CardStack *card )
{
    int score[ 4 ];
    int player;
    while( card->GetSize() != 0 )
    {
        player = card->GetSize() % 4;
        score[ player ] += card->Top();
        card->Pop();
    }

    for ( player = 0; player < 4; player++ )
        cout << "Player " << player << "'s score is " << score[ player ] << endl;
}

int main()
{
    CardStack *card = new CardStack;
    string fileName;
    ifstream inFile;

    do
    {
        cout << "Input the name of the card file (not including extension): ";
        cin >> fileName;

        fileName += ".txt";

        inFile.open( fileName );

        if ( !inFile.is_open() )
            cout << "File could not be opened. Reenter the file name." << endl;
    }
    while( !inFile.is_open() );

    loadDeck( inFile, card );
    playGame( card );

    inFile.close();

    system( "pause" );
    return 0;
}
4

2 回答 2

0

这是一个循环链表吗?如果不是,你为什么要在循环中测试:

while ( ptrNode->m_next != m_top )

不是:

while ( ptrNode->m_next != NULL )

如果是,你为什么要设置:

ptrNode->m_next = NULL;

而不是“原始” m_top->next??

于 2013-12-04T05:46:13.787 回答
0

你只需要确保循环中的第一次

while ( ptrNode->m_next != m_top )
    {
        ptrNode = ptrNode->m_next;
    }

ptrNode 不会为 NULL,因为你已经在 if 块中检查了它,但是当第二次循环时,ptrNode 可能为 NULL,`因为现在它实际上是

m_top->m_next->m_next

但是如何确保 m_top->m_next 不为 NULL,当它为 NULL 时,它会崩溃

也许你应该把它改成

while ( ptrNode->m_next != NULL )
{
    ptrNode = ptrNode->m_next;
}

另外,还有一个问题,在你的推送功能中

else
{
    m_top->m_next = newNode;
    m_top = newNode;
}

应该

else
{
    newNode->m_next = m_top;
    m_top = newNode;
}
于 2013-12-04T05:52:19.583 回答