0

好了朋友们。这里是新手。刚刚创建了这个东西，用户从“家庭列表”中选择一种食物，然后单击“>>”按钮将其添加到左侧的“购物清单”列表中，反之亦然。它运行良好，尽管当用户在选择按钮后单击按钮时它开始变得有点狡猾。它再次打印出整个列表，并且它也显示为一个数组。我只想将选定的值添加到 JList 中。继承人的代码：

import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;

import javax.swing.*;
import java.util.*;

import javax.swing.JTextField;

public class MAIN extends JFrame {

    Button ltor, rtol;
    JList homelist, shoppinglist;
    DefaultListModel homefoodlist = new DefaultListModel();
    DefaultListModel shoppingfoodlist = new DefaultListModel();
    JTextField foodlog;

    String[] hfood = {"Tuna", "Mayo", "Ketchup", "Sun Flower Oil", "Buscuits", "Cookies", "Turkey"};
    String[] sfood = {"Chocolate", "bread", "Milk", "Toast", "Beef", "Chicken"}; 

    public static void main(String[] args) {

        new MAIN();

    }

    private MAIN(){
        JPanel thepanel = new JPanel();
        thehandler handler = new thehandler();

        this.setLocationRelativeTo(null);
        this.setSize(400, 400);
        this.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        this.setVisible(true);
        this.setTitle("Shopping List");
        this.add(thepanel);

        //Creating the Home List(left list)
        for(String homefood: hfood){
            homefoodlist.addElement(homefood);
        }

        homelist = new JList(homefoodlist);
        homelist.setSelectionMode(ListSelectionModel.MULTIPLE_INTERVAL_SELECTION);
        thepanel.add(homelist);

        //Buttons for moving lists from left to right
        ltor = new Button(">>");
        thepanel.add(ltor);
        ltor.addActionListener(handler);

        rtol = new Button("<<");
        rtol.addActionListener(handler);
        thepanel.add(rtol);

        //Creating the Shopping list(right list)
        for(String shoppingfood: sfood){
            shoppingfoodlist.addElement(shoppingfood);
        }
        shoppinglist = new JList(shoppingfoodlist);
        shoppinglist.setSelectionMode(ListSelectionModel.MULTIPLE_INTERVAL_SELECTION);
        thepanel.add(shoppinglist);

    }

        //ActionListener

        private class thehandler implements ActionListener{
            public void actionPerformed(ActionEvent e){
                //The HomeList to the ShoppingList
                if(e.getSource() == ltor){
                    if(homelist.isSelectionEmpty() == false){
                    shoppingfoodlist.addElement(homefoodlist);
                    homefoodlist.remove(homelist.getSelectedIndex());
                    }else{
                        JOptionPane.showMessageDialog(null, "Select a food from either list");
                    }


                }
                if(e.getSource() == rtol){
                    if(shoppinglist.isSelectionEmpty() == false){
                        homefoodlist.addElement(shoppingfoodlist);
                        shoppingfoodlist.remove(shoppinglist.getSelectedIndex());
                        }else{
                            JOptionPane.showMessageDialog(null, "Select a food from either list");
                        }
                }
            }
        }

}
4

2 回答 2

0

正如iberbeu指出的那样，我认为您只想将选定的项目从一侧移动到另一侧，并且由于您允许多项选择，您应该迭代并添加所有选定的项目：

//ActionListener
private class TheHandler implements ActionListener{
    public void actionPerformed(ActionEvent e){
        //The HomeList to the ShoppingList
        if(e.getSource() == ltor){
            if(homelist.isSelectionEmpty()){
                JOptionPane.showMessageDialog(null, "Select a food from either list");
            }else{
                for(int i : homelist.getSelectedIndices()){
                    shoppingFoodList.addElement(homeFoodList.get(i));
                    homeFoodList.remove(i);
                }
            }


        }
        if(e.getSource() == rtol){
            if(shoppingList.isSelectionEmpty()){
                JOptionPane.showMessageDialog(null, "Select a food from either list");
            }else{
                for(int i: shoppingList.getSelectedIndices()){
                    homeFoodList.addElement(shoppingFoodList.get(i));
                    shoppingFoodList.remove(i);
                }
            }
        }
    }
}

在此期间，如果可以的话，我想给您一些建议：

  • 根据 java 的命名约定，类应该是驼峰式大小写的：Main、TheHandler 等，变量小驼峰式大小写：shoppingFoodList、homeFoodList 等。您可以在此处阅读更多信息
  • 这是有争议的，因为每个人都有自己的做法。但是我相信要使代码更具可读性，您应该仅在绝对必要时否定条件（例如，如果您不需要 else 分支），否则只需将最简单的条件放入if并顺其自然并像我一样描述您的逻辑上面有消息对话框
  • 一旦你让代码工作，你就可以开始重构东西，比如if blocks和执行的操作的共同点和重复点，>>但<<我想现在这可能是太多的信息

祝你从新手升级到专业

于 2013-10-22T20:36:04.243 回答
0

您需要在 ActionListener 中替换以下代码：

shoppingfoodlist.addElement(homefoodlist);
homefoodlist.remove(homelist.getSelectedIndex());

进入：

List selectedValues = homelist.getSelectedValuesList();
for (Object object : selectedValues) {
    shoppingfoodlist.add(0,object);
    homefoodlist.remove(homelist.getSelectedIndex());
}

还有第二部分：

homefoodlist.addElement(shoppingfoodlist);
shoppingfoodlist.remove(shoppinglist.getSelectedIndex());

进入：

List selectedValues = shoppinglist.getSelectedValuesList();
for (Object object : selectedValues) {
    homefoodlist.add(0,object);
    shoppingfoodlist.remove(shoppinglist.getSelectedIndex());
}

如您所见，您必须在两个地方进行更改。我建议使用以下方法重构您的侦听器代码以摆脱条件逻辑和重复：

class CustomActionListener implements ActionListener{
    JList source;
    JList sink;
    CustomActionListener(JList source, JList sink){
        this.source = source;
        this.sink = sink;
    }
    @Override
    public void actionPerformed(ActionEvent e) {
        // TODO Auto-generated method stub
        if( !source.isSelectionEmpty() ){
            List selectedValues = source.getSelectedValuesList();
            for (Object object : selectedValues) {
                DefaultListModel sinkModel =  (DefaultListModel) this.sink.getModel();
                sinkModel.add(0, object);
                DefaultListModel sourceModel = (DefaultListModel) this.source.getModel();
                sourceModel.remove(source.getSelectedIndex());
            }       
        }
    }

}

然后你可以按如下方式使用它：

ltor.addActionListener(new CustomActionListener(homelist,shoppinglist));
rtol.addActionListener(new CustomActionListener(shoppinglist,homelist));

代码更简洁，您不必在 ActionListener 中维护两个位置（一个 if(ltor) 和第二个 if(rtol) ）。

于 2013-10-22T20:38:01.397 回答