13

我是第一次使用 Moq,我正在努力让测试正常运行。

我正在尝试最小Save()化我的服务层的方法。

public void Save(UserViewModel viewModel)
{
    // todo: this still doesn't address updating a password. The UserViewModel doesn't contain any Password data.
    if (viewModel.Id != Guid.Empty)
    {
        // The UserId is not empty, we're either updating an existing user
        // or we're inserting a new user via sync
        var user = _userRepository.GetById(viewModel.Id);
        if (user != null)
        {
            // Looks like we're updating a user because they're already in the database.
            _userRepository.Update(_userViewModelToModelMapper.BuildFrom(viewModel));
            return;
        }
    }

    // The user is being created, either via a Sync (Guid Exists), or via an Insert (Guid doesn't Exist)
    _userRepository.Create(_userViewModelToModelMapper.BuildFrom(viewModel));
}

我有三个测试,其中,我不确定其中任何一个是正确的。前两个通过,但第三个失败

Moq.MockVerificationException:以下设置不匹配:
IUserRepository r => r.Update(It.Is(um => um.Equals()))

这是测试。

// PASSES but could be suspect
[Test]
public void ShouldSaveANewUserFromExistingId()
{
    // emulating a "sync"

    // Setup
    var userId = new Guid("81C7FE19-2DB5-4083-BD6A-5433687561F7");
    var userModel = new UserModel();
    var userViewModel = new UserViewModel {Id = userId};
    var userRepository = new Mock<IUserRepository>();
    var viewModelToModelMapper = new Mock<IAutoMapper<UserViewModel, UserModel>>();
    var modelToViewModelMapper = new Mock<IAutoMapper<UserModel, UserViewModel>>();

    // Setup the Mock UserRepository
    userRepository.Setup(r => r.Create(It.Is<UserModel>(um => um.Equals(userModel))));

    viewModelToModelMapper.Setup(vmm => vmm.BuildFrom(It.Is<UserViewModel>(u => u.Equals(userViewModel))))
           .Returns(userModel);

    var userService = new UserService(userRepository.Object, viewModelToModelMapper.Object, modelToViewModelMapper.Object);

    // Execute
    userService.Save(userViewModel);

    // Assert
    userRepository.VerifyAll();
    viewModelToModelMapper.VerifyAll();
}
// PASSES but could be suspect.
[Test]
public void ShouldSaveANewUser()
{
    // emulating a standard create

    // Setup
    var userId = Guid.Empty;
    var userModel = new UserModel();
    var userViewModel = new UserViewModel { Id = userId };
    var userRepository = new Mock<IUserRepository>();
    var viewModelToModelMapper = new Mock<IAutoMapper<UserViewModel, UserModel>>();
    var modelToViewModelMapper = new Mock<IAutoMapper<UserModel, UserViewModel>>();

    // Setup the Mock UserRepository
    userRepository.Setup(r => r.Create(It.Is<UserModel>(um => um.Equals(userModel))));

    viewModelToModelMapper.Setup(vmm => vmm.BuildFrom(It.Is<UserViewModel>(u => u.Equals(userViewModel))))
           .Returns(userModel);

    var userService = new UserService(userRepository.Object, viewModelToModelMapper.Object, modelToViewModelMapper.Object);

    // Execute
    userService.Save(userViewModel);

    // Assert
    userRepository.VerifyAll();
    viewModelToModelMapper.VerifyAll();

}
// FAILS MISERABLY
[Test]
public void ShouldSaveAnExistingUser()
{
    // emulating an "Update"

    // Setup
    var userId = new Guid("0A88AEC2-9F8D-44DE-BD01-3EB9A23C78E3");
    var userModel = new UserModel { Id = userId };
    var userViewModel = new UserViewModel { Id = userId };
    var userRepository = new Mock<IUserRepository>();
    var viewModelToModelMapper = new Mock<IAutoMapper<UserViewModel, UserModel>>();
    var modelToViewModelMapper = new Mock<IAutoMapper<UserModel, UserViewModel>>();

    // Setup the Mock UserRepository
    userRepository.Setup(r => r.Update(It.Is<UserModel>(um => um.Equals(userModel))));

    viewModelToModelMapper.Setup(vmm => vmm.BuildFrom(It.Is<UserViewModel>(u => u.Equals(userViewModel))))
           .Returns(userModel);

    var userService = new UserService(userRepository.Object, viewModelToModelMapper.Object, modelToViewModelMapper.Object);

    // Execute
    userService.Save(userViewModel);

    // Assert
    userRepository.VerifyAll();
    viewModelToModelMapper.VerifyAll();
}

我的墨青哪里出了问题?

4

1 回答 1

15

似乎在最后一种情况下您需要:

userRepository.Setup(r => r.GetById(userId)).Returns(userModel);

在 userService.Save 调用之前。没有它 userRepository.GetById 将始终为空,并且永远不会采用更新分支。

于 2013-09-30T22:08:11.223 回答