1

以下存储过程pr_generate_sales_order在数据库 DB1 的 2 个表 SO Header 和 SO Detail 中生成记录。然后它将 SO Header & Detail 记录从 DB1 导出到 DB2。

每当我尝试从 ASP.Net/C# 调用此 SP 时,它都会生成以下错误消息: 名为“c_customers”的游​​标不存在,并且不会在数据库中创建记录。

但是,如果我在 SSMS 中直接执行这个存储过程pr_generate_sales_order,那么它可以正常工作并在 DB1 和 DB2 中生成记录。

问题出在哪里?是否与 Begin Try Catch ... 相关?

USE [DB1]
GO
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
-- ------------------------------------------------------------------------------------
-- Name: pr_generate_sales_order
-- ------------------------------------------------------------------------------------
-- Parameters: 
--    - N/A
--
-- Description: 
--    Generate Sales Order in DB1 & DB2
-- ------------------------------------------------------------------------------------
alter procedure [dbo].[pr_generate_sales_order] () as

Begin

-- --------------------------------------------------------------------------------
-- Variable declaration
-- --------------------------------------------------------------------------------
Declare @v_error_number             nvarchar(10)
Declare @v_error_message_en         nvarchar(1000)

Declare @v_customer_id              int
Declare @v_time_log_id              int
Declare @v_hourly_rate              numeric(18, 5)
Declare @v_total_time               numeric(18, 5)
Declare @v_description              nvarchar(max)

Declare @tmp_time_log Table
(
    time_log_id                     int,
    customer_id                     int,
    sku_id                          int,
    hourly_rate                     numeric(18, 5),
    hours                           int,
    minutes                         int
)


-- --------------------------------------------------------------------------------
-- Main program
-- --------------------------------------------------------------------------------
Set @v_error_number = '0'
Set @v_error_message_en = ''


Begin Try

    Begin Transaction T1


    -- ------------------------------------------------------------------------
    -- 
    -- ------------------------------------------------------------------------
    Insert Into @tmp_time_log
    Select      tl.time_log_id                          as time_log_id
                , tl.customer_id                        as customer_id
                , tl.sku_id                             as sku_id       -- 24/09/2013
                , tl.hourly_rate                        as hourly_rate
                , tl.hours_rounded                      as hours_rounded
                , tl.minutes_rounded                    as minutes_rounded

    From        time_log tl

    Where       tl.transaction_date between '2013-01-06' and getdate() 



    -- ------------------------------------------------------------------------
    -- Open Cursor
    -- ------------------------------------------------------------------------

    -- ------------------------------------------------------------------------
    -- Declare Customer Cursor: Get the list of Customer
    -- ------------------------------------------------------------------------
    Declare c_customers cursor for 
    Select      distinct IsNull(customer_id, 0)
    From        @tmp_time_log

    Open c_customers

    Fetch Next From c_customers Into @v_customer_id

    While @@fetch_status = 0
    Begin

        -- ----------------------------------------------------------------
        -- Create Sales Order Header for each Customer
        -- ----------------------------------------------------------------
        Insert Into sales_order_header ...

        -- Get Sales Order Header Id
        Set @v_sales_order_header_id = scope_identity()


        -- ----------------------------------------------------------------
        -- Declare Time Log Cursor: Get the list of Time Log by customer in order to Create 
        -- ----------------------------------------------------------------
        Declare c_time_log cursor for 
        Select      time_log_id                     as time_log_id
                    , hourly_rate                   as hourly_rate
                    , cast( (cast(tl.hours as numeric(18, 5)) + (cast(tl.minutes as numeric(18, 5)) / 60) ) as numeric(18, 5))       
                                                    as total_time
                    , sku_id                        as sku_id
        From        @tmp_time_log tl
        Where       customer_id = @v_customer_id

        -- ----------------------------------------------------------------
        -- Open Cursor
        -- ----------------------------------------------------------------
        Open c_time_log

        Fetch Next From c_time_log 
        Into @v_time_log_id, @v_hourly_rate, @v_total_time, @v_sku_id

        While @@fetch_status = 0
        Begin

            -- Create Sales Order Detail for Each SO Header
            Insert Into sales_order_detail ....


            -- Get the next Cursor
            Fetch Next From c_time_log Into @v_time_log_id, @v_hourly_rate, @v_total_time, @v_sku_id
        End


        -- Close & Deallocate Cursor
        Close c_time_log
        Deallocate c_time_log


        -- Get the next Cursor
        Fetch Next From c_customers  Into @v_customer_id
    End

    -- Close & Deallocate Cursor
    Close c_customers
    Deallocate c_customers


    -- ------------------------------------------------------------------------
    -- Export Sales Order Header & Detail From DB1 to DB2
    -- ------------------------------------------------------------------------
    Exec [DB2].[dbo].[pr_import_sales_order_from_db1]


    --  
    Commit Transaction T1

End Try

Begin Catch
    -- If Error Found Then Rollback Transaction
    If @@TRANCOUNT > 0
    Begin
        -- Close & Deallocate Cursor
        Close c_customers
        Deallocate c_customers


        -- Rollback         
        Rollback Transaction T1
    End

    -- Get Error # & Error Message  
    Select  @v_error_number = ERROR_NUMBER()
            , @v_error_message_en = 'An error occurred in ' + ERROR_PROCEDURE() + ': ' + ERROR_MESSAGE()

    GOTO Step_END

End Catch

-- ------------------------------------------------------------------------------------------
-- Return: Error # & Error message
-- ------------------------------------------------------------------------------------------
STEP_END:
    Select  @v_error_number                 as error_number  
            , @v_error_message_en           as error_message_en

End
GO
4

1 回答 1

2

如果您在

exec [DB2].[dbo].[pr_import_sales_order_from_db1]**  //are those asterisks there in your code

然后您已经关闭并释放了 c_customers,但是您将在 catch 块中第二次调用这些关闭和释放调用,我认为这是问题所在。

最后评论后编辑

保罗,

您应该重组 Try 块的最后 4 行,如下所示。

原来的

Close c_customers
Deallocate c_customers

Exec [DB2].[dbo].[pr_import_sales_order_from_db1]

Commit Transaction T1

修改的

Exec [DB2].[dbo].[pr_import_sales_order_from_db1]

Close c_customers
Deallocate c_customers

Commit Transaction T1

这样做的原因是目前的情况,如果您CLOSE&DEALLOCATE 游标,然后在 DB2 SPROC 中发生错误,您将 在 catch 块中再次尝试CLOSE&游标。DEALLOCATE

在修改/重新排列的版本中,如果一切正常,您仍将关闭并在您的COMMIT TRAN.正如预期的那样。CLOSEDEALLOCATE

于 2013-09-26T14:53:47.453 回答