c - 在 Ubuntu 中打印目录时遇到段错误

Question

我已经在这段代码上工作了一段时间，但我无法找出问题所在。这个想法是打印出给定目录中的所有目录和子目录（硬编码用于测试目的）。但是，我不断遇到分段错误。

#include <stdio.h>
#include <dirent.h>
#include <stdbool.h>
#include <string.h>
#include <stdlib.h>

struct item
{
    char location[256];
    int level;
    int order;
    bool isExpanded;
    struct item *next;
};

struct item *headNode = NULL; 
struct item *currentNode = NULL;
struct item *loopNode = NULL;
static int currentLevel = 1;
static int currentOrder = 1;
bool finished = false;
char currentLocation[256];

void addNode(char location[256])
{
    struct item *ptr = (struct item*)malloc(sizeof(struct item));
    ptr->level = currentLevel;
    ptr->order = currentOrder;
    ptr->isExpanded = false;
    int x;
    for(x = 0; x < strlen(location); x++)
        ptr->location[x] = location[x];

    ptr->location[x] = '\0';
    ptr->next = NULL;

    currentNode->next = ptr;
    currentNode = ptr;
} 

int main(int argc, char *argv[])
{
    struct dirent *pDirent;
    DIR *pDir;
    argv[1] = "/home/collin/Documents";
    char temp[256];

    pDir = opendir (argv[1]);
    if (pDir == NULL) 
    {
        printf ("Cannot open directory '%s'\n", argv[1]);
        return 1;
    }
    closedir (pDir);

    headNode = (struct item*)malloc(sizeof(struct item));
    headNode->level = currentLevel;
    headNode->order = currentOrder;
    headNode->isExpanded = false;
    int x;
    for(x = 0; x < strlen(argv[1]); x++)
    {
        headNode->location[x] = argv[1][x];
        currentLocation[x] = argv[1][x];
    }

    headNode->location[x] = '\0';
    currentLocation[x] = '\0';
    headNode->next = NULL;

    currentNode = headNode;

    while(!finished)
    {
        finished = true;
        loopNode = headNode;
        currentLevel++;
        currentOrder = 1;
        while(loopNode != NULL)
        {
            if(!loopNode->isExpanded)
            {
                pDir = opendir (loopNode->location);
                for (x = 0; x < strlen(loopNode->location); x++)
                {
                    currentLocation[x] = loopNode->location[x];
                }
                currentLocation[x] = '\0';

                while ((pDirent = readdir(pDir)) != NULL) 
                {
                    finished = false;
                    if(!(!strcmp(pDirent->d_name, ".")||!strcmp(pDirent->d_name, "..")))
                    {
                        sprintf(temp, "%s/%s", currentLocation, pDirent->d_name);
                        addNode(temp);
                        currentOrder++;
                    }
                }
                closedir (pDir);
                loopNode->isExpanded = true;
            }
            loopNode = loopNode->next;
        }
    }

    currentNode = headNode;
    while (currentNode != NULL)
    {
        printf ("%d:%d:%s\n", currentNode->level, currentNode->order, currentNode->location);
        currentNode = currentNode->next;
    }

    return 0;
}

Answer 1

您没有检查 opendir 的参数是否是一个目录，也没有尝试在文件上调用它。要么检查 opendir 返回值，要么检查您请求打开的文件实际上是一个目录，或者 - 甚至更好 - 两者兼而有之。