4

我为使用 AngularJS 构建的移动 Web 应用程序构建了一个无限滚动,具有以下附加功能:

  1. 我将它构建为双向的
  2. 这是针对移动网络应用程序的,所以我希望它卸载视图外的内容以避免内存问题

这是jsfiddle链接。

现在,我有几个问题,我还需要一个小的代码审查:

  1. 我对 promises 不熟悉,但then()似乎之前执行过$digest。因此,我需要延迟我的代码$timeout。对我来说,这是出现问题的迹象。我想删除第$timeout85 行和第 98$timeout行。第 85 行有点“hacky”,我需要确保它在 ms 之后执行,then()否则它将不起作用,我不知道为什么。
  2. 我想知道$scope从指令中调用方法是否被认为是一种“良好做法”。在我的代码中,我$scope.init(value)从我的指令中调用。
  3. 包括 jQueryposition()是很有趣的。我应该使用具有功能的服务$.position()吗?

我知道这些可能是单独的问题,但它们确实与我的代码有关。

对于那些不想点击jsfiddle链接的人,这里是代码:

HTML:

<div id="fixed" scroll-watch="4" scroll-up="loadTop()" scroll-down="loadBottom()">
    <ul>
        <li data-id="{{i.id}}" ng-repeat="i in items" ng-class="calculateType(i.id)">{{i.id}}</li>
    </ul>
</div>

JS:

function Main($scope, $timeout, $q) {
    var cleanup = 5;

    $scope.items = [];

    //This is called from the scrollWatch directive. IMO, this shouldn't be a good idea
    $scope.init = function(value) {
        var deferred = $q.defer();

        //This $timeout is used to simulate an Ajax call so I will keep it there
        $timeout(function() {
            $scope.items = [{id: +value}];

            $scope.loadTop();
            $scope.loadBottom();

            deferred.resolve();
        }, 200);

        return deferred.promise;
    };

    //This is only used to simulate different content's heights
    $scope.calculateType = function(type) {
        return 'type-' + Math.abs(type) % 4;  
    };

    $scope.loadBottom = function() {
        var deferred = $q.defer(),
            counter;

        if ($scope.items.length > 1) {
            $scope.items.splice(0, cleanup);
        }

        //This $timeout is used to simulate an Ajax call so I will keep it there
        $timeout(function() {
            counter = (($scope.items[$scope.items.length - 1]) || {id: 0}).id;

            for (var i = 1; i < 6; i++) {
                $scope.items.push({id: counter + i});
            }

            deferred.resolve();
        }, 200);

        return deferred.promise;
    };

    $scope.loadTop = function() {
        var deferred = $q.defer(),
            counter;

        //Why can't I use this here?
        //$scope.items.splice($scope.items.length-cleanup, $scope.items.length);

        //This $timeout is used to simulate an Ajax call so I will keep it there
        $timeout(function() {
            counter = (($scope.items[0]) || {id: 0}).id;

            for (var i = 1; i < 6; i++) {
                $scope.items.unshift({id: counter - i});
            }

            deferred.resolve();
        }, 200);

        return deferred.promise;
    };

    //Why is this method needs to be delayed inside the directive? I would like to call it in loadTop()
    $scope.removeBottom = function() {
        $scope.items.splice($scope.items.length-cleanup, $scope.items.length);
    };
}

angular.module('scroll', []).directive('scrollWatch', ['$timeout', function($timeout) {
    var lastScrollTop = 0;

    return function($scope, elm, attr) {
        var raw = elm[0];

        $scope.init(attr.scrollWatch).then(function() {
            //Why do I need this? It looks like the resolve is called before the $digest cycle
            $timeout(function() {
                raw.scrollTop = $('li[data-id="' + attr.scrollWatch + '"]').position().top;
            }, 300); //This value needs to be great enough so it is executed after the $scope.loadTop()'s resolve, for now, I know that I can set it to 300 but in real life app?
        });

        elm.bind('scroll', function() {
            if (raw.scrollTop > lastScrollTop && raw.scrollTop + raw.offsetHeight >= raw.scrollHeight) {
                $scope.$apply(attr.scrollDown);
            } else if (raw.scrollTop < lastScrollTop && raw.scrollTop === 0) {
                var scrollHeight = raw.scrollHeight;

                $scope.$apply(attr.scrollUp).then(function() {
                    //Why do I need this? It looks like the resolve is called before the $digest cycle
                    $timeout(function() {
                        raw.scrollTop = raw.scrollHeight - scrollHeight;

                        //I would like to move this in the $scope.loadTop()
                        $scope.removeBottom();
                    });
                });
            }

            lastScrollTop = raw.scrollTop;
        });
    };
}]);

谢谢

4

1 回答 1

1

http://www.youtube.com/watch?v=o84ryzNp36Q 是关于 Promises 的精彩视频,介绍了如何编写它们以及它们如何工作。

https://github.com/stackfull/angular-virtual-scroll 是 ng-repeat 的指令替代品,它不会加载任何不在屏幕上的东西它可以从我可以准确地看出你在寻找什么来做。

我会将此作为评论,但您需要 50 信用或声誉或他们所说的任何东西。

于 2014-01-09T19:32:44.837 回答