1

以下代码从表中获取收件人电子邮件、电子邮件主题和电子邮件正文，并创建电子邮件并将它们发送到拾取目录。有一个数据库连接类，我没有在这里包含，但我在下面的代码中调用它。下面的代码运行良好，但我想知道是否可以改进它以更快地运行，考虑到它将用于发送 10000 多封电子邮件。

提前感谢您的帮助。

using System;
using System.Collections;
using System.Collections.Generic;
using System.Text;
using System.Net;
using System.Net.Mail;
using System.Data;
using System.Data.SqlClient;
using System.IO;

namespace SendEmails
{
class SendEmail
{
    private class EmailsList
    {
        private class listData
        {
            public string email;
            public string email_header;
            public string email_body;
            public string email_guid;
        }
        public void data()
        {
            SqlDataReader sqlData;
            ArrayList Emaillist = new ArrayList();
            sqlData = new SqlCommand("SELECT email, email_header, email_body, email_guid FROM dbo.vw_emails ", con.openconnection()).ExecuteReader();
            // loop through the emails table and load arraylist
            while (sqlData.Read())
            {
                listData itemData = new listData();
                itemData.email = sqlData[0].ToString();
                itemData.email_header = sqlData[1].ToString();
                itemData.email_body = sqlData[2].ToString();
                itemData.email_guid = sqlData[3].ToString();
                Emaillist.Add(itemData);                
            }               
            sqlData.Close();
            con.closeconnection

            foreach (listData itemData in Eamillist)
            {
                //SEND EMAIL *****************************/
                spSendMail(itemData.email, itemData.email_header, "me@yahoo.com", itemData.email_body, itemData.email_guid);
                //DO THE UPDATE *********************/
                SqlCommand cmd = new SqlCommand("up_emailLog", con.openconncetion());
                cmd.CommandType = CommandType.StoredProcedure;
                cmd.Parameters.AddWithValue("@email_GUID", itemData.email_guid);
                cmd.CommandTimeout = 0;
                cmd.ExecuteNonQuery();
                con.CloseConnection();

            }
        }
    }

    static void Main(string[] args)
    {
        try
        {
           EmailsList sEmails = new EmailsList();
            sEmails.data();                    
        }
        catch (Exception ex)
        {
            SqlCommand cmd = new SqlCommand("INSERT INTO [dbo.Err_Log](exception, insdt) VALUES('" + ex.Message.ToString() + "','" +  "','"+ DateTime.Now + "')", Con.OpenConnection());
            cmd.ExecuteNonQuery();
            con.CloseConnection();                 
        }
    }
    // Send Email Method
    public static void spSendMail(string recipients, string subject, string from, string body, string email_guid)
    {
        try
        {
            using (MailMessage mailMessage = new MailMessage(from, recipients))
            {
                    mailMessage.Subject = subject;
                    mailMessage.Body = body;
                    mailMessage.IsBodyHtml = true;
                    SmtpClient smtpClient = new SmtpClient("xxxxxx.xxxx.zo");
                    smtpClient.UseDefaultCredentials = true;
                    smtpClient.DeliveryMethod = SmtpDeliveryMethod.SpecifiedPickupDirectory;
                    smtpClient.PickupDirectoryLocation = "\\\\exchange_server\\pickup";
                    //Create eml file and send it to pickup directory
                    smtpClient.Send(mailMessage);                               
            }
        }
        catch (Exception ex)
        {
            SqlCommand cmd = new SqlCommand("INSERT INTO [dbo.Err_Log](exception, communication, insdt) VALUES('" + ex.Message.ToString() +"','" + recipients.ToString() + "','" + DateTime.Now + "')", con.OpenConnection());
            cmd.CommandTimeout = 0;
            cmd.ExecuteNonQuery();
            Con.CloseConnection();
        }
    }
}

}

4

1 回答 1

0

如果您可以使用 .NET 2.0 或更高版本，则可以使用该SmtpClient.SendAsync方法，该方法将创建一个新线程来发送电子邮件并释放主线程以进行更多处理。

阅读SmtpClient.SendAsync 方法以获取文档。

如果您使用的是 .NET 2.0 或更高版本，您还应该考虑使用泛型，它将为您的Emaillist对象提供类型安全，但不会提高性能，因为您没有得到与 . 相同的拆箱命中ArrayList，因为您没有使用值类型.

这是您的EmailList代码使用泛型时的样子List<T>：

List<listData> Emaillist = new List<listData>();

while (sqlData.Read())
{
    listData itemData = new listData();
    itemData.email = sqlData[0].ToString();
    itemData.email_header = sqlData[1].ToString();
    itemData.email_body = sqlData[2].ToString();
    itemData.email_guid = sqlData[3].ToString();
    Emaillist.Add(itemData);                
}

如果您尝试将任何其他类型添加listData到Emaillist列表中，上述代码将生成编译错误。

于 2013-08-26T01:50:10.273 回答