8

I'm tring to create Card and Deck classes but I'm getting an error message that says

Allocation of incomplete type 'Card'

The problem is happening in Deck::Deck() of Deck.cpp

//
//Deck.h

#ifndef JS_DECK_H
#define JS_DECK_H

#include <iostream>
using std::cout;

#include <vector>
using std::vector;

//forward declaration
class Card;

namespace JS {
    class Deck {

    public:
        Deck();
    private:
        vector<Card *>cards;
    };

}

#endif

//
//Deck.cpp

#include "Deck.h"

using namespace JS;

Deck::Deck(){

    for(int suit = 0; suit < 4; suit++){
        for(int rank = 1; rank < 14; rank++){

            cards.push_back(new Card(rank, suit));//allocation of incomplete type 'Card'
        }
    }
}

//
//Card.h

#ifndef JS_CARD_H
#define JS_CARD_H

#include <ostream>
using std::ostream;

#include <string>
using std::string;

#include <vector>
using std::vector;

namespace JS {
    class Card {

    friend ostream &operator<<(ostream &out, const Card &rhs);

    public:
        enum Suit { DIAMONDS, HEARTS, SPADES, CLUBS };
        enum Rank { ACE = 1, JACK = 11, QUEEN = 12, KING = 13 };

        Card(int rank, int suit) : rank(rank), suit(suit){}

        string getRank() const;
        string getSuit() const;
        int getRankValue() const;

        int operator+(const Card& rhs);
        void displayCard(const Card &rhs);

    private:
        int rank;
        int suit;
    };

}

#endif
4

2 回答 2

12

在Deck（即Deck.cpp文件）的实现中，您需要完整的定义Card才能分配该类型的对象。所以解决方案就是简单地包含Card.h在Deck.cpp.

于 2013-08-15T11:29:23.173 回答
1

您不需要使用“移动”运算符吗？您不能只是将新分配的内存推送到堆栈上，它将在作用域结束时被删除。我指的是这个： 

cards.push_back(new Card(rank, suit));
于 2016-02-22T19:26:59.970 回答