java - ConcurrentModificationException 小游戏

Question

你好。

我正在运行服务器并添加了一个迷你游戏。

每当游戏即将开始时......它首先调用 onStart() 。现在我在这一行得到 ConcurrentModificationException ：

for(Player p : waiting) {

这是方法：

    public void onStart() {
    trawler.players.clear();
    for(Player p : waiting) {
        if(!boat.playerInArea(p)) {
            waiting.remove(p);
        }
    }

    for(Player p : waiting) {
        trawler.players.add(p);
    }

    trawler.start();
    waiting.clear();
}

如果你需要这些课程，这里是：

TrawlerWaitingRoom.java：

package server.model.minigames.trawler;

import server.model.players.Location;
import server.model.players.Player;

public class TrawlerWaitingRoom extends WaitingRoom {
private Trawler trawler;
//private Location boat = new Location(2668,2674,3165,3185);
private Location boat = new Location(2808, 2811,3415,3425);


public TrawlerWaitingRoom(Trawler trawler) {
    super(1, 2);
    this.trawler = trawler;
}

@Override
public boolean startGame() {
    if(trawler.inProgress()) {
        return false;
    }
    return true;
}

@Override
public void onStart() {
    trawler.players.clear();
    for(Player p : waiting) {
        if(!boat.playerInArea(p)) {
            waiting.remove(p);
        }
    }

    for(Player p : waiting) {
        trawler.players.add(p);
    }

    trawler.start();
    waiting.clear();
}

@Override
public void onLeave(Player p) {
    p.asClient().getPA().movePlayer(2804, 3421, 0);
    //p.asClient().getPA().movePlayer(2676, 3170, 0);
}

@Override
public void onJoin(Player p) {
    p.asClient().getPA().movePlayer(2808, 3421, 1);
    //p.asClient().getPA().movePlayer(2672, 3170, 1);
    if(!isActive()) {
        p.asClient().sendMessage(trawler.getGameTime() == 0 ? "The trawler will be returning in less than a minute!" : "The trawler will return in "+trawler.getGameTime() + (trawler.getGameTime() == 1 ? " minute" : " minutes")+"!");
    } else {
        p.asClient().sendMessage(getTimeRemaining() == 0 ? "The trawler will be leaving in less than a minute!" : "The trawler will leave in "+ getTimeRemaining() + (getTimeRemaining() == 1 ? " minute" : " minutes")+"!");
    }
}

@Override
public Location getLocation() {
    return boat;
}

@Override
public void onTimeChange() {
    for(Player p : waiting) {
        if(!isActive()) {
            p.asClient().sendMessage(trawler.getGameTime() == 0 ? "The trawler will be returning in less than a minute!" : "The trawler will return in "+trawler.getGameTime() + (trawler.getGameTime() == 1 ? " minute" : " minutes")+"!");
        } else {
            p.asClient().sendMessage(getTimeRemaining() == 0 ? "The trawler will be leaving in less than a minute!" : "The trawler will leave in "+ getTimeRemaining() + (getTimeRemaining() == 1 ? " minute" : " minutes")+"!");
        }
    }
}

@Override
public boolean canStart() {
    if(trawler.inProgress()) {
        return false;
    }
    if(waiting.size() < minimumPlayers) {
        return false;
    }
    return true;
}

}

GroupMinigame.java:

package server.model.minigames.trawler;

import server.model.minigames.trawler.WaitingRoom;

public abstract class GroupMinigame {

public abstract WaitingRoom getWaitingRoom();

public abstract String getWaitingRoomMessage();
}

WaitingRoom.java：http://pastebin.com/KkC8ReWV _

拖网渔船.java： http ://pastebin.com/XW5XrsjR

提前致谢！

score 6 · Accepted Answer

这是问题所在：

for(Player p : waiting) {
    if(!boat.playerInArea(p)) {
        waiting.remove(p); // BOOM
    }
}

您不能直接修改您正在迭代的集合。

相反，您必须使用Iterator：

for(Iterator<Player> i = waiting.iterator(); i.hasNext();) {
    Player p = i.next(); 
    if(!boat.playerInArea(p)) {
        i.remove(); // Allowed with an iterator
    }
}

score 0 · Accepted Answer

在纠正和理解此错误之前，您需要遵循两个合乎逻辑的步骤。

Java 'for each' 循环是如何工作的？（提示：迭代器）
迭代器的使用如何导致并发修改异常？

score 0 · Accepted Answer

for-each您正在使用循环在对象上创建迭代器。然后您尝试编辑它，这在 Java 中是不允许的。

for(Player p : waiting) {
    // Iterator created.
    if(!boat.playerInArea(p)) {
        // Change to iterated object.
        waiting.remove(p);
    }
}

您的替代方法是创建一个新列表，然后覆盖旧列表。例如：

private List<Waiting> newWaiting = new ArrayList<Waiting>();

for(Player p : waiting) {
   // Iterator created on the WAITING object.
   if(boat.playerInArea(p)) {
       newWaiting.add(p);
       // Logic is flipped, so those that pass are carried forward.
   }
}
waiting = newWaiting;
// Set waiting's reference to point to newWaiting's reference.

score 0 · Accepted Answer

使用Iterator#remove()在List遍历List.

Iterator<Player> itr = waiting.iterator();
while(itr.hasNext()) {
    Player p = itr.next(); 
    if(!boat.playerInArea(p)) {
      itr.remove(); 
    }
}

score 0 · Accepted Answer

这很简单：您从 list 中删除对象waiting，同时将其用作循环。这是不允许的。请尝试以下操作：

List<Player> temporaryList = new LinkedList<Player>(waiting);
for(Player p : temporaryList ) {
    if(!boat.playerInArea(p)) {
        waiting.remove(p);
    }
}

java - ConcurrentModificationException 小游戏

5 回答 5

Related

Reference