1

我有两个类，一个叫做GUIFrame ，它包含所有的图形元素，一个叫做squeak的线程类。GUIFrame中有两个图形元素，第一个是单击时启动线程的按钮：

futures.put(1, pool.submit(new squeak("SqueakyThread",this.jTextArea1)));

第二个是带有名为jTextArea1的变量的javax.swing.JTextArea。

提到的第二个类是称为squeak 的线程类（实现 Runnable）并包含while(true)循环。这个类所做的只是生成一个介于 1 和 10 之间的随机数，然后将该数字输出到GUIFrame类中的jTextArea1。

问题：这是在 Java 中更新 GUI 元素的正确正式方式吗？

我意识到这个问题已经被问了很多，但是有了所有不同的答案，我希望这可以为我自己和其他人提供一个简单的模板。

GUIFrame.java

import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;


public class GUIFrame extends javax.swing.JFrame {

    public GUIFrame() {
        this.pool = Executors.newCachedThreadPool();
        initComponents();
    }

    private ExecutorService pool;
    private Map<Integer, Future<?>> futures = new HashMap<>();
    /**
     * This method is called from within the constructor to initialize the form.
     * WARNING: Do NOT modify this code. The content of this method is always
     * regenerated by the Form Editor.
     */
    @SuppressWarnings("unchecked")
    // <editor-fold defaultstate="collapsed" desc="Generated Code">                          
    private void initComponents() {

        jButton1 = new javax.swing.JButton();
        jScrollPane2 = new javax.swing.JScrollPane();
        jTextArea1 = new javax.swing.JTextArea();

        setDefaultCloseOperation(javax.swing.WindowConstants.EXIT_ON_CLOSE);

        jButton1.setText("Start");
        jButton1.addActionListener(new java.awt.event.ActionListener() {
            public void actionPerformed(java.awt.event.ActionEvent evt) {
                jButton1ActionPerformed(evt);
            }
        });

        jTextArea1.setEditable(false);
        jTextArea1.setColumns(20);
        jTextArea1.setRows(5);
        jScrollPane2.setViewportView(jTextArea1);

        javax.swing.GroupLayout layout = new javax.swing.GroupLayout(getContentPane());
        getContentPane().setLayout(layout);
        layout.setHorizontalGroup(
            layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
            .addGroup(layout.createSequentialGroup()
                .addContainerGap()
                .addComponent(jScrollPane2, javax.swing.GroupLayout.PREFERRED_SIZE, 468, javax.swing.GroupLayout.PREFERRED_SIZE)
                .addGap(18, 18, 18)
                .addComponent(jButton1, javax.swing.GroupLayout.DEFAULT_SIZE, 188, Short.MAX_VALUE)
                .addContainerGap())
        );
        layout.setVerticalGroup(
            layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
            .addGroup(layout.createSequentialGroup()
                .addContainerGap()
                .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
                    .addGroup(javax.swing.GroupLayout.Alignment.TRAILING, layout.createSequentialGroup()
                        .addGap(0, 0, Short.MAX_VALUE)
                        .addComponent(jButton1, javax.swing.GroupLayout.PREFERRED_SIZE, 96, javax.swing.GroupLayout.PREFERRED_SIZE))
                    .addComponent(jScrollPane2, javax.swing.GroupLayout.DEFAULT_SIZE, 444, Short.MAX_VALUE))
                .addContainerGap())
        );

        pack();
    }// </editor-fold>                        

    private void jButton1ActionPerformed(java.awt.event.ActionEvent evt) {                                         
        // TODO add your handling code here:
        futures.put(1, pool.submit(new squeak("SqueakyThread",this.jTextArea1)));
    }                                        

    /**
     * @param args the command line arguments
     */
    public static void main(String args[]) {
        /* Set the Nimbus look and feel */
        //<editor-fold defaultstate="collapsed" desc=" Look and feel setting code (optional) ">
        /* If Nimbus (introduced in Java SE 6) is not available, stay with the default look and feel.
         * For details see http://download.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html
         */
        try {
            for (javax.swing.UIManager.LookAndFeelInfo info : javax.swing.UIManager.getInstalledLookAndFeels()) {
                if ("Nimbus".equals(info.getName())) {
                    javax.swing.UIManager.setLookAndFeel(info.getClassName());
                    break;
                }
            }
        } catch (ClassNotFoundException ex) {
            java.util.logging.Logger.getLogger(GUIFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);
        } catch (InstantiationException ex) {
            java.util.logging.Logger.getLogger(GUIFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);
        } catch (IllegalAccessException ex) {
            java.util.logging.Logger.getLogger(GUIFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);
        } catch (javax.swing.UnsupportedLookAndFeelException ex) {
            java.util.logging.Logger.getLogger(GUIFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);
        }
        //</editor-fold>

        /* Create and display the form */
        java.awt.EventQueue.invokeLater(new Runnable() {
            @Override
            public void run() {
                new GUIFrame().setVisible(true);
            }
        });
    }
    // Variables declaration - do not modify                     
    private javax.swing.JButton jButton1;
    private javax.swing.JScrollPane jScrollPane2;
    private javax.swing.JTextArea jTextArea1;
    // End of variables declaration                   
}

吱吱声.java

import java.util.Random;
import java.util.concurrent.TimeUnit;
import javax.swing.SwingUtilities;

public class squeak implements Runnable {

    private  String Type = "";
    private  javax.swing.JTextArea MW;

    squeak (String type, javax.swing.JTextArea MW)
    {
        this.Type = type;
        this.MW = MW;
    }

    @Override
    public void run ()
    {

        while(true)
        {
            UpdateGUI(RandomNumber()+"\r\n");

            try {
                TimeUnit.SECONDS.sleep(10);
            } catch (InterruptedException e)
            {
                UpdateGUI("Thread is now Exiting!\r\n");
                //Return cause program to exit the while(true) loop and end
                return;
            }
        }
    }

    private int RandomNumber(){
        Random r = new Random();
        int num = r.nextInt(10-1) + 1;
        return num;
    }


    private void UpdateGUI(final String foo) {
        SwingUtilities.invokeLater(new Runnable() {
            @Override
            public void run() {
                // Here, we can safely update the GUI
                // because we'll be called from the
                // event dispatch thread
                MW.append(foo);
            }
        });
    }
}
4

1 回答 1

1

关于，

private void updateGUI(final String foo) {
    SwingUtilities.invokeLater(new Runnable() {
        @Override
        public void run() {
            // Here, we can safely update the GUI
            // because we'll be called from the
            // event dispatch thread
            MW.append(foo);
        }
    });
}

是的，这绝对是一种允许非 Swing 事件线程中的代码更新 Swing 组件的方法——通过将 Runnable 排队到 Swing 事件线程队列SwingUtilities.invokeLater(new Runnable() {...})。

另一种方式，也是我更喜欢的方式，是使用 SwingWorker，因为它内置了机制，允许在后台线程中运行代码，并且仍然能够安全地在 Swing 事件线程上进行 Swing 调用。

我的第一个批评（我必须找到批评的地方，对吗？）是您的代码应该遵循 Swing 命名约定。例如，变量名应该以小写字母开头，而不是大写字母。如果您只是为了自己的乐趣而创建代码，这并不那么重要，但如果您希望其他人审查、更新或维护您的代码，这将变得非常重要。

我的第二个批评在这里：

    jButton1.addMouseListener(new java.awt.event.MouseAdapter() {
        public void mouseReleased(java.awt.event.MouseEvent evt) {
            jButton1MouseReleased(evt);
        }
    });

您不应该将 MouseListeners 用于 JButton，因为它的级别太低了。使用 ActionListeners，因为这是它们的用途，而且更安全。例如，如果您的代码禁用了按钮的 Action 或其模型，则该按钮不应响应，但您的代码将无法正常运行，也不会被正确禁用。

于 2013-07-14T15:07:10.673 回答