1

这完全是优化问题,我有一个这样的分页查询

$this->paginate    = array(
        'fields'    =>  array(
                        'DISTINCT Contact.contact_id',
                        'Contact.first_name',
                        'Contact.last_name',
                        'Contact.email',
                        'Contact.created',
                        'ContactGroup.name',
                      ),  
        'conditions' => array(
                        $this->conditions,
                        'ContactsContactGroup.contact_group_id'=>$viewList,                        
                        isset($keywordQuery)?$keywordQuery:"",
                      ),      
        'limit'      => 5,
         'group'     => array('Contact.contact_id')
                      );
$data = $this->paginate('ContactsContactGroup');
$data = $this->paginate('ContactsContactGroup');

在每个 if 和 else 语句中都会调用此查询,我有四个条件ifand else,并且在所有条件下都编写了上面的代码。

我想优化,并避免在每种情况下都使用大行代码,我该如何优化它,任何答案都将不胜感激。

4

2 回答 2

1

您可以在类中使用另一种方法,该方法将返回数组,而不是将其发布到任何地方。添加以下代码

private function getPaginate($viewList, $keywordQuery) {
  $this->paginate = array( 'fields' => array( 'DISTINCT Contact.contact_id', 'Contact.first_name', 'Contact.last_name', 'Contact.email', 'Contact.created', 'ContactGroup.name', ), 'conditions' => array( $this->conditions, 'ContactsContactGroup.contact_group_id'=>$viewList, isset($keywordQuery)?$keywordQuery:"", ), 'limit' => 5, 'group' => array('Contact.contact_id') );

  //optional: return the result
  return $this->paginate;
}

然后你可以使用

$this->getPaginate( $viewlist, $keywordQuery );
$data = $this->paginate('ContactsContactGroup'); 
$data = $this->paginate('ContactsContactGroup');
于 2013-03-13T06:13:30.050 回答
1

我在搜索页面上用作常规练习的内容是我不断在 if 和 else 中添加条件,并在最后将其连接到主查询。在您的情况下,我认为我们可以这样做:

//here is your if and else statement
$condition = array();
if(someconditions) {
 $condition['user'] = 'suresh'; //your conditions
else if(some conditions)
 $condition['email'] ='abc@gmail.com';

//And than add it to main query 
$this->paginate    = array(
        'fields'    =>  array(
                        'DISTINCT Contact.contact_id',
                        'Contact.first_name',
                        'Contact.last_name',
                        'Contact.email',
                        'Contact.created',
                        'ContactGroup.name',
                      ),  
        'conditions' => array(
                        $condition
                        'ContactsContactGroup.contact_group_id'=>$viewList,                        
                        isset($keywordQuery)?$keywordQuery:"",
                      ),      
        'limit'      => 5,
         'group'     => array('Contact.contact_id')
                      );
$data = $this->paginate('ContactsContactGroup');
$data = $this->paginate('ContactsContactGroup');
于 2013-03-13T06:25:05.110 回答