python - Python中的井字游戏循环未运行

Question

我不知道为什么，但是下面的 Python 3 代码并没有tie(cell)像我希望的那样在内部循环中运行该函数（因此当电路板已满时循环停止运行）。

任何人都知道为什么？谢谢！

import random
cell = ['1', '2', '3', '4', '5', '6', '7', '8', '9']
def owin(cell):
    if cell[0] == cell[1] == cell[2] == 'O' or cell[3] == cell[4] == cell[5] == 'O' or cell[6] == cell[7] == cell[8] == 'O' or cell[0] == cell[3] == cell[6] == 'O' or cell[1] == cell[4] == cell[7] == 'O' or cell[2] == cell[5] == cell[8]== 'O':
        return True
    else:
        return False
def xwin(cell):
    if cell[0] == cell[1] == cell[2] == 'X' or cell[3] == cell[4] == cell[5] == 'X' or cell[6] == cell[7] == cell[8] == 'X' or cell[0] == cell[3] == cell[6] == 'X' or cell[1] == cell[4] == cell[7] == 'X' or cell[2] == cell[5] == cell[8]== 'X':
        return True
    else:
        return False
def tie(cell):
    if cell[0] in ('O', 'X') and cell[1] in ('O', 'X') and cell[2] in ('O', 'X') and cell[3] in ('O', 'X') and cell[4] in ('O', 'X') and cell[5] in ('O', 'X') and cell[6] in ('O', 'X') and cell[7] in ('O', 'X') and cell[8] in ('O', 'X'):
        return True
    else:
        return False
board = '\n\t ' + cell[0] + ' | ' + cell[1] + ' | ' + cell[2] + '\n\t-----------\n\t ' + cell[3] + ' | ' + cell[4] + ' | ' + cell[5] + '\n\t-----------\n\t ' + cell[6] + ' | ' + cell[7] + ' | ' + cell[8]
print('\tTIC TAC TOE\n\t\tBy Lewis Cornwall')
instructions = input('Would you like to read the instructions? (y/n)')
if instructions == 'y':
    print('\nEach player takes turns to place a peice on the following grid:\n\n\t 1 | 2 | 3\n\t-----------\n\t 4 | 5 | 6\n\t-----------\n\t 7 | 8 | 9\n\nBy inputing a vaule when prompted. The first to 3 peices in a row wins.')
player1 = input('Enter player 1\'s name: ')
player2 = input('Enter player 2\'s name: ')
print(player1 + ', you are O and ' + player2 + ', you are X.')
nextPlayer = player1
while not owin(cell) and not xwin(cell) and not tie(cell):
    print('This is the board:\n' + board)
    if nextPlayer == player1:
        move = input('\n' + player1 + ', select a number (1 - 9) to place your peice: ')
        cell[int(move) - 1] = 'O'
        board = '\n\t ' + cell[0] + ' | ' + cell[1] + ' | ' + cell[2] + '\n\t-----------\n\t ' + cell[3] + ' | ' + cell[4] + ' | ' + cell[5] + '\n\t-----------\n\t ' + cell[6] + ' | ' + cell[7] + ' | ' + cell[8]
        nextPlayer = player2
    else:
        move = input('\n' + player2 + ', select a number (1 - 9) to place your peice: ')
        cell[int(move) - 1] = 'X'
        board = '\n\t ' + cell[0] + ' | ' + cell[1] + ' | ' + cell[2] + '\n\t-----------\n\t ' + cell[3] + ' | ' + cell[4] + ' | ' + cell[5] + '\n\t-----------\n\t ' + cell[6] + ' | ' + cell[7] + ' | ' + cell[8]
        nextPlayer = player1
if owin(cell):
    print('Well done, ' + player1 + ', you won!')
elif xwin(cell):
    print('Well done, ' + player2 + ', you won!')
else:
    print('Unfortunately, niether of you were able to win today.')
input('Press <enter> to quit.')

Answer 1

在您编写的代码中，唯一的外观tie(cell)是这个：

while not owin(cell) and not xwin(cell) and not tie(cell):

请注意，它是一个逻辑表达式，并且在几乎所有编程语言（包括 Python）中，都对逻辑表达式进行了优化，如下所示：

# here test_func() won't be invoked
if 1 or test_func():
    pass

# here test_func() won't be invoked
if 0 and test_func():
    pass

# here test_func() would be invoked
if 1 and test_func():
    pass

# here test_func() would be invoked
if 0 or test_func():
    pass

所以不被调用的原因tie(cell)是要么要么owin(cell)返回xwin(cell)true。

Answer 2

替换函数 tie(cell) 内的 Condition

if cell[0] in ('O', 'N') and cell[1] in ('O', 'N') and cell[2] in ('O', 'N') and cell[3] in ('O', 'N') and cell[4] in ('O', 'N') and cell[5] in ('O', 'N') and cell[6] in ('O', 'N') and cell[7] in ('O', 'N') and cell[8] in ('O', 'N'):

经过

 if cell[0] in ('O', 'X') and cell[1] in ('O', 'X') and cell[2] in ('O', 'X') and cell[3] in ('O', 'X') and cell[4] in ('O', 'X') and cell[5] in ('O', 'X') and cell[6] in ('O', 'X') and cell[7] in ('O', 'X') and cell[8] in ('O', 'X'):

Answer 3

条件应该是这样的：

while (not owin(cell) or not xwin(cell)) and not tie(cell):

Answer 4

正如@PengyuCHEN 所说，只有在其他 2 次检查之后才会调用
您的tie()函数。因此，如果您重新排列它，您会发现您的问题已解决。所以，这应该工作：

while not tie(cell) and not (owin(cell) or xwin(cell)):

另外，虽然你没有要求它，但我试图清理你的代码......

import random
instructions = '''
Each player takes turns to place a piece on the following grid:

     1 | 2 | 3
    -----------
     4 | 5 | 6
    -----------
     7 | 8 | 9

By inputting a value when prompted. The first to 3 pieces in a row wins'''

form = '''
\t| %s | %s | %s |
\t-------------
\t| %s | %s | %s |
\t-------------
\t| %s | %s | %s |
'''

cell = ['1', '2', '3', '4', '5', '6', '7', '8', '9']

def win(cell, char):
    return cell[0] == cell[1] == cell[2] == char or\
       cell[3] == cell[4] == cell[5] == char or\
       cell[6] == cell[7] == cell[8] == char or\
       cell[0] == cell[3] == cell[6] == char or\
       cell[1] == cell[4] == cell[7] == char or\
       cell[2] == cell[5] == cell[8] == char

def tie(cell):
    return all(c in ('O','X') for c in cell)

def get_input(player):
    while True:
        m = input('\n%s, select a number (1 - 9) to place your peice: ' % player)
        try:
            return int(m)
        except BaseException:
            print 'Invalid Input'
            continue

board = form % tuple(cell)

print('\tTIC TAC TOE\n\t\tBy Lewis Cornwall')
instr = input('Would you like to read the instructions? (y/n) ')
if instr.startswith('y'):
    print(instructions)

player1 = input('Enter player 1\'s name: ').strip()
player2 = input('Enter player 2\'s name: ').strip()

print(player1 + ', you are O and ' + player2 + ', you are X.')
nextPlayer = player1

while not tie(cell) and not (win(cell, 'O') or win(cell,"X")):
    print('This is the board:\n' + board)
    if nextPlayer == player1:
        move = get_input(player1)
        cell[move - 1] = 'O'
        board = form % tuple(cell)
        nextPlayer = player2
    else:
        move = get_input(player2)
        cell[move - 1] = 'X'
        board = form % tuple(cell)
        nextPlayer = player1

if win(cell,"O"):
    print('Well done, ' + player1 + ', you won!')
elif win(cell,"X"):
    print('Well done, ' + player2 + ', you won!')
else:
    print('Unfortunately, neither of you were able to win today.')
input('Press <enter> to quit.')