1

我使用下面的代码来检查评论中描述的一些案例。不幸的是，它降低了页面加载速度。为了改进功能并正确使用它们，您有什么建议，我该怎么办？

function insert() {
    if ($this - > session - > userdata('logged_in')) { //This is for test whether the user is logged in or not?
        if ($this - > siran - > access_level_active()) { //This is because the user name manager is active or not?
            if ($this - > siran - > access_level('1', '5')) { //This is for whether or not permission to access this page?
if($_POST){
                $this - > load - > view('admin/onepage');
}else{
        $this->session->set_flashdata('message_p', $this->lang->line('nopost'));
        redirect($this->session->userdata('previous_page'));
        }
            } else {
                $this - > session - > set_flashdata('message', $this - > lang - > line('notaccess'));
                redirect($this - > session - > userdata('previous_page'));
            }
        } else {
            $this - > session - > set_flashdata('message', $this - > lang - > line('noactive'));
            redirect('login', 'refresh');
        }
    } else {
        $this - > session - > set_flashdata('message', $this - > lang - > line('plslogin'));
        redirect('login', 'refresh');
    }
}

库codeigniter中的这三个函数：

public function access_level($mp, $access){
    //$mp = '1';
    $CI = &get_instance();
            $result = $CI->db->get_where('access_level', array('mainpage'=>$mp,'id_relation'=>$CI->session->userdata('id_relation')));
    $data = array();
    $out = array();
    foreach($result->result() as $row){
        $dv = json_decode($row->subpage);       
        $flat = array();        
        foreach ( $dv as $item ) {
            $flat = array_merge( $flat, explode( ',', $item ) );
        }       
        $out = array_merge( $out, $flat );
    }
    if(in_array($access, $out) || in_array('110', $out)){
        return  true;
    }else{
        return false;
    }
}
public function access_level_active(){
    //$mp = '1';
    $CI = &get_instance();
            $result = $CI->db->get_where('users', array('id'=>$CI->session->userdata('id')));
    if ($result->num_rows() > 0){
        $row = $result->row();
        return ($row->active == 1 ? true : false );
    }else{
        return false;
    }
}
function previous_page(){
    $CI = &get_instance();
    if ($CI->session->userdata('logged_in')) {
        if (isset($_SERVER['HTTP_REFERER']))
        {
            $CI->session->set_userdata('previous_page', $_SERVER['HTTP_REFERER']);
        }else
        {
            $CI->session->set_userdata('previous_page', base_url());
        }
    }
}
4

1 回答 1

0

您的代码看起来不是特别密集，我唯一要更改的是限制您在自身内嵌套 if{}else{} 语句的次数，并将任何重复的代码移到另一个函数中。例如，我会亲自重写您的insert()代码如下（主要是因为它看起来更干净）。

插入功能：

function insert() {

    if (!$this->session->userdata('logged_in')) {
        $this->_flashRedirect('login', $this->lang->line('plslogin'));  
    }

    if (!$this->siran->access_level_active()) {
        $this->_flashRedirect('login', $this->lang->line('noactive'));  
    }

    if (!$this->siran->access_level('1', '5')) {
        $this->_flashRedirect($this->session->userdata('previous_page'), $this->lang->line('notaccess'));       
    }

    if($_POST){
        $this->load->view('admin/onepage');
    } else {
        $this->_flashRedirect($this->session->userdata('previous_page'), $this->lang->line('nopost'), 'message_p'); 
    }

}

_flashRedirect()在控制器中创建一个新函数：

public function _flashRedirect($page, $message, $message_type = 'message') {
    $this->session->set_flashdata('message', $message);
    redirect($page, 'refresh');
}

至于速度，听起来您的查询（mysql）更有可能是您的性能问题的原因。你要返回多少行，你的表有多大？

于 2013-02-19T03:01:33.077 回答