0

谁能向我解释为什么该delete_min()功能不起作用？几个小时以来，我一直试图弄清楚这一点。

我尝试了该功能的不同变体，但它似乎要么删除了错误的东西，要么只更改数据而不删除它，要么删除了错误的东西。此外，插入函数在调用后并不总是正常工作delete_min()，所以我确信这与指针有关。

这是功能：

int BinaryTree::delete_min_helper(TreeNode *node){

   while(node->left != NULL){
      node = node->left;
   }

  if(node == root){
     puts("attempted to delete root");
     return 1;
  }

  delete node;
  node = NULL;
  return 0;
}

这是一个可编译的示例：

#ifndef _TREE_H_
#define _TREE_H_

#include <stdlib.h>
#include <stdio.h>
#include <string.h>

struct TreeNode {
  int val;
  char *str;
  TreeNode *left;
  TreeNode *right;
};

class BinaryTree {
  public:

  BinaryTree();
  ~BinaryTree();

  int insert_node(unsigned int val, char *str);
  TreeNode *find_min();
  int delete_min();
  void print();

 private:

 int insert_node_helper(TreeNode *&node, unsigned int val, char *str);
 int delete_min_helper(TreeNode *node);
 void print_helper(TreeNode *node);

 TreeNode *root;  
};

#endif

BinaryTree::BinaryTree(){
  this->root = NULL;
}

BinaryTree::~BinaryTree(){
}

int BinaryTree::insert_node(unsigned int val, char *str){
  return insert_node_helper(this->root, val, str);
}

int BinaryTree::insert_node_helper(TreeNode *&node, unsigned int val, char *str){

  if(node == NULL){
    node = new TreeNode;
    node->val = val;
    node->str = strdup(str);
    node->left = NULL;
    node->right = NULL;
    if(node != NULL){
      return 0;
    }else{
      puts("inserted null node");
      return 1;
   }
 }else if(val <= node->val){
   return insert_node_helper(node->left, val, str);
 }else if(val > node->val){
   return insert_node_helper(node->right, val, str);
 }

 return 1;
}

void BinaryTree::print(){
  print_helper(this->root);
}


void BinaryTree::print_helper(TreeNode *node){

    if(node != NULL){
      print_helper(node->right);
      printf("%d occurrences of \"%s\"\n", node->val, node->str);
      print_helper(node->left);
    }

}

TreeNode *BinaryTree::find_min(){
  TreeNode *temp = this->root;
  while(temp->left != NULL){
    temp = temp->left;
  }
  return temp;
}

int BinaryTree::delete_min(){
   return delete_min_helper(root);
}

int BinaryTree::delete_min_helper(TreeNode *node){

   while(node->left != NULL){
     node = node->left;
   }

  if(node == root){
    puts("attempted to delete root");
    return 1;
  }

  delete node;
  node = NULL;
  return 0;
}

#include <time.h>

int main(){

  BinaryTree bt;

  srand(time(NULL));
  for(int i = 0; i < 10; i++){
     bt.insert_node(rand() % 20, "test");
  }

  bt.print();
  printf("min val = %d\n", bt.find_min()->val);
  puts("#################################");
  bt.delete_min();
  bt.print();
  printf("min val = %d\n", bt.find_min()->val);

  return 0;
}
4

2 回答 2

4

马上想到两件事：

  1. 父节点仍指向您删除的节点

  2. 您要删除的节点可能有一个node->right指针挂在它上面，您正在从树上砍掉它，而不是将它重新挂回树中。

可能还有更多问题，但您至少需要解决这些问题。

于 2013-02-08T02:30:37.283 回答
-1

他父母的引用仍然指向内存中的某个地址。

尝试这个：

int BinaryTree::delete_min_helper(TreeNode *node){

   TreeNode *prev = NULL;
   while(node->left != NULL){
      prev = node;
      node = node->left;
   }

  if(node == root){
     puts("attempted to delete root");
     return 1;
  }

  prev->left = NULL;

  delete node;
  node = NULL;
  return 0;
}
于 2013-02-08T02:31:03.443 回答