0

这是完整的错误信息

> In file included from
> c:\mingw\bin\../lib/gcc/mingw32/4.7.2/include/c++/vector:63:0,
>                      from PlayerDatabase.h:4,
>                      from PlayerDatabase.cpp:6: 

c:\mingw\bin\../lib/gcc/mingw32/4.7.2/include/c++/bits/stl_construct.h:
> In function 'void std::_Construct(_T1*, const _T2&)':

> c:\mingw\bin\../lib/gcc/mingw32/4.7.2/include/c++/bits/stl_construct.h:85:13:
> error: expected type-specifier before 'static_cast'

> c:\mingw\bin\../lib/gcc/mingw32/4.7.2/include/c++/bits/stl_construct.h:85:13:
> error: expected ')' before 'static_cast'

> c:\mingw\bin\../lib/gcc/mingw32/4.7.2/include/c++/bits/stl_construct.h:85:13:
> error: expected ';' before 'static_cast'

PlayerDatabase.h:4 中包含的文件是矢量头文件

我在我的 cpp 文件中使用了动态转换，在通过 push_baxk() 将它们插入向量之前将投手和击球手指针更改为基类棒球运动员指针，这是问题吗？

这是 playerdatabase.h 文件

#include <vector>
#include "BaseballPlayer.h"
#include "Hitter.h"
#include "Pitcher.h"

// 这是玩家数据库类定义

class PlayerDatabase {

public:
    PlayerDatabase();
    PlayerDatabase(PlayerDatabase&);
    PlayerDatabase& operator= (PlayerDatabase&);
    ~PlayerDatabase();
    void print_team(std::ofstream&);
    void load_team(std::ifstream&);
    void create_good_team();
    void create_small_team();
    int get_team_count();

private:
    std::vector<BaseballPlayer*> team;
};

这是 playerdatabase.cpp

#include <iomanip>
#include "cppMemDbg.h"
#include "PlayerDatabase.h"

const char HITTER='H';
const char PITCHER='P';
const int REDUCE_BY=4;

// 没有参数的默认构造函数

PlayerDatabase::PlayerDatabase(){

}

// 复制构造函数

PlayerDatabase::PlayerDatabase(PlayerDatabase& right){
std::vector<BaseballPlayer*>::iterator begin, end;
begin=right.team.begin();
end=right.team.end();

while (begin!=end){
    Pitcher* pPlayer= dynamic_cast<Pitcher*>(*begin);
    if (pPlayer){
        Pitcher* pitcher= new Pitcher(*pPlayer);
        team.push_back(dynamic_cast<BaseballPlayer*>(pitcher));
    }

    else{
        Hitter* hPlayer= dynamic_cast<Hitter*>(*begin);
        Hitter* hitter= new Hitter(*hPlayer);
        team.push_back(dynamic_cast<BaseballPlayer*>(hitter));
    }

    begin++;
}

}

// 赋值运算符

PlayerDatabase& PlayerDatabase::operator= (PlayerDatabase& right){
if (team==right.team)
    return *this;

else {
    std::vector<BaseballPlayer*>::iterator begin, end;
    begin=right.team.begin();
    end=right.team.end();

    while (begin!=end){

        Pitcher* pPlayer= dynamic_cast<Pitcher*>(*begin);
        if (pPlayer){
            Pitcher* pitcher= new Pitcher(*pPlayer);
            BaseballPlayer* bplayer= dynamic_cast<BaseballPlayer*>(pitcher);
            team.push_back(bplayer);
        }

        else{
            Hitter* hPlayer= dynamic_cast<Hitter*>(*begin);
            Hitter* hitter= new Hitter(*hPlayer);
            BaseballPlayer* bplayer= dynamic_cast<BaseballPlayer*>(hitter);
            team.push_back(bplayer);
        }
        begin++;
    }
}
return *this;

}

// 析构函数

PlayerDatabase::~PlayerDatabase(){
std::vector<BaseballPlayer*>::iterator iter;
for (iter=team.begin();iter!=team.end();iter++){
    if (*iter)
        delete *iter;
    *iter=nullptr;
}
team.clear();

}

// 将棒球运动员打印到标准输出并将它们写入给定文件的函数

void PlayerDatabase::print_team(std::ofstream& outputFile){
int totalHits=0, totalAtBats=0, totalEarnedRuns=0;
float totalInningsPitched=0.0;

std::vector<BaseballPlayer*>::iterator begin, end;
begin=team.begin();
end=team.end();
int member=1;

while (begin!=end){
    std::cout<<"Member "<<member<<std::endl;
    (*begin)->print_player(outputFile);

    Pitcher* pPlayer= dynamic_cast<Pitcher*>(*begin);
    if (pPlayer){
        totalEarnedRuns+=pPlayer->earnedRuns;
        totalInningsPitched+=pPlayer->inningsPitched;
        begin++;
        member++;
    }

    else{
        Hitter* hPlayer= dynamic_cast<Hitter*>(*begin);
        totalHits+=hPlayer->hits;
        totalAtBats+=hPlayer->atBats;
        begin++;
        member++;
    }

}

if(totalAtBats==0||totalInningsPitched==0.0){

    if(totalAtBats==0&&totalInningsPitched==0.0){
        std::cout<<"Team Batting Average: "<<"n/a"<<std::endl;
        std::cout<<"Team ERA: "<<"n/a"<<std::endl;
    }
    else if (totalAtBats==0){
        std::cout<<"Team Batting Average: "<<"n/a"<<std::endl;
        std::cout<<"Team ERA: "<<(totalEarnedRuns/totalInningsPitched*9)<<std::endl;
    }
    else {
        std::cout<<"Team Batting Average: "<<std::fixed<<std::setprecision(3)<<totalHits/(double)totalAtBats<<std::endl;
        std::cout<<"Team ERA: "<<"n/a"<<std::endl;
    }
}

else{
    std::cout<<"Team Batting Average: "<<std::fixed<<std::setprecision(3)<<totalHits/(double)totalAtBats<<std::endl;
    std::cout<<"Team ERA: "<<(totalEarnedRuns/totalInningsPitched*9)<<std::endl;
}

}

// 从格式化的输入文件中加载棒球运动员

void PlayerDatabase::load_team(std::ifstream& input){
int counter=1;
while (!input.eof()){
    char playerType;
    input.get(playerType);

    if (playerType==HITTER){
        Hitter* hitter= new Hitter;
        hitter->load_player(input);
        std::cout<<"Loading member "<<counter<<std::endl;
        team.push_back(dynamic_cast<BaseballPlayer*>(hitter));
        counter++;
    }

    else if (playerType==PITCHER){
        Pitcher* pitcher= new Pitcher;
        pitcher->load_player(input);
        std::cout<<"Loading member "<<counter<<std::endl;
        team.push_back(dynamic_cast<BaseballPlayer*>(pitcher));
        counter++;
    }

}

}

// 通过消除一些基于 goodHitter() 和 goodPitcher() 函数的函数来创建一个好的团队

void PlayerDatabase::create_good_team(){

std::vector<BaseballPlayer*> goodTeam;

std::vector<BaseballPlayer*>::iterator begin, end;
begin=team.begin();
end=team.end();

while (begin!=end){

    Pitcher* pPlayer= dynamic_cast<Pitcher*>(*begin);
    if (pPlayer){
        if(pPlayer->goodPitcher()){

            goodTeam.push_back(dynamic_cast<BaseballPlayer*>(pPlayer));
        }
        else {
            if (*begin)
                delete *begin;
            *begin=nullptr;
        }
        begin++;
    }

    else{
        Hitter* hPlayer= dynamic_cast<Hitter*>(*begin);
        if(hPlayer->goodHitter()){
            goodTeam.push_back(dynamic_cast<BaseballPlayer*>(hPlayer));
        }
        else {
            if (*begin)
                delete *begin;
            *begin=nullptr;
        }
        begin++;
    }
}
team.clear();
team=goodTeam;

}

// 创建一个小团队，删除向量中的前四个玩家

void PlayerDatabase::create_small_team(){
if(get_team_count()>=REDUCE_BY){
    std::vector<BaseballPlayer*>::iterator first, fifth;
    first= team.begin();
    fifth=first+REDUCE_BY;

    while (first!=fifth){
        if (*first)
            delete *first;
        *first=nullptr;
        first++;
    }
    team.erase(team.begin(),fifth);
}

else {
    std::vector<BaseballPlayer*>::iterator first,last;
    first= team.begin();
    last=team.end();
    while(first!=last){
        if (*first)
            delete *first;
        *first=nullptr;
        first++;
    }
    team.clear();
}

} // 团队成员的数量

int PlayerDatabase::get_team_count(){
return team.size();

}

这部分有什么问题吗？

 std::vector<BaseballPlayer*>::iterator begin, end;
 begin=right.team.begin();
 end=right.team.end();
4

1 回答 1

1

那是很多代码！但是有几件事可以说是错误的：

PlayerDatabase(PlayerDatabase&); // this is the one the error is complaining about

这声明了一个可变的复制构造函数。如果你想要那很好，但你可能不想要。你想要这个：

PlayerDatabase(PlayerDatabase const&);

您的赋值运算符也是如此，除非它需要修改源（并且您不想这样做），否则它应该是：

PlayerDatabase& operator= (PlayerDatabase const&);

我在你的整个代码中没有看到一个const限定符，所以你可能不知道const-correctness。您应该对该主题进行一些研究，但它基本上说明了操作是否会修改给定的参数。

于 2013-01-11T18:17:38.597 回答