1

代码的以下部分不起作用，因为每个单词的赢/输计数不断增加超过 1，有时我会得到一个字符串长度的空指针异常。此外，虽然玩家应该得到 7 次尝试（int no），但有时他会得到更多，有时会更少。字符串取自文本文件“Hangeng.txt”。整个游戏在按键监听器内的键盘按键监听器内。欢迎任何有关如何安排游戏布局以避免错误的提示，因为我才刚刚开始使用 swing 和 gui 的东西。

        public class test{
static int won = 0;
static int lost = 0;
static String key = "";
static String word = null;
static int no = 0;
static StringBuffer toguess;

      public static void main(String[] args) throws IOException{

 JFrame frame = new JFrame();
  frame.setLayout(new GridLayout(3,1));
      JPanel panel1 = new JPanel();
     JPanel panel2 = new JPanel();
      JPanel panel3 = new JPanel();
         JButton button = new JButton();
           JLabel label = new JLabel();
           JLabel label2 = new JLabel();
            panel1.add(label);
              panel2.add(button);
                  panel3.add(label2);
                    frame.setSize(800,600);
                   frame.add(panel1);
                          frame.add(panel2);
                      frame.add(panel3);
                     frame.setVisible(true);

 //the button that starts the game or gets a new word
 button.addActionListener(new ActionListener() {
        public void actionPerformed(ActionEvent e) {
            frame.requestFocus();

                no = 0;

                label2.setText("won " + won + ", lost " + lost);
                button.setText("Next");


                                    //get random word from file
                BufferedReader reader = null;
                try {
                    reader = new BufferedReader(new FileReader(
                            "hangeng.txt"));
                } catch (FileNotFoundException e1) {
                    e1.printStackTrace();
                }
                int lineno = (int) (Math.random() * 100);
                for (int i = 0; i < lineno; i++) {
                    try {
                        reader.readLine();
                    } catch (IOException e1) {
                        e1.printStackTrace();
                    }
                }

                try {
                    word = reader.readLine().replace(" ", "");
                } catch (IOException e1) {
                    e1.printStackTrace();
                }




                String missing = "";
                for (int u = 0; u < (word.length() - 2); u++) {
                    missing = missing + "*";
                }
                final String guess = word.charAt(0) + missing
                        + word.charAt((word.length() - 1));
                toguess = new StringBuffer(guess);
                label.setText(toguess.toString());
                final ArrayList<String> tried = new ArrayList<String>();



            //keylistener that listens to key clicks by the user

         frame.addKeyListener(new KeyListener() {
                    public void keyPressed(KeyEvent arg0) {
                    }

                    public void keyReleased(KeyEvent arg0) {
                    }

                    public void keyTyped(KeyEvent arg0) {
                        key = "" + arg0.getKeyChar();
                        String guessing = null;
                        boolean k = false;

                        if ((no < 6)) {
                            guessing = key;
                            System.out.println(guessing);
                            if (!(tried.contains(guessing))) {
                                tried.add(guessing);
                                for (int length = 1; length < (guess
                                        .length() - 1); length++) {
                                    if (guessing.equals(String.valueOf(word.charAt(length)))) {
                                        toguess.replace(length,
                                                (length + 1),
                                                String.valueOf(word.charAt(length)));
                                        k = true;
                                    }
                                }
                                if (k == true) {
                                    label.setText(toguess.toString());
                                } else {
                                    no = no + 1;
                                }
                                k = false;
                            }
                            label.setText(toguess.toString());
                            if (toguess.toString().equals(word)) {
                                label.setText("Correct! The word was "  + word);
                                no = 6;
                                won = won + 1;
                            }
                        }
                        else if ((no == 6)
                                && (!(toguess.toString().equals(word)))) {
                            label.setText("Sorry, but the word was " + word);

                            lost = lost + 1;
                        }
                    }
                });
            }

    }); 

          }
   }
4

1 回答 1

3

+1 对所有评论....

添加到他们：

  • 不要KeyListener使用 aKeyAdapter但是，因为您使用的是 Swing 而不是 AWT，您应该使用s 来表示 Swing ，例如KeyBinding参见此处。

  • 不要忘记在Event Dispatch ThreadviaSwingUtiltities.invokeLater(..)块上创建和操作 Swing 组件，请参阅此处了解更多信息。

  • 检查他们应该以大写字母开头的类命名方案，即test应该是Test并且之后的每个新单词都应该大写。

  • 不要调用setSize而是JFrame使用适当的LayoutManager和/或覆盖并返回适合其内容的大小并getPreferredSize()在添加所有组件后调用实例。JPanelpack()JFrame

  • 此外，SSCCE应该可以通过复制和粘贴进行编译，这不是.... 即需要将变量更改为最终变量，我没有 Haneng.txt 的样本，因此无法测试

  • 最后使用@Override 注释来确保您覆盖了正确的方法，即

    @Override
public void actionPerformed(ActionEvent e) {

}
于 2012-12-23T16:36:51.413 回答