3

我正在尝试在我的课堂上使用一种收费的方法。方法是这样的：

  public double chargeFee()
  {
    balance -= 10;
    return balance;
  }

但是，它减去了 20。我尝试重新编译它，但找不到导致问题的原因。

完整代码：

public class ManageAccounts
{
    public static void main(String[] args)
    {
     Account acct1, acct2; 


    //create account1 for Sally with $1000
    acct1 = new Account(1000, "Sally", 1111);
    acct2 = new Account(500, "Joe", 2222);//create account2 for Joe with $500

    System.out.println("Depositing $100 into Account 2222...");
    acct2.deposit(100.00);//deposit $100 to Joe's account
    System.out.println("New Balance for Account 2222: $" + acct2.getBalance());//print Joe's new balance (use getBalance())
    System.out.println();
    System.out.println("Withdrawing $50 from Account 1111...");
    acct1.withdraw(50);//withdraw $50 from Sally's account

    System.out.println("New Balance for Account 1111: $" + acct1.getBalance());//print Sally's new balance (use getBalance())
    System.out.println();
    acct1.chargeFee();
    acct2.chargeFee();//charge fees to both accounts
    System.out.println("Charging usage Fees...");
    System.out.println("Account balance after fees:");
    System.out.println("Account 1111: $" + acct1.chargeFee());
    System.out.println("Account 2222: $" + acct2.chargeFee());
    System.out.println();
    System.out.println("Changing name on Account 2222...");
    acct2.changeName("Joseph");//change the name on Joe's account to Joseph
    System.out.println();
    System.out.println("Printing account summaries...");
    System.out.println(acct1.toString());
    System.out.println(acct2.toString());//print summary for both accounts

    }
}



import java.text.NumberFormat;

public class Account
{
  private double balance;
  private String name;
  private long acctNum;
    NumberFormat money = NumberFormat.getCurrencyInstance();
  //----------------------------------------------
  //Constructor -- initializes balance, owner, and account number
  //----------------------------------------------
  public Account(double initBal, String owner, long number)
  {
    balance = initBal;
    name = owner;
    acctNum = number;
  }

  //----------------------------------------------
  // Checks to see if balance is sufficient for withdrawal.
  // If so, decrements balance by amount; if not, prints message.
  //----------------------------------------------
  public void withdraw(double amount)
  {
    if (balance >= amount)
       balance -= amount;
    else
       System.out.println("Insufficient funds");
  }

  //----------------------------------------------
  // Adds deposit amount to balance.
  //----------------------------------------------
  public void deposit(double amount)
  {
    balance += amount;
  }

  //----------------------------------------------
  // Returns balance.
  //----------------------------------------------
  public double getBalance()
  {
    return balance;
  }


  //----------------------------------------------
  // Returns a string containing the name, account number, and balance.
  //----------------------------------------------
  public String toString()
  {
    return ("Name: " + name + "\tAccount Number: " + acctNum + "\tBalance: " + money.format(balance));
  }

  //----------------------------------------------
  // Deducts $10 service fee
  //----------------------------------------------
  public double chargeFee()
  {
    balance -= 10;
     return balance;
  }

  //----------------------------------------------
  // Changes the name on the account 
  //----------------------------------------------
  public void changeName(String newName)                          
  {
    name = newName;
  }

}

一些示例输出：

Depositing $100 into Account 2222...
New Balance for Account 2222: $600.0

Withdrawing $50 from Account 1111...
New Balance for Account 1111: $950.0

Charging usage Fees...

Account balance after fees:

Account 1111: $930.0
Account 2222: $580.0

Changing name on Account 2222...

Printing account summaries...
Name: Sally Account Number: 1111    Balance: $930.00
Name: Joseph    Account Number: 2222    Balance: $580.00
4

5 回答 5

7

您在两个帐户上调用chargeFee了两次，一次是在您收取实际费用时，另一次是在您打印结果时。

为了将来参考，有一个称为“单独的命令和查询”或 CQS 的指南。您可能想阅读它。为了说明您的情况：

  • 您正在使用chargeFee作为查询（即，您返回余额）
  • 而你chargeFee用作命令，扣钱。

更改chargeFee为返回一个void（或者this如果您想要方法链接），您不会不小心将它用作查询。

http://en.wikipedia.org/wiki/Command-query_separation

于 2012-11-30T03:20:37.170 回答
3

它为每个帐户扣除 2 笔费用。

acct1.chargeFee();
acct2.chargeFee();//charge fees to both accounts
System.out.println("Charging usage Fees...");
System.out.println("Account balance after fees:");
System.out.println("Account 1111: $" + acct1.chargeFee());
System.out.println("Account 2222: $" + acct2.chargeFee());

可以说，chargeFee()不应该返回平衡，而是void像deposit()or withdraw()。另请注意，财务问题通常以数字int而非double数字来处理。

于 2012-11-30T03:20:53.797 回答
2 
System.out.println("New Balance for Account 1111: $" + acct1.getBalance());//print Sally's   new balance (use getBalance())
System.out.println();
acct1.chargeFee();------------------------//First time
acct2.chargeFee();//charge fees to both accounts
System.out.println("Charging usage Fees...");
System.out.println("Account balance after fees:");
System.out.println("Account 1111: $" + acct1.chargeFee());------------------------//second time
System.out.println("Account 2222: $" + acct2.chargeFee());
于 2012-11-30T03:22:12.913 回答
2 
1) 
acct1.chargeFee();
acct2.chargeFee();//charge fees to both accounts

2)
System.out.println("Account 1111: $" + acct1.chargeFee());
System.out.println("Account 2222: $" + acct2.chargeFee());

注意你如何调用chargeFee()两次。这就是给你带来混乱结果的原因。您只需要调用一次，然后只需在第二次打印每个帐户中的余额（第 2 部分）。

System.out.println("Account 1111: $" + Account 1111's balance);
System.out.println("Account 2222: $" + Account 2222's balance);

希望有帮助！

于 2012-11-30T03:23:36.003 回答
1

您已经有几个正确答案指出了程序中的问题。这并不是一个真正的答案，而是对您如何自己发现这个问题的扩展评论。

给定一个理论，即方法 chargeFee 减去 20，下一步是添加断点或打印输出以检查它的实际作用：

public double chargeFee() {
  System.out.println("Before subtract: " + balance + " Account: " + acctNum);
  balance -= 10;
  System.out.println("After subtract: " + balance + " Account: " + acctNum);
  return balance;
}

带有附加打印输出的程序的输出很明显，每次调用chargeFee 只减去10，但每个帐户调用两次。

于 2012-11-30T03:31:57.403 回答