1

我不明白为什么这适用于 90% 的输入,但不适用于其他输入。它的目的是告诉你有多少硬币可以换回来。大多数测试金额都可以正常工作,但如果您输入 4.20(或 4.20 美元),它会返回 23 个硬币……应该是 18 个硬币(16 个硬币和 2 个镍币)。错误在哪里?这是我的代码:

#include <stdio.h>
#include <cs50.h>

int main(void){

    float change = 0.00;

    printf("How much change is owed? ");
    change = GetFloat();

    float quarters = change/.25;
    change-= (int)quarters*.25;

    float dimes = change/.10;
    change-= (int)dimes*.10;

    float nickels = change/.05;
    change-= (int)nickels*.05;

    float pennies = (change+.005)/.01;
    change-=(int)pennies*.01;

    int total = (int)quarters+(int)dimes+(int)nickels+(int)pennies;

    printf("%d\n", total);

    return 0;
    }
4

3 回答 3

6

最接近的float4.20略小于该值(4.19999980926513671875,对于通常的 32 位 IEEE754 floats)。因此,从 16 个季度中减去 4 美元后,剩下的金额略小于 0.2。除以 0.1 得到的值略小于 2,所以你的nickels值是 1。同样的情况在你减去镍之后,值略小于 0.1,除以 0.05 得到的商略小于 2。

您应该仅将整数用于此类计算,以美分计算。

于 2012-10-29T19:55:25.307 回答
2

抛出浮点计算。这完全基于百分之一,所以只需使用整数除法/模数。永远不要依赖浮点数的完美准确性。

#include <stdio.h>
#include <cs50.h>

int main(void){

    float fchange = 0.00;
    int change = 0;

    printf("How much change is owed? ");
    fchange = GetFloat();

    change = (int)roundf(fchange*100.0);

    int quarters = change/25;
    change = change % 25;

    int dimes = change/10;
    change = change % 10;

    int nickels = change/5;
    change = change % 5;

    printf("%d quarters, %d dimes, %d nickels, %d pennies\n", quarters, dimes, nickels, change);

    return 0;
}
于 2012-10-29T20:01:10.640 回答
1

其他答案大部分都涵盖了:您应该在这里使用定点,而不是浮点。但是,从浮点输入到定点表示时,请小心正确舍入。这是我破解的一个简短版本,它应该适用于所有积极的输入:

#include <stdlib.h>
#include <stdio.h>
int main(int argc, char ** argv)
{
    float change = atof(argv[1]);
    int work = (int)(100*change+0.5);
    int quarters, dimes, nickels, pennies;
    quarters = work/25; work %= 25;
    dimes    = work/10; work %= 10;
    nickels  = work/5;  work %=  5;
    pennies  = work;
    printf("%.2f dollars = %d quarters, %d dimes, %d nickels and %d pennies: %d coins total\n",
    change, quarters, dimes, nickels, pennies, quarters+dimes+nickels+pennies);
    return 0;
 }

例如:

./change 4.20
4.20 dollars = 16 quarters, 2 dimes, 0 nickels and 0 pennies: 18 coins total
于 2012-10-29T20:10:45.553 回答