1

我有下面列出的脚本，我似乎无法解决这个问题。我正在尝试为我所在的 UNIX 类制作一个交互式登录脚本。我基本上是在构建一个命令以传递到useradd. 我在传递到命令行时发出的命令（在添加时sudo）按预期工作，但是当我尝试从我的脚本运行它时（它正在生成我复制/粘贴到命令行中的文本）它给了我一些错误...在这一点上，我不知道接下来要尝试什么来解决这个问题。

错误：

useradd -m --user-group jaredm2 #command that is attempting to run...
useradd: invalid option -- ' '
Usage: useradd [options] LOGIN
....rest of useradd error text....

脚本：

#!/bin/bash
#Add a new user

FINALCOMMAND="-m"

#import useradd defaults...
. /etc/default/useradd

#Check if running as root
if [ "$(id -u)" != "0" ]; then
    echo "This script must be ran as root"
    exit 1
fi

#Get the new users Name
#echo -n "Please enter the users First and Last Name and press [ENTER]: "
#read Name

#Get the new users username
echo "The username must be 4-20 characters."
echo -n "Please enter the users requested username and press [ENTER]: "
read USERNAME
while [ $(grep -c "^${USERNAME}:" /etc/passwd) -ge 1 ] || [ ${#USERNAME} -le 3 ] || [ ${#USERNAME} -ge 21 ]
do
    echo " "
    echo "Error: Username is in use or invalid.  Please select a different username."
    echo " "
    echo -n "Please enter the users requested username and press [ENTER]: "
    read USERNAME   
done #USERNAME will be valid from this point

#ASK about the default shell now
echo -n "Enter the new shell if you would like one (currently $SHELL) or leave blank for the default and press [ENTER]: "
read tempSHELL
if [ ${#tempSHELL} -ge 1 ]; then
    SHELL="$tempSHELL"
    FINALCOMMAND="$FINALCOMMAND ""-s $SHELL"
fi

#ASK about a different primary group
echo "Would you like to enter a non-default primary user group? Defaults to creating a new group that matches the username"
echo "Enter a new Primary Group or leave blank for the default and press [ENTER]: "
read newPrimaryGroup

if [ ${#newPrimaryGroup} -eq 0 ]; then
    FINALCOMMAND="$FINALCOMMAND --user-group"
else
    if [ $(grep -c "^${newPrimaryGroup}" /etc/group) -ge 1 ]; then
        FINALCOMMAND="$FINALCOMMAND -g $newPrimaryGroup"
    else
        echo "Invalid group specified reverting to default!"
        FINALCOMMAND="$FINALCOMMAND --user-group"
    fi
fi
useradd -m --user-group jaredm2
#ASK about additional groups
echo "Would you like the new user to be a part of any additional groups?  Leave blank if no additional groups are needed or enter additional groups in the format of GROUP1,GROUP2,... (NO SPACES) and press [ENTER]: "
read extraGroups
#remove spaces if the user entered any
extraGroups="${extraGroups//[[:space:]]}"
FINALEXTRAGROUPS=""
IFS=","
for g in $extraGroups
do
    if [ $(grep -c "^${g}" /etc/group) -ge 1 ]; then
        FINALEXTRAGROUPS="$FINALEXTRAGROUPS,$g"
    else
        echo "$g is invalid user will not be added..."
    fi
done
FINALEXTRAGROUPS=$(echo "$FINALEXTRAGROUPS" | tail -c +2)
if [ ${#FINALEXTRAGROUPS} -ge 1 ]; then
    FINALCOMMAND="$FINALCOMMAND -G $FINALEXTRAGROUPS"
fi

#ASK about the home directory
echo "Would you like to enter a new home directory for the user?  Leave blank to use the default of $HOME/$USERNAME or enter your own and press [ENTER]: "
read NEWHOME

if [ ${#NEWHOME} -ge 1 ]; then
    FINALCOMMAND="$FINALCOMMAND -d $NEWHOME"
fi

#ADD the username to the command
FINALCOMMAND=`echo "$FINALCOMMAND $USERNAME" | sed 's/ *$//g' | sed 's/^ *//g'`
echo "useradd $FINALCOMMAND"
#PASSCOMMAND="sudo passwd $USERNAME"
#ADD THE USER
`useradd $FINALCOMMAND`

`passwd $USERNAME`

`chfn $USERNAME`

更新：添加调试内容

+ '[' 0 -ge 1 ']'
++ sed 's/^ *//g'
++ sed 's/ *$//g'
++ echo '/usr/sbin/useradd -m -U JaredM'
+ FINALCOMMAND='/usr/sbin/useradd -m -U JaredM'
++ '/usr/sbin/useradd -m -U JaredM'
./addnewuser.sh: line 89: /usr/sbin/useradd -m -U JaredM: No such file or directory
4

5 回答 5

2

如果man -s8 useradd未提及--user-group可用的选项，-U则将不起作用。还有另一个值得尝试的解决方案：

默认行为（如果未指定 -g、-N 和 -U 选项）由 /etc/login.defs 中的 USERGROUPS_ENAB 变量定义。

另一种方法是，您必须将useradd命令与groupadd具有相同用户名的命令链接起来，作为两个命令的参数。

编辑： 这必须有效。首先创建组，然后创建用户并将这个新用户添加到组中。因为，您是在脚本中执行此操作的，所以应该可以很好地完成这项工作。

做这个：

groupadd jaredm2
useradd -m -g jaredm2 jaredm2

而不是这个：

useradd -m --user-group jaredm2

请注意，某些已安装在您的操作系统中的其他程序可能已经更改了您的二进制文件或对其的访问权限，甚至为它创建了别名。您的which输出表明它链接到useraddbin 目录中的二进制文件，正是它应该在的位置。

所以我猜：

  • 二进制文件可能已被进程、软件包安装程序或其他东西更改或替换
  • 二进制版本和手册页版本之间存在一些不匹配（很可能是您在某个时间点不正确地升级了操作系统）

我认为，唯一的解决方案是使用上述命令对或useradd手动更改您正在使用的二进制文件。

于 2012-10-25T06:22:39.390 回答
2

问题是由您的脚本引起的，您使用魔术引号`...`来执行您的 shell 命令。

仅当您要将命令的返回存储在变量中时才应使用这些引号：例如以下指令：

FINALCOMMAND=`echo "$FINALCOMMAND $USERNAME" | sed 's/ *$//g' | sed 's/^ *//g'`

否则没有必要使用这个引用，它们会产生像你这样的错误。

你可以把你的脚本：

useradd $FINALCOMMAND
passwd $USERNAME
chfn $USERNAME

代替：

`useradd $FINALCOMMAND`
`passwd $USERNAME`
`chfn $USERNAME`
于 2012-10-30T13:40:46.117 回答
2

通过使用数组，您可以防止命令行中出现与 IFS 相关的错误，并且更加简洁。这个已经测试过了。我也对代码进行了一些清理。

#!/bin/bash

#Add a new user

FINALCOMMAND=("-m")

#Import useradd defaults...
. /etc/default/useradd

#Check if running as root
if [ "$(id -u)" != "0" ]; then
    echo "This script must be ran as root"
    exit 1
fi

#Get the new users Name
#echo -n "Please enter the users First and Last Name and press [ENTER]: "
#read Name

#Get the new users username
echo "The username must be 4-20 characters."
echo -n "Please enter the users requested username and press [ENTER]: "
read USERNAME
while [ $(grep -c "^${USERNAME}:" /etc/passwd) -ge 1 ] || [ ${#USERNAME} -le 3 ] || [ ${#USERNAME} -ge 21 ]; do
    echo " "
    echo "Error: Username is in use or invalid.  Please select a different username."
    echo " "
    echo -n "Please enter the users requested username and press [ENTER]: "
    read USERNAME
done #USERNAME will be valid from this point

#ASK about the default shell now
echo -n "Enter the new shell if you would like one (currently $SHELL) or leave blank for the default and press [ENTER]: "
read tempSHELL
if [ ${#tempSHELL} -ge 1 ]; then
    SHELL="$tempSHELL"
    FINALCOMMAND=("${FINALCOMMAND[@]}" "-s" "$SHELL")
fi

#ASK about a different primary group
echo "Would you like to enter a non-default primary user group? Defaults to creating a new group that matches the username"
echo -n "Enter a new Primary Group or leave blank for the default and press [ENTER]: "
read newPrimaryGroup

if [ ${#newPrimaryGroup} -eq 0 ]; then
    FINALCOMMAND=("${FINALCOMMAND[@]}" "--user-group")
else
    if [ $(grep -c "^${newPrimaryGroup}" /etc/group) -ge 1 ]; then
        FINALCOMMAND=("${FINALCOMMAND[@]}" "-g" "$newPrimaryGroup")
    else
        echo "Invalid group specified reverting to default!"
        FINALCOMMAND=("${FINALCOMMAND[@]}" "--user-group")
    fi
fi

#ASK about additional groups
echo -n "Would you like the new user to be a part of any additional groups?  Leave blank if no additional groups are needed or enter additional groups in the format of GROUP1,GROUP2,... (NO SPACES) and press [ENTER]: "
read extraGroups
#remove spaces if the user entered any
extraGroups="${extraGroups//[[:space:]]}"
FINALEXTRAGROUPS=''
IFS=, read -a TEMP <<< "$extraGroups"
for g in "${TEMP[@]}"; do
    if [ $(grep -c "^${g}" /etc/group) -ge 1 ]; then
        FINALEXTRAGROUPS="$FINALEXTRAGROUPS,$g"
    else
        echo "$g is invalid user will not be added..."
    fi
done

if [ ${#FINALEXTRAGROUPS[@]} -ge 1 ]; then
    FINALCOMMAND=("${FINALCOMMAND[@]}" "-G" "${FINALEXTRAGROUPS:1}")
fi


#ASK about the home directory
echo -n "Would you like to enter a new home directory for the user?  Leave blank to use the default of $HOME/$USERNAME or enter your own and press [ENTER]: "
read NEWHOME

if [ ${#NEWHOME} -ge 1 ]; then
    FINALCOMMAND=("${FINALCOMMAND[@]}" "-d" "$NEWHOME")
fi

#ADD the username to the command
FINALCOMMAND=("${FINALCOMMAND[@]}" "$USERNAME")

#PASSCOMMAND="sudo passwd $USERNAME"

#ADD THE USER
echo "useradd ${FINALCOMMAND[@]}"

useradd "${FINALCOMMAND[@]}"

passwd "$USERNAME"

chfn "$USERNAME"

注意：在较新版本的 bash 中，您可以使用 += 将值附加到数组中，例如 ARRAY+=("value")

另外根据我的其他偏好，我会以这种方式进一步改进代码，但这还不是最好的：

#!/bin/bash

shopt -s extglob

# Check if running as root.
if [[ "$(id -u)" != 0 ]]; then
    echo "This script must be ran as root."
    exit 1
fi

# Initialize useradd command variable.
USERADDCOMMAND=("useradd" "-m")

# Import useradd defaults.
. /etc/default/useradd

# Get the new user's name.
#echo -n "Please enter the users First and Last Name and press [ENTER]: "
#read NAME

# Get the new users username.
echo "The username must be 4-20 characters."
while :; do
    read -p "Please enter the user's requested username and press [ENTER]: " USERNAME
    [[ ${#USERNAME} -ge 4 && ${#USERNAME} -le 20 && $USERNAME == +([[:alpha:]])*([[:alnum:]_-]) ]] || {
        echo "Error: Username is invalid. Please enter a different username."
        continue
    }
    [[ $(grep -c "^${USERNAME}:" /etc/passwd) -ge 1 ]] && {
        echo "Error: Username is in use. Please enter a different username."
        continue
    }
    break
done

# Ask about the default shell.
read -p "Enter the new shell if you would like one (currently $SHELL) or leave blank for the default and press [ENTER]: " SHELL_
if [[ ${#SHELL_} -ge 1 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-s" "$SHELL_")
else
    # We use this if we really are to use SHELL specified in $SHELL but it still needs further workarounds like checking if $SHELL is valid. Those could be easily done but it depends if this one's really necessary.
    #USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-s" "$SHELL")
    :
fi

# Ask about a different primary group.
echo "Would you like to enter a non-default primary user group? Defaults to creating a new group that matches the username."
echo -n "Enter a new Primary Group or leave blank for the default and press [ENTER]: "
read NEWPRIMARYGROUP

if [[ ${#NEWPRIMARYGROUP} -eq 0 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "--user-group")
else
    if [[ $(grep -c "^${NEWPRIMARYGROUP}" /etc/group) -ge 1 ]]; then
        USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-g" "$NEWPRIMARYGROUP")
    else
        echo "Invalid group specified reverting to default!"
        USERADDCOMMAND=("${USERADDCOMMAND[@]}" "--user-group")
    fi
fi

# Ask about additional groups.
echo -n "Would you like the new user to be a part of any additional groups?  Leave blank if no additional groups are needed or enter additional groups in the format of GROUP1,GROUP2,... (NO SPACES) and press [ENTER]: "
read EXTRAGROUPS
# Remove spaces if the user entered any.
EXTRAGROUPS="${EXTRAGROUPS//[[:space:]]}"
FINALEXTRAGROUPS=''
IFS=, read -a TEMP <<< "$EXTRAGROUPS"
for G in "${TEMP[@]}"; do
    if [[ $(grep -c "^${g}" /etc/group) -ge 1 ]]; then
        FINALEXTRAGROUPS="$FINALEXTRAGROUPS,$G"
    else
        echo "$G is an invalid user and will not be added."
    fi
done
if [[ ${#FINALEXTRAGROUPS[@]} -ge 1 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-G" "${FINALEXTRAGROUPS:1}")
fi

# Ask about the home directory
read -p "Would you like to enter a new home directory for the user?  Leave blank to use the default of $HOME/$USERNAME or enter your own and press [ENTER]: " NEWHOME
if [[ ${#NEWHOME} -ge 1 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-d" "$NEWHOME")
fi

# Add the username to the command
USERADDCOMMAND=("${USERADDCOMMAND[@]}" "$USERNAME")

# Add THE USER
echo "> ${USERADDCOMMAND[*]}"
"${USERADDCOMMAND[@]}"

echo "> passwd $USERNAME"
passwd "$USERNAME"

echo "> chfn $USERNAME"
chfn "$USERNAME"  # -f "$NAME"
于 2012-11-03T17:10:00.780 回答
1

从您对调试内容的更新来看，您所做的似乎与您发布的脚本不同。

无论如何，从调试输出中，我怀疑您正在尝试使用双引号运行 adduser 命令

"$FINALCOMMAND"

或者也可能包含在反引号中，因为这似乎是触发“没有这样的文件或目录”错误消息的唯一情况。

摆脱双引号应该可以解决问题。

p/s：除非您实际使用输出（例如用于测试或分配给变量），否则不要使用命令替换（``），否则可能会发生类似的事情

$ `echo Just saying hi`
Just: command not found
于 2012-10-30T13:00:14.873 回答
0

我修复了您脚本中的错误，只需删除 IFS=","

这是对环境变量 IFS（内部字段分隔符）的误用

脚本变为：

#!/bin/bash
#Add a new user

FINALCOMMAND="-m"

#import useradd defaults...
. /etc/default/useradd

#Check if running as root
if [ "$(id -u)" != "0" ]; then
    echo "This script must be ran as root"
    exit 1
fi

#Get the new users Name
#echo -n "Please enter the users First and Last Name and press [ENTER]: "
#read Name

#Get the new users username
echo "The username must be 4-20 characters."
echo -n "Please enter the users requested username and press [ENTER]: "
read USERNAME
while [ $(grep -c "^${USERNAME}:" /etc/passwd) -ge 1 ] || [ ${#USERNAME} -le 3 ] || [ ${#USERNAME} -ge 21 ]
do
    echo " "
    echo "Error: Username is in use or invalid.  Please select a different username."
    echo " "
    echo -n "Please enter the users requested username and press [ENTER]: "
    read USERNAME   
done #USERNAME will be valid from this point

#ASK about the default shell now
echo -n "Enter the new shell if you would like one (currently $SHELL) or leave blank for the default and press [ENTER]: "
read tempSHELL
if [ ${#tempSHELL} -ge 1 ]; then
    SHELL="$tempSHELL"
    FINALCOMMAND="$FINALCOMMAND ""-s $SHELL"
fi

#ASK about a different primary group
echo "Would you like to enter a non-default primary user group? Defaults to creating a new group that matches the username"
echo "Enter a new Primary Group or leave blank for the default and press [ENTER]: "
read newPrimaryGroup

if [ ${#newPrimaryGroup} -eq 0 ]; then
    FINALCOMMAND="$FINALCOMMAND --user-group"
else
    if [ $(grep -c "^${newPrimaryGroup}" /etc/group) -ge 1 ]; then
        FINALCOMMAND="$FINALCOMMAND -g $newPrimaryGroup"
    else
        echo "Invalid group specified reverting to default!"
        FINALCOMMAND="$FINALCOMMAND --user-group"
    fi
fi
#useradd -m --user-group jaredm2
#ASK about additional groups
echo "Would you like the new user to be a part of any additional groups?  Leave blank if no additional groups are needed or enter additional groups in the format of GROUP1,GROUP2,... (NO SPACES) and press [ENTER]: "
read extraGroups
#remove spaces if the user entered any
extraGroups="${extraGroups//[[:space:]]}"
FINALEXTRAGROUPS=""
#IFS=","
for g in $extraGroups
do
    if [ $(grep -c "^${g}" /etc/group) -ge 1 ]; then
        FINALEXTRAGROUPS="$FINALEXTRAGROUPS,$g"
    else
        echo "$g is invalid user will not be added..."
    fi
done
FINALEXTRAGROUPS=$(echo "$FINALEXTRAGROUPS" | tail -c +2)
if [ ${#FINALEXTRAGROUPS} -ge 1 ]; then
    FINALCOMMAND="$FINALCOMMAND -G $FINALEXTRAGROUPS"
fi

#ASK about the home directory
echo "Would you like to enter a new home directory for the user?  Leave blank to use the default of $HOME/$USERNAME or enter your own and press [ENTER]: "
read NEWHOME

if [ ${#NEWHOME} -ge 1 ]; then
    FINALCOMMAND="$FINALCOMMAND -d $NEWHOME"
fi

#ADD the username to the command
FINALCOMMAND=`echo "$FINALCOMMAND $USERNAME" | sed 's/ *$//g' | sed 's/^ *//g'`
echo "useradd $FINALCOMMAND"
#PASSCOMMAND="sudo passwd $USERNAME"
#ADD THE USER
useradd $FINALCOMMAND

passwd $USERNAME

chfn $USERNAME
于 2012-11-02T15:14:16.100 回答