2

我目前正在使用节点制作一个链接列表程序（我不知道任何其他方式），我遇到了一个关于创建深层副本并使用 ~List() 摆脱所有节点和哨兵的问题。删除节点不是问题，但哨兵是因为第一个没有分配索引值。

List::~List()
{
  for(size_t i=0; i<size; i++)
    {
      _setCurrentIndex(i);
      if(current && curent->next == NULL)
    {
      Node *temp = current->next;
      delete temp;
      delete current;
    }
      else
    {
      Node *old = current;
      current = current->next;
      delete old;
    }
    }
}

List::List(const List & orig)
{
for(size_t i=0; i<size; i++)
{
 if(i==0)
  {
   Node *copyFront = new Node; //the first sentinel
   copyFront->data = orig.front->data; //front is defined in private in list.h
   copyFront->prev = NULL; // it is defined as a Node (same for rear)
  }
 else if(0<=i && i<size) //put in i<size b/c 0<=i would always be true
  {
   _setCurrentIndex(i) //sets what current is and currentIndex which pts to diff Nodes
   Node *copy = new Node;
   copy->data = current->data; 
   copy->next = current->next;
   current = current->next;
  }
 else if(i+1 == size)
  {
   Node *copyRear = new Node; //making the last sentinel, but it has to be
   copyRear->data = orig.rear->data; //after data Node
   copyRear->next = NULL;
  }
 }
}

我正在寻求有关此代码的建议和评论，以了解下一步如何进行，或者如果出现严重错误，应该进行哪些更改！

4

1 回答 1

0

Linked lists are templates allowing any type of variable to sit in them. In my honest opinion, you'd be best off using the std::list which requires the #include <list> header file.

Of course, if you really want the experience of writing a linked list class yourself then the following code makes a deep copy of a list:

List::List( const List& other) {
    if( other.head_ != nullptr) {
        head_ = new Node( other.head_->item_);  // copy first node

        assert( head_ != nullptr);  // ensure that the memory was allocated correctly

        // copy the rest of the list
        Node* pnew = head_;
        // loop through the list until you reach the end (i.e. a node that's nullptr)
        for( Node* porig( other.head_->next_); porig != nullptr; porig = porig->next_) {
            // assign the next node in the destination list to the next node in the paramter's list
            pnew->next_ = new Node( porig->item_);
            assert( pnew->next_ != nullptr);  // ensure that the memory was allocated correctly
            pnew = pnew->next_;  // move onto the newly created node in the destination list
        }
    }
    else
        // if the parameter is empty then the destination list will be empty as well
        head_ = nullptr;
}

As for the destructor, you just need to run through the list deleting the nodes as you go:

List::~List() {
    while( head_ != nullptr) {  // keep looping until the list gets to the end
        // make a second pointer to the node you are about to delete (so you don't lose track of it)
        Node* pn( head_);
        // move the head_ onto the next node essentially "removing" the first node from your list
        head_ = head_->next_;
        // delete the node that you've just "removed" from your list
        delete pn;
    }
}

I've tried to make the comments clear up anything that might be unclear.

于 2012-10-26T18:01:33.533 回答