0

我试过这段代码（相关部分..）：

    private EditText weightEditText,heightEditText;

    weightEditText = (EditText)findViewById(R.id.weightEditText); 
    heightEditText = (EditText)findViewById(R.id.heightEditText);

    public void onClick(View v) {
        switch (v.getId()){
        case R.id.clear: clearFields();toastClearingMessage(); break;
        case R.id.goButton: runGoButton(); break;
        }//switch
    }

    private void runGoButton() {
        if (heightWeightFieldsValuesGood() && heightWeightFieldsNotEmpty() )
            runCalculations();
        else
            toastMessageReEnterValues();
    }

    private boolean heightWeightFieldsValuesGood() {
        if (getWeight()>0 && getHeight()>0)
            return true;
        return false;
    }

    private boolean heightWeightFieldsNotEmpty(){
        if ( (weightEditText.getText().toString().trim().equals("")) || (heightEditText.getText().toString().trim().equals("")) )
            return false;
        return true;
    }
    private float getHeight() {
        return Float.parseFloat(heightEditText.getText().toString());
    }

    private float getWeight() {
        return Float.parseFloat(weightEditText.getText().toString());
    }

崩溃日志：

10-08 01:21:54.260: W/dalvikvm(8172): threadid=1: thread exiting with uncaught exception (group=0x40020ac0)
10-08 01:21:54.260: E/AndroidRuntime(8172): FATAL EXCEPTION: main
10-08 01:21:54.260: E/AndroidRuntime(8172): java.lang.NumberFormatException: 
10-08 01:21:54.260: E/AndroidRuntime(8172):     at org.apache.harmony.luni.util.FloatingPointParser.parseFloat(FloatingPointParser.java:305)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at java.lang.Float.parseFloat(Float.java:291)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at com.example.bmi.calculator.MainPage.getWeight(MainPage.java:122)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at com.example.bmi.calculator.MainPage.heightWeightFieldsValuesGood(MainPage.java:75)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at com.example.bmi.calculator.MainPage.runGoButton(MainPage.java:63)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at com.example.bmi.calculator.MainPage.onClick(MainPage.java:58)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at android.view.View.performClick(View.java:2420)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at android.view.View$PerformClick.run(View.java:8941)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at android.os.Handler.handleCallback(Handler.java:587)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at android.os.Handler.dispatchMessage(Handler.java:92)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at android.os.Looper.loop(Looper.java:123)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at android.app.ActivityThread.main(ActivityThread.java:4627)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at java.lang.reflect.Method.invokeNative(Native Method)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at java.lang.reflect.Method.invoke(Method.java:521)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:860)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
10-08 01:21:54.260: E/AndroidRuntime(8172):     at dalvik.system.NativeStart.main(Native Method)

一切都运行得很好，但是如果我单击 GO 按钮而不插入任何字段值，程序就会崩溃并关闭......虽然我使用的是 trim() 方法......

顺便说一句，如果我在两个字段中输入零值，它工作正常（适当的 Toast 消息）有什么想法吗？...谢谢！:-(

4

3 回答 3

1

您使用 toString() 错误，您应该在 editText 的 getText() 方法上调用它，而不是在编辑文本本身上调用它

另外，您应该与“”进行比较，而不是与“”

在这种情况下， trim() 是 uneccesary

应该是这样的：

weightEditText.getText().toString().equals("") ...

<<<<<< 编辑>>>>>>>>

   private boolean heightWeightFieldsNotEmpty(){
    if ( (weightEditText.getText().toString().equals("")) || (heightEditText.getText().toString().equals("")) )
        return false;
    return true;
}

<<<<<<< 编辑 2 >>>>>>>>>

    if (heightWeightFieldsNotEmpty() && heightWeightFieldsValuesGood())


  private float getHeight(){
        Float from_value;
        try{
            from_value = Float.parseFloat(heightEditText.getText().toString());
        } catch (NumberFormatException ex){
            from_value = 0.0f;
        }

        return from_value;
    }
于 2012-10-07T22:49:08.670 回答
1

您可能可以使用TextUtils简化一些代码。

private boolean heightWeightFieldsNotEmpty(){
        if (TextUtils.isEmpty(weightEditText.getText()) || TextUtils.isEmpty(heightEditText.getText() )) {
            return false;
        }
        return true;
 }

然后在你的runGoButton()方法中：

private void runGoButton() {
        // Reverse these since you need to check for empty first.
        if (heightWeightFieldsNotEmpty() && heightWeightFieldsValuesGood())
            runCalculations();
        else
            toastMessageReEnterValues();
}
于 2012-10-07T23:39:31.180 回答
0

一个空字符串，如果修剪，将不等于包含空格字符的字符串 - 从两个相等检查中删除空格

此外，在尝试将值转换为数字之前，您应该检查字段是否为空。即你的支票应该是：

if (heightWeightFieldsNotEmpty() && heightWeightFieldsValuesGood())

注意：我还去掉了多余的==true，因为它们不是正确性所必需的，并且它们没有增加代码的易读性。通过将“notEmpty”测试放在首位，如果失败，代码将不会尝试运行“valuesGood”测试，从而避免对空字符串进行数字测试

于 2012-10-07T22:46:40.870 回答