c++ - DoubleLinkedList 删除错误

Question

我正在制作一个双重链接列表。该错误与我的 Remove 方法有关。我想不通。有人知道吗？

这是哪里的错误？

错误 1 ​​错误 C2027：使用未定义类型 'DoublyListNode' c:\users\conor\documents\college\c++\projects\repeat - doublylinkedlist\repeat - doublylinkedlist\doublylinkedlist.h 230 1 重复 - DoublyLinkedList

// -------------------------------------------------------------------------------------------------------
//  Name:           Remove
//  Description:    Removes the node that the iterator points to, moves iterator forward to the next node.
//  Arguments:      p_iterator: The iterator to remove
//                  isForward: Tells which direction the iterator was going through the list
//  Return Value:   None.
// -------------------------------------------------------------------------------------------------------
void Remove(DoublyListIterator<Datatype>& m_itr)
{
    DoublyListNode<Datatype>* node = m_head;
    // if the iteratordoesn’t belong to this list, do nothing.
    if (m_itr.m_list != this)
        return;
    // if node is invalid, do nothing.
    if (m_itr.m_node == 0)
        return;
    if (m_itr.m_node == m_head)
    {
        // move the iteratorforward and delete the head.
        m_itr.Forth();
        RemoveHead();
        m_size--;
    }
    else
    {
        // scan forward through the list until you find
        // the node prior to the node you want to remove
        while (node->m_next != m_itr.m_node)
            node = node->m_next;
        // move the iterator forward.
        m_itr.Forth();
        // if the node you are deleting is the tail,
        // update the tail node.
        if (node->m_next == m_tail)
        {
            m_tail = node;
        }
        // delete the node.
        delete node->m_next;
        // re-link the list.
        node->m_next = m_itr.m_node;
        m_size--;
    }
}

如果需要更多代码，请询问。我不想在 Stack 溢出用户身上放很多代码。

Answer 1

The problem was a typo of the class DoublyListNode. The class was names DLNode. So this gave the error being discussed above.

Answer 2

您正在检查尾节点，但不检查头和尾之间的节点。甚至在将节点链接到下一个成员之前，您就通过删除节点来破坏链。

让我们分析一下：-

while (node->m_next != m_itr.m_node)
            node = node->m_next;

在循环node->m_next点之后m_itr.m_node

    delete node->m_next;
    // re-link the list.
    node->m_next = m_itr.m_node;

您正在分配一个已删除的节点！！！！

更改代码：-

node->m_next = m_itr.m_node;
delete m_itr;