0

我正在尝试创建一个执行井字游戏的程序。我已经完成了所有方法的创建,我只需要创建驱动程序。在创建驱动程序之前,我尝试只打印电路板和一个字符,但我认为我的方法不正确。这是我的错误的样子:

java.lang.ArrayIndexOutOfBoundsException: 3
at TicTacToeBoard.move(TicTacToeBoard.java:75)
at TicTacToe.main(TicTacToe.java:24)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at edu.rice.cs.drjava.model.compiler.JavacCompiler.runCommand(JavacCompiler.java:271)

这是我的两个程序:

这是我似乎无法完成的驱动程序。最后要显示的是模板,以便您了解每个程序的工作原理。

class TicTacToe
{
 public static void main(String [] args)
 { 
  //System.out.println("Welcome! Tic-Tac-Toe is a two player game.");
  //System.out.println("Enter player one's name: ");

  TicTacToeBoard game = new TicTacToeBoard();
  System.out.println(game.toString());

  //int count = 0;


  game.move('x', 1, 3); 
  // game.move('o', 1, 1);

  /* while (game.gameWon() !true || count != 9)
     {
      System.out.print(game.move()); 
      System.out.print(game.isEmpty()); 
      }*/   
     }
    }

这是所有方法的所在......

class TicTacToeBoard
{
 private char [][] board = new char[3][3];
 String b;

 // This a new constructor that creates a tic-tac-toe board
 public TicTacToeBoard()
 {
  for (int rows = 0; rows < board.length; rows++)// creates rows
  {
   for (int columns = 0; columns <board[rows].length;columns++)// creates columns
   {
    //System.out.println("| ");
     board[rows][columns] = ' ';
    //System.out.println(" |\n" );
    }
   }
 }

  // creates a string form of the tic-tac-toe board and allows the user
  // to access it during the game.
  public String toString()
  {
   String b = "";

   // creates a vertical bar at the beginning and the end of each row
   for (int rows = 0; rows < board.length; rows++)
   {
     b += "| ";
     // adds a space for each row and column character in tic-tac-toe board.
     for (int columns = 0; columns < board[rows].length; columns++)
     {
      b += board[rows][columns] + " ";  
      }
       b += "|\n";// prints a | space space space | and breaks off to create two new lines.
      }
       return b; // prints the tic-tac-toe board to be accessed by the user.
     }

String move(char x, int rows, int columns)
{ 
 String b = "";

 // creates a vertical bar at the beginning and the end of each row
 for (int r = 0; r < board.length; r++)
 {
   b += "| ";

  for (int c = 0; c < board[r].length; c++)
  {
   b += board[r][c] + " ";  //prints 3 spaces on each line. 
    // prints string character from user input if row and column not equal to zero 
   if (board[rows - 1][columns - 1] >= 0 && board[rows - 1][columns - 1] <= 2 )
   {
    board[rows - 1][columns - 1] = x;// prints character in the specified index from user input 
    b += board[rows - 1][columns - 1];// prints out the board and the new character in specified space.
     } 
      else if (board[rows - 1][columns - 1] < 0)   // makes user pick another choice
      return "ILLEGAL MOVE, TRY AGAIN!"; 
      // adds a space for each row and column character in tic-tac-toe board.
     }
      b += "|\n";// prints a | space space space | and breaks off to create two new lines.
    }  
     return b; // prints the tic-tac-toe board to be accessed by the user.

   }

  // checks if a space character is empty
  void isEmpty(char x, int row, int col)
  {
   if (board [row - 1][col - 1] == ' ')
    board[row - 1][col - 1] = x;
   else // makes user pick another row and column if space character is not empty
   System.out.println("ILLEGAL CHOICE, PICK AGAIN!");
   }
  // checks if game is won   
 public boolean gameWon(int row, int col)
 {  
  if ((board[2][0] == board[1][1]) && (board[2][0] == board[0][2]))
   return true;
  else if ((board[2][0] != board[1][1]) && (board[2][0] != board[0][2]))
   return false;   

  if ((board[2][2] == board[1][1])&& (board[2][2] == board[0][0]))
   return true;
  else if ((board[2][2] != board[1][1])&& (board[2][2] != board[0][0]))
   return false;   

  if ((board[0][0] == board[1][0]) && (board[0][0] == board[2][0]))
   return true;
  else if ((board[0][0] != board[1][0]) && (board[0][0] != board[2][0]))
   return false;        

  if ((board[0][1] == board[1][1]) && (board[0][1] == board[2][1]))
   return true;
  else if ((board[0][1] != board[1][1]) && (board[0][1] != board[2][1]))
   return false;        

  if ((board[0][2] == board[1][2]) && (board[0][2] == board[2][2]))
   return true;
  else if ((board[0][2] != board[1][2]) && (board[0][2] != board[2][2]))
   return false;   

  if ((board[0][0] == board[0][1]) && (board[0][0] == board[0][2]))
   return true;
  else if ((board[0][0] != board[0][1]) && (board[0][0] != board[0][2]))
   return false;   

  if ((board[1][0] == board[1][1]) && (board[1][0] == board[1][2]))
   return true;
  else if ((board[1][0] != board[1][1]) && (board[1][0] != board[1][2]))
   return false;     

  if ((board[2][0] == board[2][1]) && (board[2][0] == board[2][2]))
   return true;
  else 
   return false;
 }
}

这是整个事情的模板!!!!!!!

class TicTacToe
{
  public static void main (String [] args)
  {
       TicTacToeBoard b = new TicTacToeBoard();

       while (game not over)
       {
            swtich player
            increment turn counter

            until user enters a valid move    
            {
                  prompt for move
             }

            make move
            b.makeMove (player, row, col);

            print board    
            System.out.println(b);
       }

       print outcome
  }
 }


 class TicTacToeBoard
 {
   private char [][] board = ...;

   public TicTacToeBoard()
   {
      initialize board with spaces
    }

   public void makeMove (char c, int row, int col)
   {
        store symbol in specified position
    }

   public boolean isEmpty(int row, int col)
   {
        return true if square is unfilled
    }

   public boolean gameWon()
   {
        check board for a win
    }

   public String toString ()
   {
        return String representation of board
    }

 }
4

1 回答 1

4

编程语言对错误是无情的,并迫使我们严格和关心。

您的代码对我们来说很难阅读,因此我们和您都很难调试,从到处都是缩进开始,但也有粗心的错误,尤其是这个:

for (int r = 0; r < board.length; rows++)

你知道这里有什么问题吗?r与 不同rows,您不能将一个用作循环的索引,然后再递增另一个。您在循环内使用这两个变量。代码中还有其他几个粗心的错误。

我建议您重新开始,但要更加小心您的代码,尤其要小心缩进。如果您没有正确排列花括号,您将看不到一个代码块何时结束而另一个代码块何时开始(我们也不会!)。

哦,下一次,请让我们知道您的代码的哪些行导致了您的错误。如果我们不必猜测这些信息,那么为您提供帮助会容易得多。

编辑
您的新代码缩进更好一些,但仍然关闭。这就是你所拥有的:

String move(char x, int rows, int columns)
{ 
 String b = "";

 // creates a vertical bar at the beginning and the end of each row
 for (int r = 0; r < board.length; r++)
 {
   b += "| ";

  for (int c = 0; c < board[r].length; c++)
  {     
   b += board[rows][columns] + " ";  

这就是我推荐的:

String move(char x, int rows, int columns) {
  String b = "";

  // creates a vertical bar at the beginning and the end of each row
  for (int r = 0; r < board.length; r++) {
     b += "| ";

     for (int c = 0; c < board[r].length; c++) {

        // let's check to see what the variables hold!
        System.out.printf("rows: %d, columns %d, r: %d, c: %d%n", rows, columns, r, c); 
        b += board[rows][columns] + " "; // **** the offending line ****

更重要的是,请注意 printf 语句的结果,紧随其后的是异常:

rows: 1, columns 3, r: 0, c: 0
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 3

所以这里是列变量,它保存值 3 并导致你的数组爆炸。您需要回溯以查看如何调用此方法以及为什么将 3 传递到列参数中。

编辑 2
在重新查看您的最新帖子时,您仍在对移动方法进行硬编码以接受 3 作为列参数:

game.move('x', 1, 3);

首先要解决这个问题。该参数不能为 3。

于 2012-08-19T03:39:54.080 回答