5

Why does it happen? The code works and generates no warnings with GCC 4.7 on Linux and MSVC++ 2010 on Windows. Yet, on ideone.com it crashes with SIGILL. Is undefined behavior involved here?

#include <iostream>
#include <cstdarg>

using namespace std;

enum types
{
    INT,
    DOUBLE,
    CHAR,
    STRING
};

struct mt
{
    types type;

    union
    {
        int         i;
        double      d;
        char        c;
        const char *s;
    } val;

    mt(int i)
        : type(INT)
    {
        val.i = i;
    }

    mt(double d)
        : type(DOUBLE)
    {
        val.d = d;
    }

    mt(char c)
        : type(CHAR)
    {
        val.c = c;
    }

    mt(const char *s)
        : type(STRING)
    {
        val.s = s;
    }
};

void print(int n, ...)
{
    va_list ap;

    va_start(ap, n);

    for (int i = 0; i < n; i++)
    {
        mt x(va_arg(ap, mt));

        switch (x.type)
        {
        case INT:
            cout << x.val.i << endl;
            break;
        case DOUBLE:
            cout << x.val.d << endl;
            break;
        case CHAR:
            cout << x.val.c << endl;
            break;
        case STRING:
            cout << x.val.s << endl;
            break;
        }
    }

    va_end(ap);
}

int main()
{
    print(4, mt(2), mt(4.2), mt('a'), mt("Hello"));
}
4

1 回答 1

1

GCC 4.4.6 出现错误：

test.cpp: In function ‘void print(int, ...)’:
test.cpp:59: warning: cannot receive objects of non-POD type ‘struct mt’ through ‘...’; call will abort at runtime
test.cpp: In function ‘int main()’:
test.cpp:83: warning: cannot pass objects of non-POD type ‘struct mt’ through ‘...’; call will abort at runtime
test.cpp:83: warning: cannot pass objects of non-POD type ‘struct mt’ through ‘...’; call will abort at runtime
test.cpp:83: warning: cannot pass objects of non-POD type ‘struct mt’ through ‘...’; call will abort at runtime
test.cpp:83: warning: cannot pass objects of non-POD type ‘struct mt’ through ‘...’; call will abort at runtime
$ g++ --version
g++ (GCC) 4.4.6 20110731 (Red Hat 4.4.6-3)

您不能通过structvarargs 函数参数传递 s，而是传递指针：

void print(int n, ...)
{
    va_list ap;

    va_start(ap, n);

    for (int i = 0; i < n; i++)
    {
        mt *x(va_arg(ap, mt *));

        switch (x->type)
        {
        case INT:
            cout << x->val.i << endl;
            break;
        case DOUBLE:
            cout << x->val.d << endl;
            break;
        case CHAR:
            cout << x->val.c << endl;
            break;
        case STRING:
            cout << x->val.s << endl;
            break;
        }
    }

    va_end(ap);
}

int main()
{
    mt mt1(2);
    mt mt2(4.2);
    mt mt3('a');
    mt mt4("Hello");
    print(4, &mt1, &mt2, &mt3, &mt4);
}

在我的系统上运行良好：

$ ./a.out
2
4.2
a
Hello
于 2012-07-04T09:51:52.443 回答