我是 Rails 的新手。我正在使用服务层来保持我的控制器纤薄。我所有的服务层文件都位于app/services/domain, app/services/application, app/services/infrastructure. 例如这里是我的公司服务：
class CompanyService
def self.create(params)
company = Company.new(params)
rst = true
ActiveRecord::Base.transaction do
begin
company.save!
rescue ActiveRecord::RecordInvalid
rst = false
rescue ActiveRecord::StatementInvalid
rst = nil
end
end
return company, rst
end
def self.update(params)
company = get_company(params[:id])
rst = true
ActiveRecord::Base.transaction do
begin
company.old_category_ids = company.category_ids
company.assign_attributes(params[:company])
decrease_category_ids = company.old_category_ids-company.category_ids
decrease_counters(decrease_category_ids)
increase_category_ids = company.category_ids-company.old_category_ids
increase_counters(increase_category_ids)
company.save!
rescue ActiveRecord::RecordInvalid
rst = false
rescue ActiveRecord::StatementInvalid
rst = nil
end
end
return company, rst
end # end update
这是公司控制器：
def create
@company, rst = CompanyService.create(params[:company])
if rst == true
redirect_to(admin_companies_url, notice: "Company was successfully created.")
elsif rst == false
render active_admin_template('new.html.erb')
else
redirect_to admin_companies_url, notice: "Something went wrong. Please try again."
end
end
def update
@company, rst = CompanyService.update(params)
if rst
redirect_to admin_company_url(company), notice: "Company was successfully updated."
elsif rst == false
render active_admin_template('edit.html.erb')
elsif rst == nil
redirect_to admin_companies_url, notice: "Something went wrong. Please try again."
end
end
def destroy
CompanyService.destroy(params[:id])
redirect_to admin_companies_url
end
所以我有两个问题：
- 我知道我的控制器代码不好。如何改进它？
- 我的服务不会自动加载到生产和开发环境中。为什么？
抱歉英语不好。感谢您的每一个建议和帮助。