9

我刚刚完成了 Ruby on Rails 教程的第 10 章，添加了编辑/更新、索引和销毁用户的功能。我的应用程序中的一切似乎都正常工作，但是当我运行 RSpec 时，我的许多测试都失败了。

我的 users_controller_spec 设置与本书完全一样，我的应用程序代码也相同。一个问题可能是我使用的是 Rails 3.1.1，而不是他在书中使用的 Rails 3.0？对于以前的测试来说，这并不是一个真正的问题，只是偶尔会出现几行不同的代码。在我开始第 10.2.1 节后，这些问题开始出现。

这是我看到的错误列表，如果您需要更多信息，请告诉我。谢谢！

1) UsersController GET 'index' for signed-in users should be successful
 Failure/Error: response.should be_success
   expected success? to return true, got false
 # ./spec/controllers/users_controller_spec.rb:31:in `block (4 levels) in <top (required)>'

2) UsersController GET 'index' for signed-in users should have the right title
 Failure/Error: response.should have_selector("title", :content => "All users")
   expected following output to contain a <title>All users</title> tag:
   <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
   <html><body>You are being <a href="http://test.host/signin">redirected</a>.</body></html>
 # ./spec/controllers/users_controller_spec.rb:36:in `block (4 levels) in <top (required)>'

3) UsersController GET 'index' for signed-in users should have an element for each user
 Failure/Error: response.should have_selector("li", :content => user.name)
   expected following output to contain a <li>Richard Berger</li> tag:
   <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
   <html><body>You are being <a href="http://test.host/signin">redirected</a>.</body></html>
 # ./spec/controllers/users_controller_spec.rb:42:in `block (5 levels) in <top (required)>'
 # ./spec/controllers/users_controller_spec.rb:41:in `each'
 # ./spec/controllers/users_controller_spec.rb:41:in `block (4 levels) in <top (required)>'

4) UsersController GET 'index' for signed-in users should paginate users
 Failure/Error: response.should have_selector("div.pagination")
   expected following output to contain a <div.pagination/> tag:
   <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
   <html><body>You are being <a href="http://test.host/signin">redirected</a>.</body></html>
 # ./spec/controllers/users_controller_spec.rb:48:in `block (4 levels) in <top (required)>'

5) UsersController GET 'edit' should be successful
 Failure/Error: response.should be_success
   expected success? to return true, got false
 # ./spec/controllers/users_controller_spec.rb:184:in `block (3 levels) in <top (required)>'

6) UsersController GET 'edit' should have the right title
 Failure/Error: response.should have_selector("title", :content => "Edit user")
   expected following output to contain a <title>Edit user</title> tag:
   <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
   <html><body>You are being <a href="http://test.host/signin">redirected</a>.</body></html>
 # ./spec/controllers/users_controller_spec.rb:189:in `block (3 levels) in <top (required)>'

7) UsersController GET 'edit' should have a link to change the Gravatar
 Failure/Error: response.should have_selector("a", :href => gravatar_url, :content => "change")
   expected following output to contain a <a href='http://gravatar.com/emails'>change</a> tag:
   <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
   <html><body>You are being <a href="http://test.host/signin">redirected</a>.</body></html>
 # ./spec/controllers/users_controller_spec.rb:195:in `block (3 levels) in <top (required)>'

8) UsersController PUT 'update' failure should render the 'edit' page
 Failure/Error: response.should render_template('edit')
   expecting <"edit"> but rendering with <"">
 # ./spec/controllers/users_controller_spec.rb:214:in `block (4 levels) in <top (required)>'

9) UsersController PUT 'update' failure should have the right title
 Failure/Error: response.should have_selector("title", :content => "Edit user")
   expected following output to contain a <title>Edit user</title> tag:
   <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
   <html><body>You are being <a href="http://test.host/signin">redirected</a>.</body></html>
 # ./spec/controllers/users_controller_spec.rb:219:in `block (4 levels) in <top (required)>'

10) UsersController PUT 'update' success should change the user's attributes
 Failure/Error: @user.name.should  == @attr[:name]
   expected: "New Name"
        got: "Richard Berger" (using ==)
 # ./spec/controllers/users_controller_spec.rb:232:in `block (4 levels) in <top (required)>'

11) UsersController PUT 'update' success should redirect to the user show page
 Failure/Error: response.should redirect_to(user_path(@user))
   Expected response to be a redirect to <http://test.host/users/1> but was a redirect to <http://test.host/signin>
 # ./spec/controllers/users_controller_spec.rb:238:in `block (4 levels) in <top (required)>'

12) UsersController PUT 'update' success should have a flash message
 Failure/Error: flash[:success].should =~ /updated/
   expected: /updated/
        got: nil (using =~)
 # ./spec/controllers/users_controller_spec.rb:243:in `block (4 levels) in <top (required)>'

13) UsersController authentication of edit/update pages for signed-in users should require matching users for 'edit'
 Failure/Error: response.should redirect_to(root_path)
   Expected response to be a redirect to <http://test.host/> but was a redirect to <http://test.host/signin>
 # ./spec/controllers/users_controller_spec.rb:276:in `block (4 levels) in <top (required)>'

14) UsersController authentication of edit/update pages for signed-in users should require matching users for 'update'
 Failure/Error: response.should redirect_to(root_path)
   Expected response to be a redirect to <http://test.host/> but was a redirect to <http://test.host/signin>
 # ./spec/controllers/users_controller_spec.rb:281:in `block (4 levels) in <top (required)>'

15) UsersController DELETE 'destroy' as a non-admin user should protect the page
 Failure/Error: response.should redirect_to(root_path)
   Expected response to be a redirect to <http://test.host/> but was a redirect to <http://test.host/signin>
 # ./spec/controllers/users_controller_spec.rb:303:in `block (4 levels) in <top (required)>'

16) UsersController DELETE 'destroy' as an admin user should destroy the user
 Failure/Error: lambda do
   count should have been changed by -1, but was changed by 0
 # ./spec/controllers/users_controller_spec.rb:315:in `block (4 levels) in <top (required)>'

17) UsersController DELETE 'destroy' as an admin user should redirect to the users page
 Failure/Error: response.should redirect_to(users_path)
   Expected response to be a redirect to <http://test.host/users> but was a redirect to <http://test.host/signin>
 # ./spec/controllers/users_controller_spec.rb:322:in `block (4 levels) in <top (required)>'

更新：

我解决了 2 个错误，但大多数仍然存在。一个问题似乎是，当测试尝试“获取：index”时，由于重定向（到 /signin 页面），它没有找到正确的页面。我没有设置任何重定向（无论如何都是故意的），但也许有人知道这可能是如何发生的以及如何解决它？

更新#2：

根据@bkempner 的要求，这里是来自 users_controller_spec 和 users_controller 的相关代码（首先是 users_controller_spec）。很多代码，但很多错误......：

describe "for signed-in users" do

  before(:each) do
    @user = test_sign_in(Factory(:user))
    second = Factory(:user, :email => "another@example.com")
    third  = Factory(:user, :email => "another@example.net")

    @users = [@user, second, third]
    30.times do
      @users << Factory(:user, :email => Factory.next(:email))
    end
  end

  it "should be successful" do
    get :index
    response.should be_success
  end

  it "should have the right title" do
    get :index
    response.should have_selector("title", :content => "All users")
  end

  it "should have an element for each user" do
    get :index
    @users[0..2].each do |user|
      response.should have_selector("li", :content => user.name)
    end
  end

  it "should paginate users" do
    get :index
    response.should have_selector("div.pagination")
    response.should have_selector("span.diabled", :content => "Previous")
    response.should have_selector("a", :href => "/users?page=2", :content => "2")
    response.should have_selector("a", :href => "/users?page=2", :content => "Next")
  end
end

describe "GET 'edit'" do

  before(:each) do
    @user = Factory(:user)
    test_sign_in(@user)
  end

  it "should be successful" do
    get :edit, :id => @user
    response.should be_success
  end

  it "should have the right title" do
    get :edit, :id => @user
    response.should have_selector("title", :content => "Edit user")
  end

  it "should have a link to change the Gravatar" do
    get :edit, :id => @user
    gravatar_url = "http://gravatar.com/emails"
    response.should have_selector("a", :href => gravatar_url, :content => "change")
  end
end

describe "PUT 'update'" do

  before(:each) do
    @user = Factory(:user)
    test_sign_in(@user)
  end

  describe "failure" do

    before(:each) do
      @attr = { :email => "", :name => "", :password => "", :password_confirmation => "" }
    end

    it "should render the 'edit' page" do
      put :update, :id => @user, :user => @attr
      response.should render_template('edit')
    end

    it "should have the right title" do
      put :update, :id => @user, :user => @attr
      response.should have_selector("title", :content => "Edit user")
    end
  end

  describe "success" do

    before(:each) do
      @attr = { :name => "New Name", :email => "user@example.org", :password => "barbaz", :password_confirmation => "barbaz" }
    end

    it "should change the user's attributes" do
      put :update, :id => @user, :user => @attr
      @user.reload
      @user.name.should  == @attr[:name]
      @user.email.should == @attr[:email]
    end

    it "should redirect to the user show page" do
      put :update, :id => @user, :user => @attr
      response.should redirect_to(user_path(@user))
    end

    it "should have a flash message" do
      put :update, :id => @user, :user => @attr
      flash[:success].should =~ /updated/
    end
  end
end

describe "authentication of edit/update pages" do

  describe "for signed-in users" do

    before(:each) do
      wrong_user = Factory(:user, :email => "user@example.net")
      test_sign_in(wrong_user)
    end

    it "should require matching users for 'edit'" do
      get :edit, :id => @user
      response.should redirect_to(root_path)
    end

    it "should require matching users for 'update'" do
      get :update, :id => @user, :user => {}
      response.should redirect_to(root_path)
    end
  end
end

describe "DELETE 'destroy'" do

  before(:each) do
    @user = Factory(:user)
  end

  describe "as a non-admin user" do
    it "should protect the page" do
      test_sign_in(@user)
      delete :destroy, :id => @user
      response.should redirect_to(root_path)
    end
  end

  describe "as an admin user" do

    before(:each) do
      admin = Factory(:user, :email => "admin@example.com", :admin => true)
      test_sign_in(admin)
    end

    it "should destroy the user" do
      lambda do
        delete :destroy, :id => @user
      end.should change(User, :count).by(-1)
    end

    it "should redirect to the users page" do
      delete :destroy, :id => @user
      response.should redirect_to(users_path)
    end
  end
end

现在整个 users_controller：

class UsersController < ApplicationController
before_filter :authenticate, :only => [:index, :edit, :update, :destroy]
before_filter :correct_user, :only => [:edit, :update]
before_filter :admin_user,   :only => :destroy

def index
  @title = "All users"
  @users = User.paginate(:page => params[:page])
end

def show
  @user = User.find(params[:id])
  @title = @user.name
end

def new
  @user = User.new
  @title = "Sign up"
end

def create
  @user = User.new(params[:user])
  if @user.save
    sign_in @user
    flash[:success] = "Welcome to the Sample App!"
    redirect_to @user
  else
    @title = "Sign up"
    render 'new'
  end
end

def edit
  @title = "Edit user"
end

def update
  @user = User.find(params[:id])
  if @user.update_attributes(params[:user])
    flash[:success] = "Profile updated"
    redirect_to @user
  else
    @title = "Edit user"
    render 'edit'
  end
end

def destroy
  User.find(params[:id]).destroy
  flash[:success] = "User destroyed."
  redirect_to users_path
end

private

  def authenticate
    deny_access unless signed_in?
  end

  def correct_user
    @user = User.find(params[:id])
    redirect_to(root_path) unless current_user?(@user)
  end

  def admin_user
    redirect_to(root_path) unless current_user.admin?
  end
end
4

6 回答 6

1

我遇到了同样的问题，并在此处找到了答案。

基本上 RSPEC 需要同时为 sign_in 和 sign_out 设置 @current_user 和 current user。奇怪和烦人，但也许是人们可能会考虑在生产应用程序中使用 Devise 的原因！

于 2011-11-24T08:06:51.613 回答
0

您在 users_controller_spec 的render_views顶级之后有调用吗？describe

于 2011-11-27T21:07:09.427 回答
0

我今天使用 rails 3.1.3 遇到了同样的问题。但是，我访问了 railstutorial 示例应用程序的 github 站点，并注意到 session_helper.erb 有一些变化。

1.) 在 sign_in(user) 方法中将 'self' 关键字添加到 'current_user' 中：

def sign_in(user)
  cookies.permanent.signed[:remember_token] = [user.id, user.salt]
  self.current_user = user
end

2.) 这也适用于“sign_out”方法，将“self”关键字添加到“current_user”

def sign_out
  cookies.delete(:remember_token)
  self.current_user = nil
end

我没有做其他更改，所有测试都通过了。

于 2011-11-27T21:32:04.463 回答
0

我有同样的问题并使用 Rails 3.1.3。这是我的解决方案。

首先，确保两者：

def current_user=(user)
  @current_user = user
end

def current_user
  @current_user ||= user_from_remember_token
end

在 session_helper.rb 中

此外，在 session_helper.rb 更改：

def sign_out
    cookies.delete(:remember_token)
    current_user.nil
end

至

def sign_out
    cookies.delete(:remember_token)
    self.current_user.nil
end

还有一件事。

在 spec_helper.rb 更改：

def test_sign_in(user)
    controller.sign_in(user)
end

至

def test_sign_in(user)
    controller.current_user = user
end

看看这是否有帮助，我还没有完成这一章，但这让我通过了 10.2.1。有更多经验的人可以评论为什么这样做。我阅读了另一个解决方案，该解决方案依赖于 before_filter 来让 rspec 通过。

于 2011-11-22T22:04:19.213 回答
0

检查是否deny_access在块SessionsHelper之前定义了 in。private

这本书有一个错字，暗示你应该把它放在deny_access模块的末尾。不幸的是，这意味着该函数被定义为私有的。

module SessionsHelper
  .
  .
  .
  def deny_access
    redirect_to signin_path, :notice => "Please sign in to access this page."
  end
end

Railstutorial.org网站上的更正代码如下：

module SessionsHelper
  .
  .
  .
  def deny_access
    redirect_to signin_path, :notice => "Please sign in to access this page."
  end

  private
  .
  .
  .
end
于 2011-11-20T14:54:26.740 回答
0

提供您的控制器和测试代码会很有帮助。但是如果没有它们，我的猜测是您在测试失败的 before 块中缺少此内容：

@user = Factory(:user)
test_sign_in(@user)

重定向发生是因为教程中使用了任何授权逻辑，我认为它在 10.11 和 10.12 中有详细说明。

这是我在使用 auth 的控制器测试中看到的一个常见问题，希望这对你来说也是如此。

编辑：

感谢您提供您的代码。

这是我注意到的几件事：

1.) 失败 1-14、19 是由于用户身份验证不起作用，特别是 signed_in?。您的会话控制器测试通过了吗？在测试用户控制器之前，您绝对应该确保这些通过，因为它取决于该功能。

2.) 失败 15-18 是因为您可能没有创建迁移来添加清单 10.35 中的布尔属性 - 或者 - 您需要在测试数据库上运行迁移：rake db:test:prepare

抱歉，我无法指出您所有的问题，但希望您能朝着正确的方向迈出一步。

于 2011-10-31T22:02:38.140 回答